![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
githubBranch: refs/heads/release-1.13
Home: https://github.com/dreamwidth/dw-free
Commit: 0d22ea649e01322e77a2dfa09fc876e1246d7cc6
https://github.com/dreamwidth/dw-free/commit/0d22ea649e01322e77a2dfa09fc876e1246d7cc6
Author: Afuna <fu@dreamwidth.org>
Date: 2013-01-11 (Fri, 11 Jan 2013)
Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M htdocs/js/jquery.postform.js
M views/entry/form.tt
Log Message:
-----------
(Bug 4826) Remember the previous security level after spellcheck
* for reasons related to changing minsecurity, we rebuild the security
level dropdown with JS. We go back to the dropdown's displayed
value only if it the user had already explicitly selected that level,
rather than us having adjusted it because of minsecurity.
See SHA: d1b7b5fa for a detailed breakdown of this case.
Because we wait until the user has explicitly chosen a security level
from the dropdown, this means that the value of the dropdown on load
is ignored. This is not an issue when making a new entry
(minsecurity), and not an issue when editing (that code path is not
triggered on edit), but is an issue when spellchecking (the initial
value *has* been explicitly selected by the user).
This is much longer than the actual code, but the solution then is to
mark the form as having been spell-checked, and then trust that
initial value as being one the user chose deliberately.
* also removes a couple TODOs re: spellcheck which are no longer
relevant since spellcheck is handled for those cases
Commit: e5a6705a0f85eb1d1befcdc2518a9f1fe0d661b8
https://github.com/dreamwidth/dw-free/commit/e5a6705a0f85eb1d1befcdc2518a9f1fe0d661b8
Author: Afuna <afunamatata+github@gmail.com>
Date: 2013-01-11 (Fri, 11 Jan 2013)
Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M htdocs/js/jquery.postform.js
M views/entry/form.tt
Log Message:
-----------
Merge pull request #210 from afuna/spellcheck-security-bug4826
(Bug 4826) Remember the previous security level after spellcheck
Compare: https://github.com/dreamwidth/dw-free/compare/5213bebfd79b...e5a6705a0f85
Home: https://github.com/dreamwidth/dw-free
Commit: 0d22ea649e01322e77a2dfa09fc876e1246d7cc6
https://github.com/dreamwidth/dw-free/commit/0d22ea649e01322e77a2dfa09fc876e1246d7cc6
Author: Afuna <fu@dreamwidth.org>
Date: 2013-01-11 (Fri, 11 Jan 2013)
Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M htdocs/js/jquery.postform.js
M views/entry/form.tt
Log Message:
-----------
(Bug 4826) Remember the previous security level after spellcheck
* for reasons related to changing minsecurity, we rebuild the security
level dropdown with JS. We go back to the dropdown's displayed
value only if it the user had already explicitly selected that level,
rather than us having adjusted it because of minsecurity.
See SHA: d1b7b5fa for a detailed breakdown of this case.
Because we wait until the user has explicitly chosen a security level
from the dropdown, this means that the value of the dropdown on load
is ignored. This is not an issue when making a new entry
(minsecurity), and not an issue when editing (that code path is not
triggered on edit), but is an issue when spellchecking (the initial
value *has* been explicitly selected by the user).
This is much longer than the actual code, but the solution then is to
mark the form as having been spell-checked, and then trust that
initial value as being one the user chose deliberately.
* also removes a couple TODOs re: spellcheck which are no longer
relevant since spellcheck is handled for those cases
Commit: e5a6705a0f85eb1d1befcdc2518a9f1fe0d661b8
https://github.com/dreamwidth/dw-free/commit/e5a6705a0f85eb1d1befcdc2518a9f1fe0d661b8
Author: Afuna <afunamatata+github@gmail.com>
Date: 2013-01-11 (Fri, 11 Jan 2013)
Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M htdocs/js/jquery.postform.js
M views/entry/form.tt
Log Message:
-----------
Merge pull request #210 from afuna/spellcheck-security-bug4826
(Bug 4826) Remember the previous security level after spellcheck
Compare: https://github.com/dreamwidth/dw-free/compare/5213bebfd79b...e5a6705a0f85