github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2026-06-17 12:43 pm

Convert /manage/externalaccount from BML to Template Toolkit (#3584)

Convert /manage/externalaccount from BML to Template Toolkit (#3584)

Adds DW::Controller::Manage::ExternalAccount plus a Foundation-styled template, replacing htdocs/manage/externalaccount.bml. The form now requires form_auth (the BML page had no CSRF check), and a failed account creation reports an error instead of silently re-rendering.

The site/protocol show-hide JS is rewritten as a vanilla static file (js/pages/manage/externalaccount.js). The old js/externalaccount.js had a typo ("siteProtocool") that threw on every edit page, and even without it the edit page compared the protocolid (LJ-XMLRPC) against section ids built from the protocol registry key (lj), so the option sections were only ever shown by accident; the markup now carries the registry key in data-protocol attributes.

DW::External::XPostProtocol::LJXMLRPC->protocol_options used scope-relative BML::ml keys that only resolved inside the BML page; those strings move to the page's .tt.text and are referenced by full path.

Co-authored-by: Claude Opus 4.8 noreply@anthropic.com

Commit: c25d02a4 Author: Mark Smith