github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2023-05-29 09:51 am

[dreamwidth/dreamwidth] 0dc01c: new GoogleAnalytics4 user setting

Branch: refs/heads/main Home: https://github.com/dreamwidth/dreamwidth Commit: 0dc01c96841009915a526aa0cc07751db43f9dcd https://github.com/dreamwidth/dreamwidth/commit/0dc01c96841009915a526aa0cc07751db43f9dcd Author: Kareila kareila@dreamwidth.org Date: 2023-05-29 (Mon, 29 May 2023)

Changed paths: M bin/upgrading/en.dat M bin/upgrading/proplists.dat A cgi-bin/DW/Setting/GoogleAnalytics4.pm M cgi-bin/LJ/User/Permissions.pm M htdocs/manage/settings/index.bml

Log Message:


new GoogleAnalytics4 user setting

This is the bare minimum of code needed to allow users to tell us their IDs for use with the new version of Google Analytics. It doesn't do anything with that information yet.

  • new module cgi-bin/DW/Setting/GoogleAnalytics4.pm, which is more or less a clone of cgi-bin/DW/Setting/GoogleAnalytics.pm with tweaks

  • both settings modules are retained to allow for a transition period; the labels on /manage/settings are "Google Analytics ID" and "Google Analytics ID (v4)"

  • new userprop ga4_analytics

  • new user method ga4_analytics

I couldn't find a format guideline for the ID values. The setting module enforces a format of "G-" followed by at least 10 alphanumeric characters, saved as uppercase. If that turns out to be wrong, we can tweak it later.

Commit: aeaf54bf90af9f5114c05216748fbb27bbdbb296 https://github.com/dreamwidth/dreamwidth/commit/aeaf54bf90af9f5114c05216748fbb27bbdbb296 Author: momijizukamori momijizukamori+bugzilla@gmail.com Date: 2023-05-29 (Mon, 29 May 2023)

Changed paths: M bin/upgrading/en.dat M bin/upgrading/proplists.dat A cgi-bin/DW/Setting/GoogleAnalytics4.pm M cgi-bin/LJ/User/Permissions.pm M htdocs/manage/settings/index.bml

Log Message:


Merge pull request #3094 from kareila/ga4-setting

[#2954] new GoogleAnalytics4 user setting

Compare: https://github.com/dreamwidth/dreamwidth/compare/298c488621f5...aeaf54bf90af