afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-05-08 02:11 pm

[dw-free] Unable to edit ExternalAccount settings

[commit: http://hg.dwscoalition.org/dw-free/rev/ccf76eb68518]

http://bugs.dwscoalition.org/show_bug.cgi?id=1079

Fix some arguments for redirects

Patch by [personal profile] allen.

Files modified:
  • htdocs/manage/externalaccount.bml
--------------------------------------------------------------------------------
diff -r 9744cbe5ad6a -r ccf76eb68518 htdocs/manage/externalaccount.bml
--- a/htdocs/manage/externalaccount.bml	Fri May 08 13:04:45 2009 +0000
+++ b/htdocs/manage/externalaccount.bml	Fri May 08 14:11:01 2009 +0000
@@ -6,7 +6,7 @@ use strict;
     use vars qw(%GET %POST $title $windowtitle $headextra @errors @warnings);
     
     if ($LJ::USE_SSL && ! $LJ::IS_SSL && $FORM{ssl} ne "no") {
-        my $getextra = $GET{auth} ? "?auth=$GET{auth}" : "";
+        my $getextra = $GET{acctid} ? "?acctid=" . LJ::eurl($GET{acctid}) : "";
         return BML::redirect("$LJ::SSLROOT/manage/externalaccount.bml$getextra");
     }
 
@@ -16,15 +16,11 @@ use strict;
     LJ::set_active_crumb('manage');
 
     my $remote = LJ::get_remote();
-    my $authas;
-    my $u;
 
-    if ($remote) {
-        $authas = $GET{authas} || $remote->user;
-        $u = LJ::get_authas_user($authas);
-        return LJ::bad_input($ML{'error.invalidauth'})
-            unless $u;
-    }
+    my $u = $remote ? LJ::want_user($remote->userid) : undef;
+
+    return "<?needlogin?>" unless $u;
+
     my $max_accts = LJ::get_cap($u, "xpost_accounts");
 
     my %errs;
--------------------------------------------------------------------------------