github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2020-07-12 09:52 pm

[dreamwidth/dw-free] 7b9845: add and use has_response method for DW::Captcha

Branch: refs/heads/master
Home: https://github.com/dreamwidth/dw-free
Commit: 7b984529d6df4fdc5ba683a373ab01037fa3ba46
https://github.com/dreamwidth/dw-free/commit/7b984529d6df4fdc5ba683a373ab01037fa3ba46
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-07-12 (Sun, 12 Jul 2020)

Changed paths:
M cgi-bin/DW/Captcha.pm
M cgi-bin/LJ/Talk.pm
M htdocs/register.bml

Log Message:
-----------
add and use has_response method for DW::Captcha

I'm very grateful for [personal profile] pinterface's illuminating comments on this issue, since I clearly whiffed when I failed to look outside the DW::Captcha module the last time I investigated this problem.

I took the advice about adding a has_response method and used it in the two places that were checking `if ( $captcha->response )` previously.

Fixes #2739.


Commit: 9dd8d8e00ebe609e16f8d0c2c93f8bd06bf709ed
https://github.com/dreamwidth/dw-free/commit/9dd8d8e00ebe609e16f8d0c2c93f8bd06bf709ed
Author: Kareila <kareila@dreamwidth.org>
Date: 2020-07-12 (Sun, 12 Jul 2020)

Changed paths:
M cgi-bin/DW/Captcha.pm

Log Message:
-----------
add POD for has_response method


Compare: https://github.com/dreamwidth/dw-free/compare/fecdeb3a94f1...9dd8d8e00ebe