[dreamwidth/dw-free] 8ee54b: [#2481] Drop spellcheck checkbox from quickreply
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 8ee54bb7b32f03647cf2c1a37b3463452ec2d39f
https://github.com/dreamwidth/dw-free/commit/8ee54bb7b32f03647cf2c1a37b3463452ec2d39f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M views/journal/quickreply.tt
Log Message:
-----------
[#2481] Drop spellcheck checkbox from quickreply
We've already agreed to rip support out soonish, and the control itself
seems to be contributing to some formatting issues for Android Firefox
on site-scheme entry pages.
Commit: 98a49e0248b9a3f6aae151b0c76434264931cf49
https://github.com/dreamwidth/dw-free/commit/98a49e0248b9a3f6aae151b0c76434264931cf49
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M htdocs/scss/components/quick-reply.scss
Log Message:
-----------
Quickreply: Keep bottom buttons from stretching
The default value of align-items is 'stretch', which fills vertical (well,
cross-axis) space to match the tallest item in the container. That's basically
never what we want in this bottom button row.
If something is way too tall, there'll still be undesirable space between
the buttons. But the buttons themselves won't be clownshoes.
Commit: 73c14ed166556b9cf3c3e108443daed131f39356
https://github.com/dreamwidth/dw-free/commit/73c14ed166556b9cf3c3e108443daed131f39356
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M cgi-bin/LJ/Web.pm
M views/journal/quickreply.tt
Log Message:
-----------
Quickreply: RIP quick-er reply
With spellcheck gone, the only two differences between the forms were
the preview button and the quote button, and I don't see a good reason
to exclude either of them from the reading page / recent page. This
option might come back once we unify the talkform and the quickreplies
since we'll be bringing in user-switching controls and the like, so I'm
holding off on removing that from the function's options hash for now.
Commit: 345e4446d85782c003cfda48071ab765c986fa94
https://github.com/dreamwidth/dw-free/commit/345e4446d85782c003cfda48071ab765c986fa94
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M views/journal/quickreply.tt
Log Message:
-----------
[#2519] Quickreply: Add whitespace around buttons
Fixes #2519.
This just removes the whitespace-eating indicators in the template tags, so
there'll be whitespace text nodes between the elements. That should hopefully do
the trick; if not, we can circle back around and add some CSS margins between
them.
Compare: https://github.com/dreamwidth/dw-free/compare/17bad4534c87...345e4446d857
Home: https://github.com/dreamwidth/dw-free
Commit: 8ee54bb7b32f03647cf2c1a37b3463452ec2d39f
https://github.com/dreamwidth/dw-free/commit/8ee54bb7b32f03647cf2c1a37b3463452ec2d39f
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M views/journal/quickreply.tt
Log Message:
-----------
[#2481] Drop spellcheck checkbox from quickreply
We've already agreed to rip support out soonish, and the control itself
seems to be contributing to some formatting issues for Android Firefox
on site-scheme entry pages.
Commit: 98a49e0248b9a3f6aae151b0c76434264931cf49
https://github.com/dreamwidth/dw-free/commit/98a49e0248b9a3f6aae151b0c76434264931cf49
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M htdocs/scss/components/quick-reply.scss
Log Message:
-----------
Quickreply: Keep bottom buttons from stretching
The default value of align-items is 'stretch', which fills vertical (well,
cross-axis) space to match the tallest item in the container. That's basically
never what we want in this bottom button row.
If something is way too tall, there'll still be undesirable space between
the buttons. But the buttons themselves won't be clownshoes.
Commit: 73c14ed166556b9cf3c3e108443daed131f39356
https://github.com/dreamwidth/dw-free/commit/73c14ed166556b9cf3c3e108443daed131f39356
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M cgi-bin/LJ/Web.pm
M views/journal/quickreply.tt
Log Message:
-----------
Quickreply: RIP quick-er reply
With spellcheck gone, the only two differences between the forms were
the preview button and the quote button, and I don't see a good reason
to exclude either of them from the reading page / recent page. This
option might come back once we unify the talkform and the quickreplies
since we'll be bringing in user-switching controls and the like, so I'm
holding off on removing that from the function's options hash for now.
Commit: 345e4446d85782c003cfda48071ab765c986fa94
https://github.com/dreamwidth/dw-free/commit/345e4446d85782c003cfda48071ab765c986fa94
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-24 (Mon, 24 Jun 2019)
Changed paths:
M views/journal/quickreply.tt
Log Message:
-----------
[#2519] Quickreply: Add whitespace around buttons
Fixes #2519.
This just removes the whitespace-eating indicators in the template tags, so
there'll be whitespace text nodes between the elements. That should hopefully do
the trick; if not, we can circle back around and add some CSS margins between
them.
Compare: https://github.com/dreamwidth/dw-free/compare/17bad4534c87...345e4446d857
