github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2019-06-23 08:41 pm

[dreamwidth/dw-free] d3c75e: QR: switch position of random and browse buttons

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: d3c75e2b6af893ae6947a30c5413120ad77ad179
https://github.com/dreamwidth/dw-free/commit/d3c75e2b6af893ae6947a30c5413120ad77ad179
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-23 (Sun, 23 Jun 2019)

Changed paths:
M views/journal/quickreply.tt

Log Message:
-----------
QR: switch position of random and browse buttons

This had immediate consensus in the general channel. I don't have any particular
opinion about it!


Commit: a4c25295c21bf3ac567413006edbf68c5a5589f7
https://github.com/dreamwidth/dw-free/commit/a4c25295c21bf3ac567413006edbf68c5a5589f7
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-23 (Sun, 23 Jun 2019)

Changed paths:
M htdocs/js/jquery.iconselector.js
M htdocs/scss/components/quick-reply.scss
M views/journal/quickreply.tt

Log Message:
-----------
QR: Restore the click-on-icon browse button to the icon preview

This time as an extra, not the only one. I'm also dialing back the hover signal;
it's a simple in-place fade-in, without the zoom.


Commit: 6a6ba664a9efebd03b352a3591dabfe380b7c01d
https://github.com/dreamwidth/dw-free/commit/6a6ba664a9efebd03b352a3591dabfe380b7c01d
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-06-23 (Sun, 23 Jun 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss

Log Message:
-----------
QR: Re-re-re-design: Brutalist Ziggurat Edition

In this re-adjustment, I'm giving up entirely on trying to make two rows of
controls align cleanly with the icon preview, because:

1. In the best case scenario, it was looking better but working worse (due to
adding unnecessary length to the icon selector dropdown, etc.),
2. In the more common scenario, it was also looking worse, due to stretching the
buttons in a way that didn't make sense when compared to the buttons below,
3. TBH it wasn't even working a lot of the time, because of how different
platforms style their form controls! Rounded corners or weird user-agent
!important rules about height and font size were making things not line up
squarely anyway, like 40% of the time!!!

Farewell you beautiful dream (of perfectly straightened picture frames). In its
place, we get a brutalist-in-the-good-sense rethink of the icon controls:

- Consistent and platform-appropriate button styling.
- Ragged-right margin.
- The dropdown only sticks out as far as it needs to, and doesn't get weird
vertical stretch.
- A cool triangular ziggurat kind of shape. 📐🏕🏔

In summary: Looks worse, works better.


Compare: https://github.com/dreamwidth/dw-free/compare/99b34245fcfa...6a6ba664a9ef