changelog | [dreamwidth/dw-free] 650066: [#2410] Less-quick reply: replace table with divs,...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 650066e6f1a6d1d80da49558589a16590baa38c2
https://github.com/dreamwidth/dw-free/commit/650066e6f1a6d1d80da49558589a16590baa38c2
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M views/journal/quickreply.tt

Log Message:
-----------
[#2410] Less-quick reply: replace table with divs, like in quicker reply

- Preserve all of the same options, so it's still the big quick reply.
- Throw away most labels, since they seem redundant.
- Replace icon controls with the cool visual ones from quicker reply.
- Always require quick-reply css.
- Probably needs some CSS adjustments, can't tell until I can see this live.

Commit: ef6afd43c3db1a6a37433a38e124d5f6978ca2d2
https://github.com/dreamwidth/dw-free/commit/ef6afd43c3db1a6a37433a38e124d5f6978ca2d2
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M cgi-bin/LJ/Talk.pm

Log Message:
-----------
[#2410] Include quick-reply css on s2 entry pages as well as lastn pages

Commit: bde1adf7253522c0206c39e65a1e67968fe41c1c
https://github.com/dreamwidth/dw-free/commit/bde1adf7253522c0206c39e65a1e67968fe41c1c
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/js/jquery.quickreply.js

Log Message:
-----------
[#2410] Update icon preview when setting random icon

Commit: c3ef97a87dc04cb6d32551ddfafb82467632dfc8
https://github.com/dreamwidth/dw-free/commit/c3ef97a87dc04cb6d32551ddfafb82467632dfc8
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M views/journal/quickreply.tt

Log Message:
-----------
[#2410] Move random icon and quote buttons to below post body

Commit: 722554df4af27ca873e8bb8cbd16971d86076ca0
https://github.com/dreamwidth/dw-free/commit/722554df4af27ca873e8bb8cbd16971d86076ca0
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss

Log Message:
-----------
[#2410] Make semi-unified quick-reply forms more responsive

Commit: aafbc4d6892195506828267eaf50d7cf1d59784e
https://github.com/dreamwidth/dw-free/commit/aafbc4d6892195506828267eaf50d7cf1d59784e
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss

Log Message:
-----------
[#2410] Cap width of quick-reply component on large desktops

The body textarea was catching an absolute max width from somewhere (probably a
browser-specific interpretation of "cols='80'") and staying at a nice readable
width while the subject and icon inputs expanded above it into infinity.

Well, what's good for the goose is good for the gander, and I didn't want the
body field to go to unreadably-long-lines heck, so I figured out how wide the
current max was (~38rem), capped the width of the surrounding containers to
that, and locked the textarea's width to 100% of its container to make sure it
didn't try any funny business on other browsers that parse "80 cols"
differently.

Commit: e4968e45b4691123144d19b5501409c05fd03c7c
https://github.com/dreamwidth/dw-free/commit/e4968e45b4691123144d19b5501409c05fd03c7c
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss
M views/journal/quickreply.tt

Log Message:
-----------
[#2410] Separate the "submit" buttons from the "misc" ones, if there's room

- Put submit, preview, and spellcheck (if present) together.
- If there's space left in the row, spend it on a gap between the button groups.

Commit: 9acfb2abc88bc8b89a0753d8fad4062f1d919214
https://github.com/dreamwidth/dw-free/commit/9acfb2abc88bc8b89a0753d8fad4062f1d919214
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M views/journal/quickreply.tt

Log Message:
-----------
[#2410] Keep spellcheck checkbox and label together

These should never be split onto separate lines bc that's baffling, so they
shouldn't be independent flex items. A surrounding div can handle that.

Commit: 521f2b8cfb7b6f484b6e90f835ca55de17dccfa1
https://github.com/dreamwidth/dw-free/commit/521f2b8cfb7b6f484b6e90f835ca55de17dccfa1
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M views/journal/quickreply.tt

Log Message:
-----------
[#2410] Move optional icon help to end, by other help

I didn't notice this before because DW prod and dev both omit that
help text, but it would blow up the top row if it were present. Putting
it at the bottom seems fine.

Commit: 9f30ee69c938c87349850e52a87a6d61eabc9987
https://github.com/dreamwidth/dw-free/commit/9f30ee69c938c87349850e52a87a6d61eabc9987
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M views/journal/quickreply.tt

Log Message:
-----------
[#2410] Dry out quickreply.tt

As of the last commit, the only differences between the two versions of the form
are:

- "Quicker" lacks the optional-and-usually-absent icon help text (but eh, it
might as well)
- "Less-quick" has up to four extra controls in a contiguous block between
"submit" and "more options"

So we can cut the file in half by replacing the big if statement with a ~15 line
unless statement.

Commit: 0ac9b8273857816018be986c393fce7ab04eef91
https://github.com/dreamwidth/dw-free/commit/0ac9b8273857816018be986c393fce7ab04eef91
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss

Log Message:
-----------
[#2410] When we're down to ~two buttons per row, avoid messy clumping

This also switches that other media query to the equivalent foundation size
class.

Commit: edd070e2d960f024d61cfce22538a3649cc80931
https://github.com/dreamwidth/dw-free/commit/edd070e2d960f024d61cfce22538a3649cc80931
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss

Log Message:
-----------
[#2410] Fix existing Safari quick-reply bug in some layouts

In some layouts, the quick-reply divs are preceded by floating elements.
(Example in front of me is Fluid Measure, where the entry management links are
`float: left;`.) Something about the way Safari (not Chrome, not FF) calculates
heights makes the floater overlap the outermost quick-reply div by a pixel or
two, which kicks it over to the end of the float and compresses it mightily.

This bug precedes this whole branch, and idk how many layouts it affects. It
look like telling the qrform to `clear: both;` fixes the issue without having
any other effects elsewhere.

Commit: cbde19d4d3284c50401735a2f7bc41f5e75021b0
https://github.com/dreamwidth/dw-free/commit/cbde19d4d3284c50401735a2f7bc41f5e75021b0
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss

Log Message:
-----------
[#2410] Stop *dramatic woodchuck* mobile zoom on input focus

If the font size of an input, select, or textarea is less than 16px, mobile
Webkit/Blink browsers will auto-zoom the viewport as soon as that element gains
focus. That's disorienting, and it also obscures part of most text fields and
makes typing jumpy.

`

media (pointer: coarse)` is an OK proxy for mobile browsers, so we can bump
the font size whenever that's true. (Might sweep up other devices that don't
woodchuck, but anything that specifically says its pointer is inaccurate would
benefit from a size bump anyway.)

I haven't yet found a way to specify "16px or higher," so 16px it is. (The CSS
`max()` function would do the trick, but it's not on a standards track anytime
soon.)

Flexible font size means we can't size the icon preview by px if we want it to
line up nicely when the icon select and the subject input are double-stacked, so
it's time to resize things with ems (after setting a base font size for all
affected elements to make sure that's reliable).

Commit: d36c2a6e07a642cc8288304dc4b4b797439cb04a
https://github.com/dreamwidth/dw-free/commit/d36c2a6e07a642cc8288304dc4b4b797439cb04a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M htdocs/scss/components/quick-reply.scss

Log Message:
-----------
[#2410] Fix quickreply layout on site scheme entry pages

Commit: 381f372d9afb021f7b1f1d5a8cfcb35b1b3d027a
https://github.com/dreamwidth/dw-free/commit/381f372d9afb021f7b1f1d5a8cfcb35b1b3d027a
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-05-24 (Fri, 24 May 2019)

Changed paths:
M htdocs/js/jquery.iconselector.js

Log Message:
-----------
[#2410] Stop wrapping the userpic menu in span.iconselect_trigger_wrapper

I grepped the code for this and couldn't find any current reason for it. And
it's getting in the way of the flexboxes. :|

Commit: 9a31715f0adb59468afaf855d942d7aae8699473
https://github.com/dreamwidth/dw-free/commit/9a31715f0adb59468afaf855d942d7aae8699473
Author: Mark Smith <mark@discordapp.com>
Date: 2019-05-25 (Sat, 25 May 2019)

Changed paths:
M cgi-bin/LJ/Talk.pm
M htdocs/js/jquery.iconselector.js
M htdocs/js/jquery.quickreply.js
M htdocs/scss/components/quick-reply.scss
M views/journal/quickreply.tt

Log Message:
-----------
Merge branch 'mar19_quickreply' of https://github.com/nfagerlund/dw-free into nfagerlund-mar19_quickreply

Commit: 78f4bbfd66b7fc448814607609ac3ed586c789d3
https://github.com/dreamwidth/dw-free/commit/78f4bbfd66b7fc448814607609ac3ed586c789d3
Author: Mark Smith <mark@discordapp.com>
Date: 2019-05-25 (Sat, 25 May 2019)

Changed paths:
M cgi-bin/LJ/Talk.pm
M htdocs/js/jquery.iconselector.js
M htdocs/js/jquery.quickreply.js
M htdocs/scss/components/quick-reply.scss
M views/journal/quickreply.tt

Log Message:
-----------
Merge branch 'nfagerlund-mar19_quickreply' into develop

Compare: https://github.com/dreamwidth/dw-free/compare/9b6ca14d12e1...78f4bbfd66b7