[dreamwidth/dw-free] 99bc82: [#844] Control strip: convert tag soup function to...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 99bc82adbdff1bc2840fc1d39c9f702f15c5fd24
https://github.com/dreamwidth/dw-free/commit/99bc82adbdff1bc2840fc1d39c9f702f15c5fd24
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M cgi-bin/LJ/Web.pm
M htdocs/stc/controlstrip.css
A views/journal/controlstrip.tt

Log Message:
-----------
[#844] Control strip: convert tag soup function to template

There are several open bugs that require minor, straightforward, and
novice-friendly edits to the markup and styling of the control strip, all of
which have languished because it is entirely impossible to make a minor edit to
the markup of the control strip.

Using the quickreply form as a model, this commit dismantles the (totally
heinous) tag soup `$ret .=; $ret .=; etc.;` control_strip function into a
template and a relatively small data structure to drive it, which should
hopefully unblock basically anything simple that needs to be done to the control
strip. It leaves the markup structure and the "what needs to be here" logic
alone, so it shouldn't change the appearance or behavior of the control strip at
all. (There might be one or two missing ` `s, but nothing I've been able to
spot so far.)


Commit: e544e81aeccaad2609a92391843722d784993408
https://github.com/dreamwidth/dw-free/commit/e544e81aeccaad2609a92391843722d784993408
Author: Nick Fagerlund <nick.fagerlund@gmail.com>
Date: 2019-04-30 (Tue, 30 Apr 2019)

Changed paths:
M views/journal/controlstrip.tt

Log Message:
-----------
[#2417] Fix broken control strip logout button (caused by #2230)

Like I said, anything simple that needs to be done to the control strip.


Compare: https://github.com/dreamwidth/dw-free/compare/cd5a0d6d228f...e544e81aecca