![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
[dreamwidth/dw-free] 945e28: Allow email spell-checking to be overridden (#2345...
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 945e28eecbdf2d4da288d307ef9713012e530345
https://github.com/dreamwidth/dw-free/commit/945e28eecbdf2d4da288d307ef9713012e530345
Author: Chris Boyle <chris@boyle.name>
Date: 2018-06-17 (Sun, 17 Jun 2018)
Changed paths:
M cgi-bin/DW/Controller/Admin/SupportCat.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/Create.pm
M cgi-bin/DW/Controller/Support/Submit.pm
M cgi-bin/DW/Setting/ProfileEmail.pm
M cgi-bin/DW/Shop/Item.pm
M cgi-bin/LJ/Console/Command/EmailAlias.pm
M cgi-bin/LJ/HTMLControls.pm
M cgi-bin/LJ/Sysban.pm
M cgi-bin/LJ/User/Message.pm
M cgi-bin/LJ/Widget/ShopItemOptions.pm
M htdocs/admin/sysban.bml
M htdocs/manage/circle/invite.bml
M htdocs/manage/profile/index.bml
M htdocs/shop/account.bml
M htdocs/shop/confirm.bml
M htdocs/support/append_request.bml
M htdocs/tools/tellafriend.bml
M t/check-email.t
M views/admin/supportcat/category.tt
M views/changeemail.tt
M views/create/account.tt
M views/support/request/form.tt
M views/support/submit.tt
Log Message:
-----------
Allow email spell-checking to be overridden (#2345)
* Accept a couple more email domains; add opts{force_spelling}
* Email spelling ticky works on account create and support submit
* Tidy
This TODO was already done before I started.
Didn't mean to change initialisation of @errors.
* Ticky on change email
* Add ticky to invite.bml
* We don't need to prefix these messages
* It's not always "your" email address (gift/ban recipient)
* Ticky-support-category-edit
* Allow spell-check override in email_alias command
* Make tellafriend re-render inputs (next: ticky)
* Ticky!
* Ticky sysban
* Tickybounce: as with sysbans, this ticky is always visible
* Don't spell-check display-email; make greater errors visible
The Edit Profile page is a long way from being able to present unsaved
edits back to the user with an override checkbox (all the fields are
populated from the profile not the submission, and they're handled in
a few different ways).
Therefore I've excluded the display-email from spell-checking, but still
validated it against more serious errors. I've fixed in-passing the fact
that errors in this field would just silently not change this field,
while applying any other changes and appearing to succeed. You now get
a page with just the email error on it, if your email is very invalid.
I think this is ok because modern browsers *should* keep all your edits
when you hit the back button.
* Comment
* Tickyshop; also fix html_datetime retaining POSTed date
* Fix duplicate "selected" flag; looks like anon was the intent when logged out
* Ticky-logged-out-shop
**NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
Home: https://github.com/dreamwidth/dw-free
Commit: 945e28eecbdf2d4da288d307ef9713012e530345
https://github.com/dreamwidth/dw-free/commit/945e28eecbdf2d4da288d307ef9713012e530345
Author: Chris Boyle <chris@boyle.name>
Date: 2018-06-17 (Sun, 17 Jun 2018)
Changed paths:
M cgi-bin/DW/Controller/Admin/SupportCat.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/Create.pm
M cgi-bin/DW/Controller/Support/Submit.pm
M cgi-bin/DW/Setting/ProfileEmail.pm
M cgi-bin/DW/Shop/Item.pm
M cgi-bin/LJ/Console/Command/EmailAlias.pm
M cgi-bin/LJ/HTMLControls.pm
M cgi-bin/LJ/Sysban.pm
M cgi-bin/LJ/User/Message.pm
M cgi-bin/LJ/Widget/ShopItemOptions.pm
M htdocs/admin/sysban.bml
M htdocs/manage/circle/invite.bml
M htdocs/manage/profile/index.bml
M htdocs/shop/account.bml
M htdocs/shop/confirm.bml
M htdocs/support/append_request.bml
M htdocs/tools/tellafriend.bml
M t/check-email.t
M views/admin/supportcat/category.tt
M views/changeemail.tt
M views/create/account.tt
M views/support/request/form.tt
M views/support/submit.tt
Log Message:
-----------
Allow email spell-checking to be overridden (#2345)
* Accept a couple more email domains; add opts{force_spelling}
* Email spelling ticky works on account create and support submit
* Tidy
This TODO was already done before I started.
Didn't mean to change initialisation of @errors.
* Ticky on change email
* Add ticky to invite.bml
* We don't need to prefix these messages
* It's not always "your" email address (gift/ban recipient)
* Ticky-support-category-edit
* Allow spell-check override in email_alias command
* Make tellafriend re-render inputs (next: ticky)
* Ticky!
* Ticky sysban
* Tickybounce: as with sysbans, this ticky is always visible
* Don't spell-check display-email; make greater errors visible
The Edit Profile page is a long way from being able to present unsaved
edits back to the user with an override checkbox (all the fields are
populated from the profile not the submission, and they're handled in
a few different ways).
Therefore I've excluded the display-email from spell-checking, but still
validated it against more serious errors. I've fixed in-passing the fact
that errors in this field would just silently not change this field,
while applying any other changes and appearing to succeed. You now get
a page with just the email error on it, if your email is very invalid.
I think this is ok because modern browsers *should* keep all your edits
when you hit the back button.
* Comment
* Tickyshop; also fix html_datetime retaining POSTed date
* Fix duplicate "selected" flag; looks like anon was the intent when logged out
* Ticky-logged-out-shop
**NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.