changelog | [dreamwidth/dw-free] 9c71da: Fix adult interstitial (#2231)

Branch: refs/heads/code-tour
Home: https://github.com/dreamwidth/dw-free
Commit: 9c71daf781c8d2a26103800b493b211416dddf2e
https://github.com/dreamwidth/dw-free/commit/9c71daf781c8d2a26103800b493b211416dddf2e
Author: Mark Smith <mark@qq.is>
Date: 2017-10-29 (Sun, 29 Oct 2017)

Changed paths:
M cgi-bin/Apache/LiveJournal.pm
M cgi-bin/DW/Hooks/SSL.pm

Log Message:
-----------
Fix adult interstitial (#2231)

This broke when we switched to SSL everywhere. Fix it. Also add a flag
that allows us to just say 'yes, everything is SSL' which is useful.

Commit: b646cdbae01f0aa20804fcaa4e81254339813af1
https://github.com/dreamwidth/dw-free/commit/b646cdbae01f0aa20804fcaa4e81254339813af1
Author: Mark Smith <mark@qq.is>
Date: 2017-10-29 (Sun, 29 Oct 2017)

Changed paths:
M bin/maint/clean_caches.pl
M bin/moveucluster.pl
M bin/upgrading/update-db-general.pl
M cgi-bin/LJ/DB.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Sendmail.pm

Log Message:
-----------
Remove recentactions/actionhistory (#2232)

This functionality is presently unused by Dreamwidth and has crufted.
Let's machete it.

Commit: 63deee4db6d61ce76fd273528d24eb3a334d841a
https://github.com/dreamwidth/dw-free/commit/63deee4db6d61ce76fd273528d24eb3a334d841a
Author: alierak <alierak@gmail.com>
Date: 2017-11-19 (Sun, 19 Nov 2017)

Changed paths:
M cgi-bin/Apache/LiveJournal.pm

Log Message:
-----------
Pass ssl option to internal_redir routing call. (#2237)

Fixes #2233

Commit: f1be1d8dbaa70a70697c796e465b2a388dcb6a97
https://github.com/dreamwidth/dw-free/commit/f1be1d8dbaa70a70697c796e465b2a388dcb6a97
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2017-12-28 (Thu, 28 Dec 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/Create.pm

Log Message:
-----------
Make welcome email unrepliable. Fixes #2222. (#2251)

Commit: c97b5f52a0f749f725d5a2bc62416782ad997c94
https://github.com/dreamwidth/dw-free/commit/c97b5f52a0f749f725d5a2bc62416782ad997c94
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2017-12-30 (Sat, 30 Dec 2017)

Changed paths:
A cgi-bin/DW/Console/Command/Beta.pm

Log Message:
-----------
Implement "beta" console command. Fixes #2217 (#2250)

Commit: 40810496581cccc1447ac55fa8be1dc89c718140
https://github.com/dreamwidth/dw-free/commit/40810496581cccc1447ac55fa8be1dc89c718140
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/Rename.pm

Log Message:
-----------
Add "payments" to privs for /admin/rename/*. (#2256)

Fixes #2205.

Commit: 753e05eb35257af38e77ae6c60531a5bd0c23932
https://github.com/dreamwidth/dw-free/commit/753e05eb35257af38e77ae6c60531a5bd0c23932
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
M bin/upgrading/update-db-general.pl

Log Message:
-----------
Change userlog.ip to varchar(45). Fixes #1818. (#2253)

Commit: b94414cda4338ee9ff208b89b3524ead58f2ad93
https://github.com/dreamwidth/dw-free/commit/b94414cda4338ee9ff208b89b3524ead58f2ad93
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
M cgi-bin/DW/Media.pm
M htdocs/support/see_request.bml
M htdocs/support/see_request.bml.text

Log Message:
-----------
Make methods return sensibly for expunged users. (#2259)

* Make methods return sensibly for expunged users.

- Per bug spec, DW::Media->get_active_for_user, DW::Media->get_quota_for_user,
DW::Media->get_usage_for_use, and LJ::User->can_upload_media now all return
sensible values for an expunged user.
- This exposed a division by 0 in htdocs/support/see_request.bml, which I
also fixed.

Fixes #2200

* Fix division by 0 differently.

Fixes #2200

Commit: aa2409749f71f130e151627dba6d0286476818ac
https://github.com/dreamwidth/dw-free/commit/aa2409749f71f130e151627dba6d0286476818ac
Author: Samuel J. Klein <srukle@dreamwidth.org>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
M bin/upgrading/proplists.dat
M cgi-bin/DW/Logic/ProfilePage.pm
R htdocs/img/profile_icons/aim.gif
M htdocs/manage/profile/index.bml.text
M htdocs/profile.bml.text

Log Message:
-----------
remove AOL from user profile (#2234)

Commit: cf8cbd61f4201196f2d8fa39c06f02a6d77d5d2b
https://github.com/dreamwidth/dw-free/commit/cf8cbd61f4201196f2d8fa39c06f02a6d77d5d2b
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
M cgi-bin/LJ/HTMLControls.pm
M cgi-bin/LJ/Web.pm

Log Message:
-----------
Add tabindex= to month/day/year in entry form. (#2252)

Fixes #2247

Commit: e2cb11c06ade150a4669e09f561adce1a6c65213
https://github.com/dreamwidth/dw-free/commit/e2cb11c06ade150a4669e09f561adce1a6c65213
Author: hotlevel4 <hotlevel4@users.noreply.github.com>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
M cgi-bin/LJ/Event/UserMessageRecvd.pm

Log Message:
-----------
Issue #2219 - Updates text when displaying PM from suspended user (#2245)

Changes text from "Reply from suspended user" to "Message from suspended user"

Fixes #2219

Commit: 60d1e210fa2d541ce269b41613cd9c0e209287cc
https://github.com/dreamwidth/dw-free/commit/60d1e210fa2d541ce269b41613cd9c0e209287cc
Author: Jen <kareila@dreamwidth.org>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
A cgi-bin/DW/Hooks/ProxyCSSLinks.pm

Log Message:
-----------
[#1984] proxy insecure resources loaded from journal styles (#2088)

This defines a css_cleaner_transform hook that looks for style
text of the form "url(...)" and tries to upgrade the specified
URL to HTTPS if the page is using SSL.

Fixes #1984.

Commit: 096897955dd29d3070a813a8ef874e05dffde7ba
https://github.com/dreamwidth/dw-free/commit/096897955dd29d3070a813a8ef874e05dffde7ba
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-01 (Mon, 01 Jan 2018)

Changed paths:
M bin/upgrading/en.dat
M cgi-bin/LJ/Widget/ShopItemOptions.pm

Log Message:
-----------
Prevent buying items for expunged users. (#2260)

As discussed in comments on the bug, this applies to all items, not
just rename tokens.

Fixes #2204.

Commit: 25822ad442e4aef7101febc986512283bffbf9b6
https://github.com/dreamwidth/dw-free/commit/25822ad442e4aef7101febc986512283bffbf9b6
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-02 (Tue, 02 Jan 2018)

Changed paths:
M schemes/common.tt
M schemes/global.tt

Log Message:
-----------
Add domain name prefix to log-in links. (#2261)

Also strip the Log in link text in schemes/common.tt while I'm at it.

Fixes #2180.

Commit: 096178af6679778db597f17a8084d444c5908abc
https://github.com/dreamwidth/dw-free/commit/096178af6679778db597f17a8084d444c5908abc
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-04 (Thu, 04 Jan 2018)

Changed paths:
M cgi-bin/DW/EmailPost/Entry.pm
M t/data/emailpost/parse-props.txt
M t/emailpost.t

Log Message:
-----------
Add "post-screenlevel" post-by-email option. (#2266)

Add automated test for same.

Also fix typo in other email tests because it bugged me.

Fixes #2190.

Commit: 26f8897f869921c2fc2e7268a9f0408aa19119b8
https://github.com/dreamwidth/dw-free/commit/26f8897f869921c2fc2e7268a9f0408aa19119b8
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-06 (Sat, 06 Jan 2018)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/Create.pm

Log Message:
-----------
Better error message on omitting birth year. (#2268)

Fixes #2202.

Commit: 8a24238461f7cdd9183dd0aed76746e3084e2fd6
https://github.com/dreamwidth/dw-free/commit/8a24238461f7cdd9183dd0aed76746e3084e2fd6
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-06 (Sat, 06 Jan 2018)

Changed paths:
M cgi-bin/DW/EmailPost/Entry.pm
M t/data/emailpost/parse-props.txt
M t/emailpost.t

Log Message:
-----------
Implement comma-separated emailpost groups list. (#2267)

Also clarify some of the surrounding code with comments.

Fixes #2201.

Commit: 98533d864c38ac5acfcb340e04045b77f7503984
https://github.com/dreamwidth/dw-free/commit/98533d864c38ac5acfcb340e04045b77f7503984
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-07 (Sun, 07 Jan 2018)

Changed paths:
M cgi-bin/LJ/Feed.pm

Log Message:
-----------
Add "no comment count" RSS/Atom option. (#2273)

Fixes #2165.

Commit: 0ddfc12f4f305ce25490179b667e3b425156f669
https://github.com/dreamwidth/dw-free/commit/0ddfc12f4f305ce25490179b667e3b425156f669
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-08 (Mon, 08 Jan 2018)

Changed paths:
M bin/upgrading/proplists.dat
M cgi-bin/LJ/Event/JournalNewComment/Reply.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/User/Permissions.pm
M htdocs/manage/settings/index.bml

Log Message:
-----------
Remove opt_nomodemail and migrate_prop_to_esn. (#2274)

Fixes #2052.

Commit: fa286f538c9f0a16a4b7d9e7331f09b89327aefe
https://github.com/dreamwidth/dw-free/commit/fa286f538c9f0a16a4b7d9e7331f09b89327aefe
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-08 (Mon, 08 Jan 2018)

Changed paths:
M cgi-bin/DW/BlobStore.pm
M cgi-bin/DW/Controller/Media.pm
M views/media/new.tt

Log Message:
-----------
Use newpost_minsecurity as default image security. (#2272)

Also fix misleading error message.

Fixes #2169.

Commit: ba4b693ca11c60b9ab7808661d0774ee516de7d4
https://github.com/dreamwidth/dw-free/commit/ba4b693ca11c60b9ab7808661d0774ee516de7d4
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-08 (Mon, 08 Jan 2018)

Changed paths:
M etc/config.pl

Log Message:
-----------
Add userlinks => 100 to %CAP_PREMIUM. Fixes #2181. (#2270)

Commit: 1cbec3d810b4db2c2467b0c4f9f74265f14224f1
https://github.com/dreamwidth/dw-free/commit/1cbec3d810b4db2c2467b0c4f9f74265f14224f1
Author: Pau Amma <pauamma@dreamwidth.org>
Date: 2018-01-16 (Tue, 16 Jan 2018)

Changed paths:
M etc/config-private.pl

Log Message:
-----------
Use the right name and sigil in config file.

Fixes #2271.

Commit: c6e0355e42da91e36353d23d869f6c1dfac138cd
https://github.com/dreamwidth/dw-free/commit/c6e0355e42da91e36353d23d869f6c1dfac138cd
Author: Jen <kareila@dreamwidth.org>
Date: 2018-01-16 (Tue, 16 Jan 2018)

Changed paths:
M etc/config-private.pl

Log Message:
-----------
Merge pull request #2292 from pauamma/bug-2271-blobstores-not-blobstore

Use the right name and sigil in config file.

Commit: aa8afa316d76f66bbce0afce1a5fbfc3a55f5cc8
https://github.com/dreamwidth/dw-free/commit/aa8afa316d76f66bbce0afce1a5fbfc3a55f5cc8
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/Community.pm
M views/communities/members/edit.tt
M views/communities/members/edit.tt.text
M views/communities/queue/entries.tt
M views/communities/queue/entries.tt.text

Log Message:
-----------
Add links to community members moderation page. (#2279)

Duplicated mockups to the best of my ability.

Fixes #1785.

Commit: ef2b60b85045b64c96cabccac99f646a2bc508ed
https://github.com/dreamwidth/dw-free/commit/ef2b60b85045b64c96cabccac99f646a2bc508ed
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Logic/ProfilePage.pm
M htdocs/profile.bml.text

Log Message:
-----------
dd to profile userpics stats. Fixes #1706. (#2284)

Fixes #1706

Commit: 6d4e93a44bf2cb8c48f5fccc5dfbe3623149fb09
https://github.com/dreamwidth/dw-free/commit/6d4e93a44bf2cb8c48f5fccc5dfbe3623149fb09
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M bin/upgrading/en.dat
M cgi-bin/LJ/Tags.pm

Log Message:
-----------
Error loudly when renamed-to tag isn't canonical. (#2286)

Fixes #1590.

Commit: 890219ef235a47f594bc6faf794e915a071564f9
https://github.com/dreamwidth/dw-free/commit/890219ef235a47f594bc6faf794e915a071564f9
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/Shop.pm
M views/shop/transferpoints.tt

Log Message:
-----------
Preserve note field itself and its value. (#2285)

- Make sure "can_have_reason" is set in all code paths.

- Preserve note field value, since this won't be done automagically until
conversion to Foundation (see bug #975).

Fixes #1627.

Commit: c97089d0e45809c496a10d3b6d3e4b4c5a56a998
https://github.com/dreamwidth/dw-free/commit/c97089d0e45809c496a10d3b6d3e4b4c5a56a998
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/Support/Highscores.pm

Log Message:
-----------
Skip expunged accounts in support high scores. (#2291)

Fixes #2281.

Commit: 236e902db44578cbb0b6c931b051e53c538dff0a
https://github.com/dreamwidth/dw-free/commit/236e902db44578cbb0b6c931b051e53c538dff0a
Author: Kareila <kareila@dreamwidth.org>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/RPC/MiscLegacy.pm

Log Message:
-----------
fix undefined variable warning in DW/Controller/RPC/MiscLegacy.pm

Can't call method "check_ajax_auth_token" on an undefined value .. cgi-bin/DW/Controller/RPC/MiscLegacy.pm line 696.

Since we aren't forcing $remote to be defined in this code path, use the LJ::Auth
class method instead of the equivalent user method.

Commit: 6edd47b1c3d2ed5dd1406c9dfd1d8bfec444ae36
https://github.com/dreamwidth/dw-free/commit/6edd47b1c3d2ed5dd1406c9dfd1d8bfec444ae36
Author: Kareila <kareila@dreamwidth.org>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M views/communities/list.tt

Log Message:
-----------
fix non-numeric variable warnings in views/communities/list.tt

Argument "" isn't numeric in numeric gt (>) .. views/communities/list.tt line 66.

Argument "" isn't numeric in numeric gt (>) .. views/communities/list.tt line 64.

Commit: 40fce615480b3bd58cbc2c00a90d9ea176999ed8
https://github.com/dreamwidth/dw-free/commit/40fce615480b3bd58cbc2c00a90d9ea176999ed8
Author: Kareila <kareila@dreamwidth.org>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/Rename.pm

Log Message:
-----------
fix undefined variable warning in DW/Controller/Rename.pm

Can't call method "id" on an undefined value .. cgi-bin/DW/Controller/Rename.pm line 234.

Commit: c324baa9872a38e917da96eef67f320e0a875afd
https://github.com/dreamwidth/dw-free/commit/c324baa9872a38e917da96eef67f320e0a875afd
Author: Kareila <kareila@dreamwidth.org>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/Search/Multisearch.pm

Log Message:
-----------
fix undefined variable warning in DW/Controller/Search/Multisearch.pm

Use of uninitialized value in lc .. cgi-bin/DW/Controller/Search/Multisearch.pm line 39.

Commit: ecc5723178533095f80802d84c01a8c98223d407
https://github.com/dreamwidth/dw-free/commit/ecc5723178533095f80802d84c01a8c98223d407
Author: Kareila <kareila@dreamwidth.org>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
fix undefined variable warning in LJ/Userpic.pm

Use of uninitialized value $picid in numeric eq (==) .. cgi-bin/LJ/Userpic.pm line 109.

Commit: 343a58d67e76b039bff60208eb4b98a1ee4429a0
https://github.com/dreamwidth/dw-free/commit/343a58d67e76b039bff60208eb4b98a1ee4429a0
Author: Kareila <kareila@dreamwidth.org>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat

Log Message:
-----------
readd missing string customize.cats.special

Still referenced in cgi-bin/LJ/Customize.pm.

Commit: 56a3418d3ad908d55f15aa78538fa08fe4e8dbd2
https://github.com/dreamwidth/dw-free/commit/56a3418d3ad908d55f15aa78538fa08fe4e8dbd2
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M bin/checkconfig.pl
M cgi-bin/LJ/User/Message.pm
M t/check-email.t

Log Message:
-----------
Spellcheck gmail.com and other common domains. (#2288)

Fixes #993.

Commit: 94153543d4bb0b6d2ae9bc893ff560a4e346efa1
https://github.com/dreamwidth/dw-free/commit/94153543d4bb0b6d2ae9bc893ff560a4e346efa1
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/LJ/User/Data.pm
M doc/raw/memcache-keys.txt
M htdocs/admin/memcache_view.bml

Log Message:
-----------
Remove S1 memcache keys. Fixes #2255. (#2298)

Commit: 2d3b8a7233089df2c943744b55c035dc844849e2
https://github.com/dreamwidth/dw-free/commit/2d3b8a7233089df2c943744b55c035dc844849e2
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M bin/upgrading/proplists.dat

Log Message:
-----------
Remove dogeartime from userprops. Fixes #2223. (#2299)

Commit: 3d07a66dea2e13c5e53addfd488889098cc6cbd4
https://github.com/dreamwidth/dw-free/commit/3d07a66dea2e13c5e53addfd488889098cc6cbd4
Author: Pau Amma <fduuvrzv@yahoo.com>
Date: 2018-01-20 (Sat, 20 Jan 2018)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/EmailPost/Entry.pm
M cgi-bin/DW/Media.pm

Log Message:
-----------
Change LJ::User methods in DW::Media to DW::Media (#2297)

methods. Fixes #2258.

Compare: https://github.com/dreamwidth/dw-free/compare/3fe67cd54644...3d07a66dea2e