github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2017-04-06 04:32 pm

[dreamwidth/dw-free] 4cfbdb: [#2064] fix bug with editicons conversion: LJ::Use...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 4cfbdb4c2a87c0eea0289b4e972eaa6a869a0c9b
https://github.com/dreamwidth/dw-free/commit/4cfbdb4c2a87c0eea0289b4e972eaa6a869a0c9b
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-04-05 (Wed, 05 Apr 2017)

Changed paths:
M views/edit/icons.tt

Log Message:
-----------
[#2064] fix bug with editicons conversion: LJ::Userpic->keywords

This method uses wantarray to determine whether to return
an array or a string of keywords joined by commas.

Template Toolkit method calls will always request array context,
unless you use the Scalar plugin to force scalar context.

http://mail.template-toolkit.org/pipermail/templates/2008-June/010235.html


Commit: 0a9ccea1f0f244b031b67badda47ddd2d7b5fbff
https://github.com/dreamwidth/dw-free/commit/0a9ccea1f0f244b031b67badda47ddd2d7b5fbff
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-04-05 (Wed, 05 Apr 2017)

Changed paths:
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Userpics.pm

Log Message:
-----------
[#2041] fix bug with BlobStore conversion: data vs dataref

Looks like the 'store' method expects a reference to whatever
data it is given - in this case, a frozen hashref. If it doesn't
get exactly what it expects, it croaks, and any subsequent
processing is aborted.

This fixes the reported problem in my testing, using the case
of not having enough icon slots to import all of the other
account's icons.

Fixes #2041.


Commit: adf91b1700f31e6c82342d38d65d7b5c859a24be
https://github.com/dreamwidth/dw-free/commit/adf91b1700f31e6c82342d38d65d7b5c859a24be
Author: Mark Smith <mark@qq.is>
Date: 2017-04-06 (Thu, 06 Apr 2017)

Changed paths:
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Userpics.pm
M views/edit/icons.tt

Log Message:
-----------
Merge pull request #2069 from kareila/2041-importicons

fix code conversion bugs


Compare: https://github.com/dreamwidth/dw-free/compare/b50e6216a7d1...adf91b1700f3