changelog | [dreamwidth/dw-free] 774f90: [#1931] delete associated thumbnails when a media ...

Branch: refs/heads/code-tour
Home: https://github.com/dreamwidth/dw-free
Commit: 774f909fb8bc5796c10c256c04b0ed0eaf9e906f
https://github.com/dreamwidth/dw-free/commit/774f909fb8bc5796c10c256c04b0ed0eaf9e906f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M cgi-bin/DW/Media/Base.pm
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
[#1931] delete associated thumbnails when a media image is deleted

This calls the parent method to do the deletion as before,
then looks for other versions of the same image to also
delete from storage once the original is gone.

Fixes #1931.

Commit: e69e7d5c029c73508a944ea4e52bd8ede85c93b6
https://github.com/dreamwidth/dw-free/commit/e69e7d5c029c73508a944ea4e52bd8ede85c93b6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-09 (Thu, 09 Feb 2017)

Changed paths:
M cgi-bin/DW/Media.pm

Log Message:
-----------
[#1940] don't count deleted files against quotas

I realized when testing the new delete method that the
relevant rows in media_versions are preserved, so we
need to crosscheck against the 'state' column of the
media table and make sure we aren't counting the
sizes of deleted files against the user's quota.

Commit: ef8d8017fc90c0ec2b34cba1d0787fb594385389
https://github.com/dreamwidth/dw-free/commit/ef8d8017fc90c0ec2b34cba1d0787fb594385389
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-11 (Sat, 11 Feb 2017)

Changed paths:
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
incorporate feedback from code review

Commit: 1866146ec1b4e9cd952de48353f102dd33659f3a
https://github.com/dreamwidth/dw-free/commit/1866146ec1b4e9cd952de48353f102dd33659f3a
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
A bin/erase-imported-content
R bin/erase-imported-content.pl
A bin/importadm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal.pm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Comments.pm
M cgi-bin/DW/Worker/ContentImporter/LiveJournal/Entries.pm
M cgi-bin/DW/Worker/ContentImporter/Local/Entries.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/User/Account.pm
M cgi-bin/LJ/User/Display.pm
M cgi-bin/LJ/Widget/ImportChooseSource.pm

Log Message:
-----------
Update importer

This is a collection of fixes over the past two months since the
importer was under heavier use. Also some tooling updates.

Commit: d6e83bde7c848f107df6e6ceda4c93a388528bb1
https://github.com/dreamwidth/dw-free/commit/d6e83bde7c848f107df6e6ceda4c93a388528bb1
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M bin/worker/esn-process-sub
M cgi-bin/DW/Stats.pm

Log Message:
-----------
Updates

Commit: 443c194f10f03aa192bd2ea5f9171929a5d6ac76
https://github.com/dreamwidth/dw-free/commit/443c194f10f03aa192bd2ea5f9171929a5d6ac76
Author: Mark Smith <mark@qq.is>
Date: 2017-02-12 (Sun, 12 Feb 2017)

Changed paths:
M cgi-bin/DW/Media.pm
M cgi-bin/DW/Media/Base.pm
M cgi-bin/DW/Media/Photo.pm

Log Message:
-----------
Merge pull request #1969 from kareila/1931-delete-thumbnails

delete associated thumbnails when a media image is deleted

Commit: 2bd9807410def80a06f10a97a1f1cb36b51434fb
https://github.com/dreamwidth/dw-free/commit/2bd9807410def80a06f10a97a1f1cb36b51434fb
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
[#1936] fix missing single quote in thumbnail embed text

Commit: 04389dda95709fee16ca73ae74b05a6f24fbba78
https://github.com/dreamwidth/dw-free/commit/04389dda95709fee16ca73ae74b05a6f24fbba78
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Graphs.pm
M cgi-bin/DW/Graphs.pm

Log Message:
-----------
change LF to CRLF in graph labels to display properly

Commit: 1887e5374ef596480f54c8dd762ca95d5fe98ea5
https://github.com/dreamwidth/dw-free/commit/1887e5374ef596480f54c8dd762ca95d5fe98ea5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M htdocs/stats.bml

Log Message:
-----------
remove early return from stats.bml

This early return prevented the "pretty graphs" from being
printed, with a comment saying they were broken. @alierak
says they are not broken - looks like newbyday.png is
generated by bin/maint/statspics.pl. The early return
dates from the original LJ import.

Commit: 368182a36b41ef83a9c6c7065654c59c4d641b40
https://github.com/dreamwidth/dw-free/commit/368182a36b41ef83a9c6c7065654c59c4d641b40
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M htdocs/stats.bml
M htdocs/stats.bml.text

Log Message:
-----------
graph printing logic improvements

While we're here, only try to display the image if the
image file exists, and English-strip the text.

Commit: 993d91d280f8983ea3799f7411213affb43efd35
https://github.com/dreamwidth/dw-free/commit/993d91d280f8983ea3799f7411213affb43efd35
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
fix remote checking for access control of media files

Use a controller to do basic setup checking, including
bouncing for a user domain cookie if needed - LJ::get_remote
was failing when the user domain cookie wasn't available.

With that working, we can add functional support for viewall,
and remove the FIXME comment that requested it.

Commit: 48f7f7b18cf7312855565d58d6656b3a64d6ad7c
https://github.com/dreamwidth/dw-free/commit/48f7f7b18cf7312855565d58d6656b3a64d6ad7c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
[#1940] allow hotlinking from crosspost sites

As @kaberett pointed out, crossposted entries that reference
hosted images will fail to load on the remote site, so let's
whitelist all known crosspost sites.

Commit: 3d7b6a1134b0b86e442f374a3e5aa15de3368376
https://github.com/dreamwidth/dw-free/commit/3d7b6a1134b0b86e442f374a3e5aa15de3368376
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
[#1981] anchor regexp in break_word subroutine

Fixes #1981.

Commit: 47b3933b5ab574d8f56d2f5b2ab1ba1fff83a340
https://github.com/dreamwidth/dw-free/commit/47b3933b5ab574d8f56d2f5b2ab1ba1fff83a340
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix uploading of all sizes of icons

I've tested editicons on my hack with this fix in place and
all FOUR upload flows (small, medium, large, and URL) seem
to work fine now for me.

Commit: b1ba2b6613e09bf4bfd44f513cf365e1703c7ef1
https://github.com/dreamwidth/dw-free/commit/b1ba2b6613e09bf4bfd44f513cf365e1703c7ef1
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
Merge pull request #1982 from kareila/1981-entities

[#1981] anchor regexp in break_word subroutine

Commit: 912dd34fe3f9fd5ab1a3485dee1c8b3339618861
https://github.com/dreamwidth/dw-free/commit/912dd34fe3f9fd5ab1a3485dee1c8b3339618861
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M htdocs/stats.bml
M htdocs/stats.bml.text

Log Message:
-----------
Merge pull request #1978 from kareila/show_stats_graph

re-enable stats graph printing

Commit: 79954c51a1ec867f4b2865f936924a72361458f7
https://github.com/dreamwidth/dw-free/commit/79954c51a1ec867f4b2865f936924a72361458f7
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
Merge pull request #1980 from kareila/1960-crossposts

fixes for media file access

Commit: 3b9f7ac308a657e6a770a3476316bb56727990e1
https://github.com/dreamwidth/dw-free/commit/3b9f7ac308a657e6a770a3476316bb56727990e1
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Graphs.pm
M cgi-bin/DW/Graphs.pm

Log Message:
-----------
Merge pull request #1977 from alierak/graph_labels_crlf

change LF to CRLF in graph labels to display properly

Commit: 0cf1d70e38795791f5b974d1a95a7721efaa7a71
https://github.com/dreamwidth/dw-free/commit/0cf1d70e38795791f5b974d1a95a7721efaa7a71
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
Merge pull request #1983 from kareila/editicons-fix

fix uploading of non-factory, non-URL icons

Commit: eb9640e01dd422685ec586c2cef703c0474d49c5
https://github.com/dreamwidth/dw-free/commit/eb9640e01dd422685ec586c2cef703c0474d49c5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Feeds.pm

Log Message:
-----------
fix undefined warning in DW/Controller/Feeds.pm

Use of uninitialized value in pattern match (m//) at /home/dw/production/cgi-bin/DW/Controller/Feeds.pm line 72.

Commit: 29afdd466c3857ecf573dbbbed8d9226a56682f6
https://github.com/dreamwidth/dw-free/commit/29afdd466c3857ecf573dbbbed8d9226a56682f6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix undefined warning in DW/Controller/EditIcons.pm

Use of uninitialized value in string eq .. cgi-bin/DW/Controller/EditIcons.pm line 163.

Commit: 60d05bad8ddbd27c656865e8db30679289757d13
https://github.com/dreamwidth/dw-free/commit/60d05bad8ddbd27c656865e8db30679289757d13
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
fix undefined warning in LJ/Userpic.pm

Use of uninitialized value $w in numeric ge (>=) .. cgi-bin/LJ/Userpic.pm line 682.

Commit: 2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
https://github.com/dreamwidth/dw-free/commit/2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Use of $# considered harmful

This construction returns the index of the last item rather than the
count which means this was only returning true once the file had
replicated, which while often successful is definitely not what we want.

Commit: fd10742691d7fa50859287df90ab77a2a9145ba3
https://github.com/dreamwidth/dw-free/commit/fd10742691d7fa50859287df90ab77a2a9145ba3
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Merge pull request #1986 from zorkian/fix-off-by-one

Use of $# considered harmful

Commit: b2ab126f4681dd98e213752dfaa2f105154a9b64
https://github.com/dreamwidth/dw-free/commit/b2ab126f4681dd98e213752dfaa2f105154a9b64
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Poll.pm

Log Message:
-----------
avoid die statement in LJ/Poll.pm

Error loading poll id: 1903855: Invalid journalid at /home/dw/production/cgi-bin/LJ/Poll.pm line 558.

This seemed the best course of action, since we're also
returning undef if the subsequent row lookup fails.

Commit: 1b9abedbfbaf852114844964841b8d6209026698
https://github.com/dreamwidth/dw-free/commit/1b9abedbfbaf852114844964841b8d6209026698
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
avoid calling method on undefined object in DW/Routing.pm

Can't call method "journal_base" on an undefined value at /home/dw/production/cgi-bin/DW/Routing.pm line 209

Tweak the conditional logic so that $renamed_u must be
valid if we want to redirect to it.

Commit: ae9ef2cf874669c36829ad8b13129a0b4770ba8e
https://github.com/dreamwidth/dw-free/commit/ae9ef2cf874669c36829ad8b13129a0b4770ba8e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/ChangeEmail.pm

Log Message:
-----------
fix undefined warning in DW/Controller/ChangeEmail.pm

Use of uninitialized value in string ne at /home/dw/production/cgi-bin/DW/Controller/ChangeEmail.pm line 84.

First, we don't need to check is_identity when assigning $password,
because we check for it in the conditional.

Second, we should actually use $password if we assign it.

Third, put the short-circuit check ($remote->is_identity)
first, to avoid unnecessarily checking a string that will
be undefined in that particular case.

Fourth, OK to error if $password is undef, since that can never be
the correct password. Identity accounts can have undefined pws
but we've already accounted for that.

Commit: 850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
https://github.com/dreamwidth/dw-free/commit/850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
fix undefined warning in DW/Controller/API/Media.pm

Use of uninitialized value $type in numeric eq (==) at /home/dw/production/cgi-bin/DW/Controller/API/Media.pm line 74.

Commit: e69b60fbd008183682bf8f910f54cc61c6e11ecd
https://github.com/dreamwidth/dw-free/commit/e69b60fbd008183682bf8f910f54cc61c6e11ecd
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf

Log Message:
-----------
[#1988] remove LJ/EventLogRecord.pm and submodules

Fixes #1988.

Commit: fd912965db3686b34ff5e93dd57551504e3d9280
https://github.com/dreamwidth/dw-free/commit/fd912965db3686b34ff5e93dd57551504e3d9280
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M t/post.t

Log Message:
-----------
removal of EventLogRecord from postevent causes test failures

Failed test 'Public security'
at t/post.t line 394.
got: undef
expected: 'public'

Failed test 'Public security'
at t/post.t line 403.
got: undef
expected: 'public'

Failed test 'Locked security'
at t/post.t line 415.
got: undef
expected: 'usemask'

In all three cases, changing $entry->{security} to $entry->security
fixed the problem, because that causes the object's hash data to be
populated. Previously, the data was populated within the context of
the EventLogRecord job in postevent.

Commit: 1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
https://github.com/dreamwidth/dw-free/commit/1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use correct user object when deleting existing slugs

Fixes #1992.

Commit: 4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
https://github.com/dreamwidth/dw-free/commit/4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Entry.pm
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use another method to repopulate the entry object data

At first I thought I would need to audit the code for
uses of $entry->{security} instead of $entry->security,
and while I did find and change a few of those, I quickly
realized a less scattershot approach would be to drop in
another method call in place of the removed one that had
the same side effect of populating the data in the cached
entry object.

With that done, the failing test once again passes
(although I'm still committing the fixed version).

Commit: 4b4f745e77f45cb387c65819c5d7a15618c231ea
https://github.com/dreamwidth/dw-free/commit/4b4f745e77f45cb387c65819c5d7a15618c231ea
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
[#1983] fix one more occurrence of reference mismatch errors

Found 4 paths before; 5th path is obscure edge case where icon
is 100x100 or less, but file size is > $MAX_UPLOAD. I think
this edit removes the last direct references to $POST->{$userpic_key}
from parse_post_uploads. This is the error in the logs:

FATAL> BlobStore.pm:100 DW::BlobStore::store | Store requires data be a scalar reference. at /home/dw/production/cgi-bin/DW/Controller/EditIcons.pm line 215.

Commit: c172a10daa9e7f9c6aea4a66f92581555d5f612f
https://github.com/dreamwidth/dw-free/commit/c172a10daa9e7f9c6aea4a66f92581555d5f612f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
[#1855] improve handling of media load errors on /file/edit

1. Early return if we have a 'null' or undef mediaid.

2. Eval call to DW::Media->new so we return an API error
instead of croaking if it failed.

Fixes #1855.

Commit: 1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
https://github.com/dreamwidth/dw-free/commit/1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
remove unused variable from DW::Routing

Commit: 7400b91371eecaf4e604b2085d35a05c72dfc5a5
https://github.com/dreamwidth/dw-free/commit/7400b91371eecaf4e604b2085d35a05c72dfc5a5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
additional headers for media file requests

Discussion with @alierak led to the conclusion that media files
should use the Cache-Control and Last-Modified headers.

Inspection of Apache/LiveJournal.pm and Apache/BML.pm indicates
that Cache-Control should be applied to all user content responses,
so we make that the new default behavior for user content in DW/Routing.pm.

The Last-Modified header is set in the media file controller as the
upload date of the file, which will never change.

Without the Last-Modified header, the image may be redownloaded
unnecessarily. Without the Cache-Control header, Cloudflare
caching may interfere with the ability to load the image correctly.

Commit: b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
https://github.com/dreamwidth/dw-free/commit/b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/EditIcons.pm
M cgi-bin/DW/Controller/Feeds.pm
M cgi-bin/DW/Routing.pm
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
Merge pull request #1991 from kareila/cleanup-2017q1

Post-push log cleanup

Commit: e94a1a9b5351bdbc75ba2acb971cc0770237a584
https://github.com/dreamwidth/dw-free/commit/e94a1a9b5351bdbc75ba2acb971cc0770237a584
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
Merge pull request #1993 from kareila/1992-edit-slugs

use correct user object when deleting existing slugs

Commit: 04b51784361961dfcbbd70112b08b0cf49b901d0
https://github.com/dreamwidth/dw-free/commit/04b51784361961dfcbbd70112b08b0cf49b901d0
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
Merge pull request #2001 from kareila/1983-autoscale

[#1983] fix one more occurrence of reference mismatch errors

Commit: ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
https://github.com/dreamwidth/dw-free/commit/ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
Merge pull request #2002 from kareila/1855-null-mediaid

[#1855] improve handling of media load errors on /file/edit

Commit: ecba2a889335572f0ff0125eee0d9ca1b9eda166
https://github.com/dreamwidth/dw-free/commit/ecba2a889335572f0ff0125eee0d9ca1b9eda166
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf
M t/post.t

Log Message:
-----------
Merge pull request #1994 from kareila/1988-EventLogRecord

[#1988] remove LJ/EventLogRecord.pm and submodules

Commit: 8410894ea119c8fe13b0ccb88db949c9ece082f9
https://github.com/dreamwidth/dw-free/commit/8410894ea119c8fe13b0ccb88db949c9ece082f9
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
Merge pull request #2003 from kareila/media-headers

additional headers for media file requests

Commit: b46d5882591896da59ef1a7b430e861557fe9cb1
https://github.com/dreamwidth/dw-free/commit/b46d5882591896da59ef1a7b430e861557fe9cb1
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
A t/cleaner-markdown.t

Log Message:
-----------
[#1990] don't transform username tags in URLs

I thought about bringing out the heavy artillery (aka HTML::Parser)
but realized that even if we just transformed on plain text,
things that look like usernames in plain URLs would still be
mangled. So this just tweaks the existing regular expression to
ignore "@username" if immediately preceded by a slash.

Fixes #1990.

Commit: 242782ce646d7c902d15f801951a0f1229f40ea8
https://github.com/dreamwidth/dw-free/commit/242782ce646d7c902d15f801951a0f1229f40ea8
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm

Log Message:
-----------
remove trailing whitespace in DW/Controller/Support/History.pm

Commit: f76833a122ae7a7a40c3b4c20161fc9da65b00a7
https://github.com/dreamwidth/dw-free/commit/f76833a122ae7a7a40c3b4c20161fc9da65b00a7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M views/support/history.tt
M views/support/history.tt.text

Log Message:
-----------
additional search field in template

Commit: 486a0a18d665978efb217e2f1b72edb9d60132b6
https://github.com/dreamwidth/dw-free/commit/486a0a18d665978efb217e2f1b72edb9d60132b6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/Search.pm

Log Message:
-----------
remove Dumper from DW/Controller/Support/Search.pm

Commit: f49608d5cd0954b038be4e9aac2c8c7d75174a5f
https://github.com/dreamwidth/dw-free/commit/f49608d5cd0954b038be4e9aac2c8c7d75174a5f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/Search.pm

Log Message:
-----------
refactor search task into separate function do_search

Commit: d7293bf45fc03d2ee7587225e4dfb3640a4e2473
https://github.com/dreamwidth/dw-free/commit/d7293bf45fc03d2ee7587225e4dfb3640a4e2473
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm
M cgi-bin/DW/Controller/Support/Search.pm

Log Message:
-----------
do search from history page

Commit: 09e99f7b4f1f4a3b0b08c57751217bc2b820e711
https://github.com/dreamwidth/dw-free/commit/09e99f7b4f1f4a3b0b08c57751217bc2b820e711
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-22 (Wed, 22 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm
M views/support/history.tt

Log Message:
-----------
change fullsearch from get to post

Commit: e31ba34c645c9967594e70615a8a0d00fdb587ae
https://github.com/dreamwidth/dw-free/commit/e31ba34c645c9967594e70615a8a0d00fdb587ae
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller.pm

Log Message:
-----------
[#2003] also use error header for Cache-Control

@alierak explains that there are two header tables, one
for successes (which header_out uses) and one for errors
and redirects (which err_header_out uses). So we need to
make sure that user cookie bounces use err_header_out to
avoid caching.

He says we could probably set this header on every request,
but let's start with the one place where we know we need it.

(Most of this is whitespace cleanup; the last line is the
bit that does the thing.)

Commit: ede6a2b9a5fe87800aa18978e2f4b5127d710449
https://github.com/dreamwidth/dw-free/commit/ede6a2b9a5fe87800aa18978e2f4b5127d710449
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
also use no-cache for image load 403 errors

Commit: 24b20fce013bdd5e273077aa3818ade31b52e00e
https://github.com/dreamwidth/dw-free/commit/24b20fce013bdd5e273077aa3818ade31b52e00e
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-24 (Fri, 24 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller.pm
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
Merge pull request #2007 from kareila/cache-control

[#2003] also use error header for Cache-Control

Commit: 6d446edebb2f0174fb1ffeb4d68e7f3d13d80e95
https://github.com/dreamwidth/dw-free/commit/6d446edebb2f0174fb1ffeb4d68e7f3d13d80e95
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-28 (Tue, 28 Feb 2017)

Changed paths:
M cgi-bin/LJ/Event/SecurityAttributeChanged.pm
M cgi-bin/LJ/User/Administration.pm

Log Message:
-----------
[#2016] look for both possible saved orderings

I can confirm that this lookup works in testing with unsorted data.
I'm also adding a sort to log_event so prevent similar problems
in the future, but that won't correct previously logged events.

Fixes #2016.

Commit: 26a4de577847de6f9ff9bcc35b0175b7b3be9f60
https://github.com/dreamwidth/dw-free/commit/26a4de577847de6f9ff9bcc35b0175b7b3be9f60
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
A cgi-bin/DW/Controller/Manage/Index.pm
M cgi-bin/redirect.dat
R htdocs/manage/index.bml
R htdocs/manage/index.bml.text
A views/manage/index.tt
A views/manage/index.tt.text

Log Message:
-----------
convert manage/index.bml to TT

This doesn't use Foundation styling, just gets rid
of the ugly BML coding blocks and layout tables,
and updates some display text.

Commit: ea1056381db32d1aba1e8f12d3fc0b70638ce5d3
https://github.com/dreamwidth/dw-free/commit/ea1056381db32d1aba1e8f12d3fc0b70638ce5d3
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/Setting/BoolSetting.pm

Log Message:
-----------
fix undefined value warning in LJ/Setting/BoolSetting.pm

Use of uninitialized value $new_val in string eq at /home/dw/production/cgi-bin/LJ/Setting/BoolSetting.pm line 71.

Commit: 757d539303fb88717545e2cf449cf7fe99409e59
https://github.com/dreamwidth/dw-free/commit/757d539303fb88717545e2cf449cf7fe99409e59
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/RPC/Misc.pm

Log Message:
-----------
fix undefined value warning in DW/Controller/RPC/Misc.pm

Can't call method "user" on an undefined value at /home/dw/production/cgi-bin/DW/Controller/RPC/Misc.pm line 35.

Commit: 83faa4a1df8f645bdc6104507f51b32f830c957d
https://github.com/dreamwidth/dw-free/commit/83faa4a1df8f645bdc6104507f51b32f830c957d
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/Community.pm

Log Message:
-----------
fix undefined value warning in LJ/Community.pm

Can't call method "userid" on an undefined value at /home/dw/production/cgi-bin/LJ/Community.pm line 720.

Also strips trailing whitespace.

Commit: 96766bfa72111d5bc5cff0de6160f66e8c76498c
https://github.com/dreamwidth/dw-free/commit/96766bfa72111d5bc5cff0de6160f66e8c76498c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M bin/checkconfig.pl

Log Message:
-----------
add debian pkg name for log4perl

Commit: 3bb1cfd50e83cd23d55a2f5e564b5bb2619ab872
https://github.com/dreamwidth/dw-free/commit/3bb1cfd50e83cd23d55a2f5e564b5bb2619ab872
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M htdocs/customize/advanced/styles.bml

Log Message:
-----------
fix duplicate scoped variable warning in advanced/styles.bml

"my" variable $dis masks earlier declaration in same scope .. htdocs/customize/advanced/styles.bml line 445.

Commit: 35d9f14e4e6147f1569d0365bf1a203aec42a6e5
https://github.com/dreamwidth/dw-free/commit/35d9f14e4e6147f1569d0365bf1a203aec42a6e5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M htdocs/customize/advanced/styles.bml

Log Message:
-----------
strip trailing whitespace in /customize/advanced/styles

Commit: 1af5de9ddf1a641ada27f089446c85b7404a887c
https://github.com/dreamwidth/dw-free/commit/1af5de9ddf1a641ada27f089446c85b7404a887c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm

Log Message:
-----------
fix numeric eq warning in XPostProtocol/LJXMLRPC.pm

Argument "Client" isn't numeric in numeric eq (==) at /home/dw/production/cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm line 53.

... Yeah, I dunno either, but treating it like a string will fix the warning.

Commit: ecb3187aaee9e2ebcc4165e70b16d0386be83869
https://github.com/dreamwidth/dw-free/commit/ecb3187aaee9e2ebcc4165e70b16d0386be83869
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/InviteCodes.pm

Log Message:
-----------
fix undefined value warning in DW/Controller/InviteCodes.pm

Use of uninitialized value in numeric comparison (<=>) .. cgi-bin/DW/Controller/InviteCodes.pm line 79.

Commit: 686e56bb6f8fa1d687167e4c239e15e3fdcba6c0
https://github.com/dreamwidth/dw-free/commit/686e56bb6f8fa1d687167e4c239e15e3fdcba6c0
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M bin/checkconfig.pl
M cgi-bin/DW/Controller/InviteCodes.pm
M cgi-bin/DW/Controller/RPC/Misc.pm
M cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm
M cgi-bin/LJ/Community.pm
M cgi-bin/LJ/Setting/BoolSetting.pm
M htdocs/customize/advanced/styles.bml

Log Message:
-----------
Merge pull request #2020 from kareila/cleanup-2017q1

more cleanup

Commit: 4c80f7a20d0ef603bd2743ebe5ef9ec954a0366e
https://github.com/dreamwidth/dw-free/commit/4c80f7a20d0ef603bd2743ebe5ef9ec954a0366e
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/Event/SecurityAttributeChanged.pm
M cgi-bin/LJ/User/Administration.pm

Log Message:
-----------
Merge pull request #2017 from kareila/2016-userlog-extra

[#2016] look for both possible saved orderings

Commit: 4924682f9d6975dae141e240d891b2f7b49dadbc
https://github.com/dreamwidth/dw-free/commit/4924682f9d6975dae141e240d891b2f7b49dadbc
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/Support/History.pm
M cgi-bin/DW/Controller/Support/Search.pm
M views/support/history.tt
M views/support/history.tt.text

Log Message:
-----------
Merge pull request #2005 from kareila/1957-support-search

[#1957] add request text search to /support/history

Commit: 7f8f41f19d4265d8342ef8f3f775886fd06977ef
https://github.com/dreamwidth/dw-free/commit/7f8f41f19d4265d8342ef8f3f775886fd06977ef
Author: Mark Smith <mark@qq.is>
Date: 2017-03-02 (Thu, 02 Mar 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
A t/cleaner-markdown.t

Log Message:
-----------
Merge pull request #2004 from kareila/1990-markdown-usernames

[#1990] don't transform username tags in URLs

Commit: 4fe1215a92d3977079da4c5e03f0369732699581
https://github.com/dreamwidth/dw-free/commit/4fe1215a92d3977079da4c5e03f0369732699581
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
R cgi-bin/LJ/Setting/FOAFURL.pm

Log Message:
-----------
remove unused module LJ/Setting/FOAFURL.pm

Commit: af0b723a603ed858993ebae9baacccc7f743b728
https://github.com/dreamwidth/dw-free/commit/af0b723a603ed858993ebae9baacccc7f743b728
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
R bin/upgrading/migrate-userprop.pl
M bin/upgrading/proplists.dat
M bin/upgrading/update-db.pl
M cgi-bin/LJ/Feed.pm
M cgi-bin/LJ/User/Styles.pm

Log Message:
-----------
remove external_foaf_url userprop

Commit: 1a7b3329ef13d35ff17ed9ec5fc01f82c70f1196
https://github.com/dreamwidth/dw-free/commit/1a7b3329ef13d35ff17ed9ec5fc01f82c70f1196
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
M bin/upgrading/update-db.pl

Log Message:
-----------
strip trailing whitespace in bin/upgrading/update-db.pl

Commit: fc3360a077d25de06f418919e9263c2fd098040a
https://github.com/dreamwidth/dw-free/commit/fc3360a077d25de06f418919e9263c2fd098040a
Author: Mark Smith <mark@qq.is>
Date: 2017-03-11 (Sat, 11 Mar 2017)

Changed paths:
R bin/upgrading/migrate-userprop.pl
M bin/upgrading/proplists.dat
M bin/upgrading/update-db.pl
M cgi-bin/LJ/Feed.pm
R cgi-bin/LJ/Setting/FOAFURL.pm
M cgi-bin/LJ/User/Styles.pm

Log Message:
-----------
Merge pull request #2024 from kareila/remove-foafurl

Remove unused code for external_foaf_url

Commit: f7e291e1214624fce7874ca92be2ecd249029a3d
https://github.com/dreamwidth/dw-free/commit/f7e291e1214624fce7874ca92be2ecd249029a3d
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
R cgi-bin/LJ/Setting/MailEncoding.pm

Log Message:
-----------
remove unused module LJ/Setting/MailEncoding.pm

Commit: 3fd69212fdcc5a424d27909c4460638e1c562a11
https://github.com/dreamwidth/dw-free/commit/3fd69212fdcc5a424d27909c4460638e1c562a11
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M cgi-bin/DW/InviteCodeRequests.pm
M cgi-bin/LJ/Comment.pm

Log Message:
-----------
strip trailing whitespace in DW/InviteCodeRequests.pm & LJ/Comment.pm

Commit: 63b8f49b2cd4f5d6874d39ce5f2a0b0eb5a85d64
https://github.com/dreamwidth/dw-free/commit/63b8f49b2cd4f5d6874d39ce5f2a0b0eb5a85d64
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M bin/upgrading/proplists.dat
M cgi-bin/DW/InviteCodeRequests.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/User/Message.pm

Log Message:
-----------
remove mailencoding userprop

Commit: b32e76ce0a09c80629d286372f9fc7aeca1c7aec
https://github.com/dreamwidth/dw-free/commit/b32e76ce0a09c80629d286372f9fc7aeca1c7aec
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Logic/ProfilePage.pm
M htdocs/profile.bml
M htdocs/profile.bml.text
M htdocs/stc/profile.css

Log Message:
-----------
[#2023] remove status_image support from DW/Logic/ProfilePage.pm

Commit: d90724b71bf8fbb86bcc53131f78f1480a30c229
https://github.com/dreamwidth/dw-free/commit/d90724b71bf8fbb86bcc53131f78f1480a30c229
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-12 (Sun, 12 Mar 2017)

Changed paths:
M cgi-bin/LJ/Feed.pm

Log Message:
-----------
[#1972] Don't require unfold_embed get_arg to expand embeds

Fixes #1972.

Commit: 76a2f297700ab5e3a41c094dfa0f7e069ae89e37
https://github.com/dreamwidth/dw-free/commit/76a2f297700ab5e3a41c094dfa0f7e069ae89e37
Author: Mark Smith <mark@qq.is>
Date: 2017-03-13 (Mon, 13 Mar 2017)

Changed paths:
M cgi-bin/LJ/Feed.pm

Log Message:
-----------
Merge pull request #2027 from kareila/1972-rss-embeds

[#1972] Don't require unfold_embed get_arg to expand embeds

Commit: aa4a44be075e25628f19e965bb8774957b53792e
https://github.com/dreamwidth/dw-free/commit/aa4a44be075e25628f19e965bb8774957b53792e
Author: Mark Smith <mark@qq.is>
Date: 2017-03-13 (Mon, 13 Mar 2017)

Changed paths:
M bin/upgrading/proplists.dat
M cgi-bin/DW/InviteCodeRequests.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
R cgi-bin/LJ/Setting/MailEncoding.pm
M cgi-bin/LJ/User/Message.pm

Log Message:
-----------
Merge pull request #2025 from kareila/remove-mailconfig

Remove unused code for mailencoding

Commit: 929b5e4901d5015eac68b0639231869b03b16623
https://github.com/dreamwidth/dw-free/commit/929b5e4901d5015eac68b0639231869b03b16623
Author: Mark Smith <mark@qq.is>
Date: 2017-03-13 (Mon, 13 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M cgi-bin/DW/Logic/ProfilePage.pm
M htdocs/profile.bml
M htdocs/profile.bml.text
M htdocs/stc/profile.css

Log Message:
-----------
Merge pull request #2026 from kareila/2023-imstatus

[#2023] remove status_image support from DW/Logic/ProfilePage.pm

Commit: 17bf9d4288e746691fef3aa737e3a3409aed2778
https://github.com/dreamwidth/dw-free/commit/17bf9d4288e746691fef3aa737e3a3409aed2778
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
R cgi-bin/LJ/Setting/Language.pm
M htdocs/manage/settings/index.bml.text

Log Message:
-----------
remove unused module LJ/Setting/Language.pm

Commit: b8127fb5bf9a72843f9afc8775b79728ded0d483
https://github.com/dreamwidth/dw-free/commit/b8127fb5bf9a72843f9afc8775b79728ded0d483
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)

Changed paths:
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/PollVote.pm
M htdocs/login.bml
M htdocs/support/see_request.bml

Log Message:
-----------
strip trailing whitespace

Commit: ca179ae0562d8d2b1cb53990b9f6a62200b2dcaa
https://github.com/dreamwidth/dw-free/commit/ca179ae0562d8d2b1cb53990b9f6a62200b2dcaa
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)

Changed paths:
M cgi-bin/Apache/BML.pm
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/Session.pm
M htdocs/login.bml

Log Message:
-----------
remove langpref cookie support

There was no effective way to ever set the cookie, and even
if there were, the code was never implemented to honor the
value of the cookie on non-BML pages.

Can still override the site's default language on a per-request
basis by using the "uselang" GET parameter.

Commit: 03322114a6dfd8a79da1a2d637b204f353ca98e7
https://github.com/dreamwidth/dw-free/commit/03322114a6dfd8a79da1a2d637b204f353ca98e7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/Shop.pm
M cgi-bin/DW/EmailPost/Comment.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Event/AddedToCircle.pm
M cgi-bin/LJ/Event/Birthday.pm
M cgi-bin/LJ/Event/CommunityInvite.pm
M cgi-bin/LJ/Event/CommunityJoinApprove.pm
M cgi-bin/LJ/Event/CommunityJoinReject.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/CommunityModeratedEntryNew.pm
M cgi-bin/LJ/Event/InvitedFriendJoins.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewComment/Edited.pm
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/OfficialPost.pm
M cgi-bin/LJ/Event/PollVote.pm
M cgi-bin/LJ/Event/RemovedFromCircle.pm
M cgi-bin/LJ/Event/SecurityAttributeChanged.pm
M cgi-bin/LJ/Event/UserMessageRecvd.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
remove uses of 'browselang' in get_text calls

This prepares to get rid of the 'browselang' userprop in the next
commit; since there was no available way for the user to set it,
it was always undefined. Most of these changes simply make the
explicit choice to use $LJ::DEFAULT_LANG, which is effectively
what was happening already.

There's a subtle difference here between using LJ::Lang::ml
and using LJ::Lang::get_text with an undefined lang argument.
LJ::Lang::ml will use LJ::Lang::get_effective_lang, which picks
up any language selection from the web request. That's desired
when we're showing text to the remote user, but we don't always
want the same choice for the target of a particular action
being taken. Whereas LJ::Lang::get_text will always fall back
to the site default of $LJ::DEFAULT_LANG if the given lang is
undefined.

To make that clearer for future development, I've added a new
helper function, LJ::Lang::get_default_text, which works just
like calling LJ::Lang::get_text without the explicit undef
arguments. There's also a corresponding get_default_text_multi
for the modules that preload multiple static strings.

This may seem like overkill given our eventual aim to rip
out the translation system, but as long as we support URLs
using the "?uselang=" format, we need to make sure this
behavior is maintained.

Commit: 3b9f56d1362db54eb81a90eae1eb41bba244154d
https://github.com/dreamwidth/dw-free/commit/3b9f56d1362db54eb81a90eae1eb41bba244154d
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-14 (Tue, 14 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/proplists.dat
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Support.pm
M cgi-bin/LJ/User/Login.pm
M htdocs/login.bml
M htdocs/support/see_request.bml
M htdocs/support/see_request.bml.text

Log Message:
-----------
remove browselang userprop

Was only set in LJ::Lang::set_lang, which was only called by
LJ/Setting/Language.pm, which was unused and removed.

LJ::Lang::set_lang is retained as a stub for future replacement
of BML::set_language as we move away from using BML.

Commit: 477632185097d02d9f57b5bf285b862999eff95b
https://github.com/dreamwidth/dw-free/commit/477632185097d02d9f57b5bf285b862999eff95b
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2017-03-15 (Wed, 15 Mar 2017)

Changed paths:
M htdocs/openid/server.bml

Log Message:
-----------
Rewrite LJ's trust_root to https to match their return_to

Commit: c90eedbb267af0ef4681d586c3539fbfcd772870
https://github.com/dreamwidth/dw-free/commit/c90eedbb267af0ef4681d586c3539fbfcd772870
Author: Jen <kareila@dreamwidth.org>
Date: 2017-03-15 (Wed, 15 Mar 2017)

Changed paths:
M htdocs/openid/server.bml

Log Message:
-----------
Merge pull request #2029 from alierak/2013_lj_openid

Rewrite LJ's trust_root to https to match their return_to

Commit: d90f7d3d0fea863218821e9809a5ce3c6f1163a3
https://github.com/dreamwidth/dw-free/commit/d90f7d3d0fea863218821e9809a5ce3c6f1163a3
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-20 (Mon, 20 Mar 2017)

Changed paths:
M cgi-bin/DW/CleanEmail.pm
M t/cleanemail.t

Log Message:
-----------
[#2039] check for extra space in bogus_email address text

Fixes #2039.

Commit: 5283f6f69fd5418c75c5b109bbcf46f547a47896
https://github.com/dreamwidth/dw-free/commit/5283f6f69fd5418c75c5b109bbcf46f547a47896
Author: Mark Smith <mark@qq.is>
Date: 2017-03-20 (Mon, 20 Mar 2017)

Changed paths:
M cgi-bin/DW/CleanEmail.pm
M t/cleanemail.t

Log Message:
-----------
Merge pull request #2040 from kareila/2039-cleanemail

[#2039] check for extra space in bogus_email address text

Commit: 2122dc8f89aa547bf3962232ddefc34eaef699f1
https://github.com/dreamwidth/dw-free/commit/2122dc8f89aa547bf3962232ddefc34eaef699f1
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-21 (Tue, 21 Mar 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M etc/config-local.pl
M t/https-url.t

Log Message:
-----------
[#2034] use %LJ::KNOWN_HTTPS_SITES for simple whitelist

Replaces regular expression in config with a list of domains
that support HTTPS connections, and tests the domain of the
given URL against that whitelist.

Also updates https-url.t with a working dummy proxy config.

Fixes #2034.

Commit: 5fba7e8d809fd73d98c390b536ea4d84935313cb
https://github.com/dreamwidth/dw-free/commit/5fba7e8d809fd73d98c390b536ea4d84935313cb
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-21 (Tue, 21 Mar 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm

Log Message:
-----------
anchor the regular expression

I would prefer to keep this as a one-line expression instead of
using split and join to reconstruct the domain name, since we
can't be sure we've been given a well-formed URL to work with.

Commit: 49244aaf3398155ed8d4c7f47152b4e2ae7bf779
https://github.com/dreamwidth/dw-free/commit/49244aaf3398155ed8d4c7f47152b4e2ae7bf779
Author: Mark Smith <mark@qq.is>
Date: 2017-03-29 (Wed, 29 Mar 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M etc/config-local.pl
M t/https-url.t

Log Message:
-----------
Merge pull request #2042 from kareila/2034-sslsites

[#2034] use %LJ::KNOWN_HTTPS_SITES for simple whitelist

Commit: d5d49cb66fb410b732924bfeda112b8d0d501296
https://github.com/dreamwidth/dw-free/commit/d5d49cb66fb410b732924bfeda112b8d0d501296
Author: Mark Smith <mark@qq.is>
Date: 2017-03-29 (Wed, 29 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M bin/upgrading/proplists.dat
M cgi-bin/Apache/BML.pm
M cgi-bin/DW/Controller/Shop.pm
M cgi-bin/DW/EmailPost/Comment.pm
M cgi-bin/DW/Template/Filters.pm
M cgi-bin/DW/Worker/DistributeInvites.pm
M cgi-bin/LJ/Comment.pm
M cgi-bin/LJ/Event/AddedToCircle.pm
M cgi-bin/LJ/Event/Birthday.pm
M cgi-bin/LJ/Event/CommunityInvite.pm
M cgi-bin/LJ/Event/CommunityJoinApprove.pm
M cgi-bin/LJ/Event/CommunityJoinReject.pm
M cgi-bin/LJ/Event/CommunityJoinRequest.pm
M cgi-bin/LJ/Event/CommunityModeratedEntryNew.pm
M cgi-bin/LJ/Event/InvitedFriendJoins.pm
M cgi-bin/LJ/Event/JournalNewComment.pm
M cgi-bin/LJ/Event/JournalNewComment/Edited.pm
M cgi-bin/LJ/Event/JournalNewEntry.pm
M cgi-bin/LJ/Event/OfficialPost.pm
M cgi-bin/LJ/Event/PollVote.pm
M cgi-bin/LJ/Event/RemovedFromCircle.pm
M cgi-bin/LJ/Event/SecurityAttributeChanged.pm
M cgi-bin/LJ/Event/UserMessageRecvd.pm
M cgi-bin/LJ/Lang.pm
M cgi-bin/LJ/NotificationMethod/Email.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/Session.pm
R cgi-bin/LJ/Setting/Language.pm
M cgi-bin/LJ/Support.pm
M cgi-bin/LJ/User/Login.pm
M htdocs/login.bml
M htdocs/manage/settings/index.bml.text
M htdocs/support/see_request.bml
M htdocs/support/see_request.bml.text

Log Message:
-----------
Merge pull request #2031 from kareila/remove_setlang

Remove unused code for browselang

Commit: 53ec756341e26e9142a338ca99824505cd9a4524
https://github.com/dreamwidth/dw-free/commit/53ec756341e26e9142a338ca99824505cd9a4524
Author: Mark Smith <mark@qq.is>
Date: 2017-03-29 (Wed, 29 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
A cgi-bin/DW/Controller/Manage/Index.pm
M cgi-bin/redirect.dat
R htdocs/manage/index.bml
R htdocs/manage/index.bml.text
A views/manage/index.tt
A views/manage/index.tt.text

Log Message:
-----------
Merge pull request #2019 from kareila/manage-convert

convert manage/index.bml to TT

Commit: 41c7c3cdc1c06a36a8074c22b22a706dab7269ea
https://github.com/dreamwidth/dw-free/commit/41c7c3cdc1c06a36a8074c22b22a706dab7269ea
Author: Denise Paolucci <denise@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M bin/upgrading/en.dat
M bin/upgrading/proplists.dat
A cgi-bin/DW/Setting/RPAccount.pm
M cgi-bin/LJ/User/Account.pm
M htdocs/manage/settings/index.bml
M htdocs/profile.bml
M htdocs/profile.bml.text

Log Message:
-----------
Add new RP account flag (#2049)

* Fixes #2048.

Adds a new "rp account" setting; toggling it prints a blurb on the profile
saying that the account is a RP account, and in the future may control
access to features that only make sense for RP accounts.

* Move the div into the right place

Commit: c1817ec8ef09cb8deef6914c7ec70e4da180cc71
https://github.com/dreamwidth/dw-free/commit/c1817ec8ef09cb8deef6914c7ec70e4da180cc71
Author: Athena Yao <athena@fastmail.fm>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/User/Administration.pm
M htdocs/manage/banusers.bml
M htdocs/manage/circle/edit.bml
M htdocs/manage/circle/edit.bml.text

Log Message:
-----------
Get banned userids and don't show in manage circle if banned

Fixes #2009.

Commit: ac0abbf8d81203bca3b133e14bc79edd6e0f33bd
https://github.com/dreamwidth/dw-free/commit/ac0abbf8d81203bca3b133e14bc79edd6e0f33bd
Author: Mark Smith <mark@qq.is>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/User/Administration.pm
M htdocs/manage/banusers.bml
M htdocs/manage/circle/edit.bml
M htdocs/manage/circle/edit.bml.text

Log Message:
-----------
Merge pull request #2050 from dreamwidth/manage-circle-banned

Hide banned users on manage circle page

Commit: 68e2fad088bca9dbc4bb7b34f1b6195f62f28905
https://github.com/dreamwidth/dw-free/commit/68e2fad088bca9dbc4bb7b34f1b6195f62f28905
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/DW/Controller/Search/Interests.pm

Log Message:
-----------
Fix undefined value warning in DW/Controller/Search/Interests.pm

Use of uninitialized value in numeric ne (!=) at /home/dw/production/cgi-bin/DW/Controller/Search/Interests.pm line 410.

Commit: f34c80e2a42cb0f7aa7dc2286870aa63c760dc77
https://github.com/dreamwidth/dw-free/commit/f34c80e2a42cb0f7aa7dc2286870aa63c760dc77
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/Feed.pm

Log Message:
-----------
remove vestiges of phonepost support from LJ/Feed.pm

Commit: f8e054f048b266fbaa3a4af27ec59a267c8a7ed0
https://github.com/dreamwidth/dw-free/commit/f8e054f048b266fbaa3a4af27ec59a267c8a7ed0
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/Global/Defaults.pm

Log Message:
-----------
remove nonexistent endpoints from %LJ::AJAX_URI_MAP

Commit: f22c9722ea097d9a48ad827a6af267f22bc81391
https://github.com/dreamwidth/dw-free/commit/f22c9722ea097d9a48ad827a6af267f22bc81391
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
R cgi-bin/LJ/Widget/FriendInterests.pm
R htdocs/js/widgets/friendinterests.js

Log Message:
-----------
remove unused module LJ/Widget/FriendInterests.pm

Commit: a39da19886e1c1425651182e1c149de0f06521de
https://github.com/dreamwidth/dw-free/commit/a39da19886e1c1425651182e1c149de0f06521de
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/RPC/Misc.pm
R htdocs/tools/endpoints/extacct_auth.bml.text

Log Message:
-----------
remove htdocs/tools/endpoints/extacct_auth.bml.text

Commit: 81e553832039380f87686aa942927b13ffcec447
https://github.com/dreamwidth/dw-free/commit/81e553832039380f87686aa942927b13ffcec447
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/DW/Hooks/PrivList.pm

Log Message:
-----------
remove siteadmin:entry_redirect from privilege list

The relevant page was removed in 06e8abf.

Commit: e643f2602bd8025e6b80e06249c825b7d6cc65b3
https://github.com/dreamwidth/dw-free/commit/e643f2602bd8025e6b80e06249c825b7d6cc65b3
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M views/interests/int.tt

Log Message:
-----------
try to fix weird href parse error in logs

Seeing several errors similar to this:

`Argument "10330'"" isn't numeric in addition (+) at /home/dw/production/cgi-bin/DW/Controller/Search/Interests.pm line 298.`

The process of adding zero to the number with the extra trailing
punctuation results in the desired number, so it's not a bug per se,
but the error indicates that the page source isn't being parsed correctly
in some circumstances. I couldn't reproduce the problem in Firefox,
Chrome, or Safari.

I decided to update the template to use cleaner syntax for generating
the URL, hoping that this would prevent the parse error in the
future. If it continues to cause problems, the next step would be
to rewrite the ML string to avoid the need for string variable
interpolation in the caller. If nothing else, removing the escaped
ampersand from the URL arguments is an improvement.

Commit: c28e0506976b68a6b92df99e6ee03d4e46a72bf5
https://github.com/dreamwidth/dw-free/commit/c28e0506976b68a6b92df99e6ee03d4e46a72bf5
Author: Denise Paolucci <denise@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/S2.pm
M etc/config.pl

Log Message:
-----------
Fixes #2047.

Removes %S2_TRUSTED from config.pl and change the check in S2.pm to only
look for whether the owner is the system account, eliminating the check
to S2_TRUSTED.

Commit: 7ff574b8f0d5da8c65ef23f94086f18bdb71c32c
https://github.com/dreamwidth/dw-free/commit/7ff574b8f0d5da8c65ef23f94086f18bdb71c32c
Author: Denise Paolucci <denise@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M htdocs/js/contextualhover.js
M htdocs/js/jquery.contextualhover.js

Log Message:
-----------
Fixes #2010.

Removes the "ban community" message from the hover menu for communities.

Commit: c75fb55cb0d36e8a32d8e1ceefcdc1b4fb5912b6
https://github.com/dreamwidth/dw-free/commit/c75fb55cb0d36e8a32d8e1ceefcdc1b4fb5912b6
Author: Denise Paolucci <denise@dreamwidth.org>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M styles/core2.s2

Log Message:
-----------
Fixes #2058.

Adds a handful of new CSS classes requested via suggestions: .overview-commentcount around the comment count on month pages, .detail-tagcount in a span wrapper around the tag usage count (on the tag page and in the tag module), .admin-post around mod-flagged entries in comms (it was already there on sticky entries that were mod-flagged, so its lack here was a bug!)

Commit: 58c2667d120ba24712f395d56f8ed2ba76499008
https://github.com/dreamwidth/dw-free/commit/58c2667d120ba24712f395d56f8ed2ba76499008
Author: Mark Smith <mark@qq.is>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M styles/core2.s2

Log Message:
-----------
Merge pull request #2059 from rahaeli/morecss

add more CSS class wrappers that were requested in suggestions

Commit: 4c933124d1021af058b091cbb04f702cba12aaf9
https://github.com/dreamwidth/dw-free/commit/4c933124d1021af058b091cbb04f702cba12aaf9
Author: Mark Smith <mark@qq.is>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M htdocs/js/contextualhover.js
M htdocs/js/jquery.contextualhover.js

Log Message:
-----------
Merge pull request #2054 from rahaeli/issue2010

remove "ban community" from hover menu for comms

Commit: 975f9b425ab56fa072a145bf4d0c1dd0eb470836
https://github.com/dreamwidth/dw-free/commit/975f9b425ab56fa072a145bf4d0c1dd0eb470836
Author: Mark Smith <mark@qq.is>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M cgi-bin/LJ/S2.pm
M etc/config.pl

Log Message:
-----------
Merge pull request #2053 from rahaeli/issue2047

Get rid of %S2_TRUSTED and associated checks

Commit: f3b52d37d01f155216f1587c7ce06a7bc2585066
https://github.com/dreamwidth/dw-free/commit/f3b52d37d01f155216f1587c7ce06a7bc2585066
Author: Mark Smith <mark@qq.is>
Date: 2017-03-30 (Thu, 30 Mar 2017)

Changed paths:
M bin/upgrading/deadphrases.dat
M bin/upgrading/en.dat
M cgi-bin/DW/Controller/RPC/Misc.pm
M cgi-bin/DW/Controller/Search/Interests.pm
M cgi-bin/DW/Hooks/PrivList.pm
M cgi-bin/LJ/Feed.pm
M cgi-bin/LJ/Global/Defaults.pm
R cgi-bin/LJ/Widget/FriendInterests.pm
R htdocs/js/widgets/friendinterests.js
R htdocs/tools/endpoints/extacct_auth.bml.text
M views/interests/int.tt

Log Message:
-----------
Merge pull request #2051 from kareila/cleanup-2017q1

Cleanup 2017q1 **bonus round**

Compare: https://github.com/dreamwidth/dw-free/compare/2dea49af161f...f3b52d37d01f