[dreamwidth/dw-free] 55de8f: [#972] updated rename-related code to use DW::Form...
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 55de8f41e2a499ea7d2b176dfc5da5ac6d3b9b79
https://github.com/dreamwidth/dw-free/commit/55de8f41e2a499ea7d2b176dfc5da5ac6d3b9b79
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M cgi-bin/DW/User/Rename.pm
M htdocs/stc/rename.css
M views/admin/rename_edit.tt
M views/admin/rename_new.tt
M views/rename.tt
M views/rename/swap.tt
Log Message:
-----------
[#972] updated rename-related code to use DW::FormErrors
This is mostly a line-by-line search-and-replace, but return values
were changed in a few places where it made sense to do so.
Commit: 68de4a1812c884d9df722677ac352290abd8d13a
https://github.com/dreamwidth/dw-free/commit/68de4a1812c884d9df722677ac352290abd8d13a
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M htdocs/stc/rename.css
M views/rename.tt
Log Message:
-----------
[#972] update rename.css: remove unneeded code, add needed styling
Removed two style lines that appeared to duplicate the default
Foundation styling, and moved another line that only affected
one page into the style header tag for that page.
Also added styling for p.note, used in rename.tt and admin/rename_edit.tt,
which displays text slightly smaller and in an italic font.
Commit: 302f9a9f958c59978c8cbbc97687fe02101c968c
https://github.com/dreamwidth/dw-free/commit/302f9a9f958c59978c8cbbc97687fe02101c968c
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
A htdocs/scss/pages/rename.scss
R htdocs/stc/rename.css
M views/admin/rename_edit.tt
M views/admin/rename_new.tt
M views/rename.tt
M views/rename/swap.tt
Log Message:
-----------
[#972] convert rename-related pages to Foundation
This covers the 4 pages that were affected by the error-handling
changes, 3 of which used rename.css for styling. The remaining
style rules covered font sizing and padding, and were retained
in pages/rename.scss.
Fixes #972.
Commit: 9c8b793a8e84c4ef503325ed65fcf7cb1cce2c45
https://github.com/dreamwidth/dw-free/commit/9c8b793a8e84c4ef503325ed65fcf7cb1cce2c45
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M views/admin/rename.tt
Log Message:
-----------
[#972] convert admin/rename.tt to Foundation
This adds Foundation styling to admin/rename.tt, which used
neither error-handling nor custom styling, but was the only
other rename-related page template.
Includes additional in-page styling for the input field, so that it
doesn't take up the entire width of the page, and adds paragraph
tags around the link to /rename/new.
Commit: 7a3860b1bb83e8db0a2f6b74c59e4a29da29a5df
https://github.com/dreamwidth/dw-free/commit/7a3860b1bb83e8db0a2f6b74c59e4a29da29a5df
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M views/rename.tt
Log Message:
-----------
[#1504] close label tags to avoid text focus issues in Safari
Two label tags were unclosed, leading to JS focus problems in Safari.
Closing the labels caused them to add line breaks. Added in-page
"display: inline" styling to keep the line unbroken.
Fixes #1504.
Commit: 06a5d08d4783e383d60ff3f415f2da56716db9ba
https://github.com/dreamwidth/dw-free/commit/06a5d08d4783e383d60ff3f415f2da56716db9ba
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M views/admin/rename_new.tt
Log Message:
-----------
redisplay submitted data when presenting an error on rename_new.tt
If there is an error submitting the form, make sure the submitted
usernames are retained when redisplaying the form, as is commonly
expected practice.
Commit: 1169e31de0af921e9f0760d33093df65779ac325
https://github.com/dreamwidth/dw-free/commit/1169e31de0af921e9f0760d33093df65779ac325
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M cgi-bin/DW/RenameToken.pm
Log Message:
-----------
Fix logged warnings from testing
1. Avoid undefined user object warning in DW/Controller/Rename.pm by
not executing a user method on an undefined user.
2. Remove uninitialized value warning in DW::RenameToken by not
using the 'uc' operator on an undefined string.
Commit: e48c520212ba09f9f6738976363042159e0fdcdd
https://github.com/dreamwidth/dw-free/commit/e48c520212ba09f9f6738976363042159e0fdcdd
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/RenameToken.pm
M htdocs/scss/pages/rename.scss
Log Message:
-----------
[#1505] style tweaks from code review
Commit: a4845ef6f91ac371731832c5b8fa5ce2d0d76b6b
https://github.com/dreamwidth/dw-free/commit/a4845ef6f91ac371731832c5b8fa5ce2d0d76b6b
Author: Jen <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M cgi-bin/DW/RenameToken.pm
M cgi-bin/DW/User/Rename.pm
A htdocs/scss/pages/rename.scss
R htdocs/stc/rename.css
M views/admin/rename.tt
M views/admin/rename_edit.tt
M views/admin/rename_new.tt
M views/rename.tt
M views/rename/swap.tt
Log Message:
-----------
Merge pull request #1505 from kareila/972-rename-foundation
Convert rename-related pages to Foundation
Compare: https://github.com/dreamwidth/dw-free/compare/2d528dd1462a...a4845ef6f91a
Home: https://github.com/dreamwidth/dw-free
Commit: 55de8f41e2a499ea7d2b176dfc5da5ac6d3b9b79
https://github.com/dreamwidth/dw-free/commit/55de8f41e2a499ea7d2b176dfc5da5ac6d3b9b79
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M cgi-bin/DW/User/Rename.pm
M htdocs/stc/rename.css
M views/admin/rename_edit.tt
M views/admin/rename_new.tt
M views/rename.tt
M views/rename/swap.tt
Log Message:
-----------
[#972] updated rename-related code to use DW::FormErrors
This is mostly a line-by-line search-and-replace, but return values
were changed in a few places where it made sense to do so.
Commit: 68de4a1812c884d9df722677ac352290abd8d13a
https://github.com/dreamwidth/dw-free/commit/68de4a1812c884d9df722677ac352290abd8d13a
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M htdocs/stc/rename.css
M views/rename.tt
Log Message:
-----------
[#972] update rename.css: remove unneeded code, add needed styling
Removed two style lines that appeared to duplicate the default
Foundation styling, and moved another line that only affected
one page into the style header tag for that page.
Also added styling for p.note, used in rename.tt and admin/rename_edit.tt,
which displays text slightly smaller and in an italic font.
Commit: 302f9a9f958c59978c8cbbc97687fe02101c968c
https://github.com/dreamwidth/dw-free/commit/302f9a9f958c59978c8cbbc97687fe02101c968c
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
A htdocs/scss/pages/rename.scss
R htdocs/stc/rename.css
M views/admin/rename_edit.tt
M views/admin/rename_new.tt
M views/rename.tt
M views/rename/swap.tt
Log Message:
-----------
[#972] convert rename-related pages to Foundation
This covers the 4 pages that were affected by the error-handling
changes, 3 of which used rename.css for styling. The remaining
style rules covered font sizing and padding, and were retained
in pages/rename.scss.
Fixes #972.
Commit: 9c8b793a8e84c4ef503325ed65fcf7cb1cce2c45
https://github.com/dreamwidth/dw-free/commit/9c8b793a8e84c4ef503325ed65fcf7cb1cce2c45
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M views/admin/rename.tt
Log Message:
-----------
[#972] convert admin/rename.tt to Foundation
This adds Foundation styling to admin/rename.tt, which used
neither error-handling nor custom styling, but was the only
other rename-related page template.
Includes additional in-page styling for the input field, so that it
doesn't take up the entire width of the page, and adds paragraph
tags around the link to /rename/new.
Commit: 7a3860b1bb83e8db0a2f6b74c59e4a29da29a5df
https://github.com/dreamwidth/dw-free/commit/7a3860b1bb83e8db0a2f6b74c59e4a29da29a5df
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M views/rename.tt
Log Message:
-----------
[#1504] close label tags to avoid text focus issues in Safari
Two label tags were unclosed, leading to JS focus problems in Safari.
Closing the labels caused them to add line breaks. Added in-page
"display: inline" styling to keep the line unbroken.
Fixes #1504.
Commit: 06a5d08d4783e383d60ff3f415f2da56716db9ba
https://github.com/dreamwidth/dw-free/commit/06a5d08d4783e383d60ff3f415f2da56716db9ba
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M views/admin/rename_new.tt
Log Message:
-----------
redisplay submitted data when presenting an error on rename_new.tt
If there is an error submitting the form, make sure the submitted
usernames are retained when redisplaying the form, as is commonly
expected practice.
Commit: 1169e31de0af921e9f0760d33093df65779ac325
https://github.com/dreamwidth/dw-free/commit/1169e31de0af921e9f0760d33093df65779ac325
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M cgi-bin/DW/RenameToken.pm
Log Message:
-----------
Fix logged warnings from testing
1. Avoid undefined user object warning in DW/Controller/Rename.pm by
not executing a user method on an undefined user.
2. Remove uninitialized value warning in DW::RenameToken by not
using the 'uc' operator on an undefined string.
Commit: e48c520212ba09f9f6738976363042159e0fdcdd
https://github.com/dreamwidth/dw-free/commit/e48c520212ba09f9f6738976363042159e0fdcdd
Author: Kareila <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/RenameToken.pm
M htdocs/scss/pages/rename.scss
Log Message:
-----------
[#1505] style tweaks from code review
Commit: a4845ef6f91ac371731832c5b8fa5ce2d0d76b6b
https://github.com/dreamwidth/dw-free/commit/a4845ef6f91ac371731832c5b8fa5ce2d0d76b6b
Author: Jen <kareila@dreamwidth.org>
Date: 2015-08-01 (Sat, 01 Aug 2015)
Changed paths:
M cgi-bin/DW/Controller/Rename.pm
M cgi-bin/DW/RenameToken.pm
M cgi-bin/DW/User/Rename.pm
A htdocs/scss/pages/rename.scss
R htdocs/stc/rename.css
M views/admin/rename.tt
M views/admin/rename_edit.tt
M views/admin/rename_new.tt
M views/rename.tt
M views/rename/swap.tt
Log Message:
-----------
Merge pull request #1505 from kareila/972-rename-foundation
Convert rename-related pages to Foundation
Compare: https://github.com/dreamwidth/dw-free/compare/2d528dd1462a...a4845ef6f91a