github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2014-11-18 03:58 pm

[dreamwidth/dw-free] 786170: [#1053] Ensure we always have an id so we can link...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 786170cae13c8a12063797721bea5325b16cb293
https://github.com/dreamwidth/dw-free/commit/786170cae13c8a12063797721bea5325b16cb293
Author: Afuna <fu@dreamwidth.org>
Date: 2014-11-18 (Tue, 18 Nov 2014)

Changed paths:
M cgi-bin/DW/Template/Plugin/FormHTML.pm
M views/admin/console/index.tt
M views/admin/propedit.tt
M views/admin/supportcat/category.tt
M views/communities/members/edit.tt
M views/communities/new.tt
M views/communities/queue/entries/edit.tt
M views/entry/form.tt
M views/entry/login.tt
M views/settings/accountstatus.tt

Log Message:
-----------
[#1053] Ensure we always have an id so we can link form element to label

* exceptions are radio_nested and checkbox_nested (don't need a label to
associate the form element with the parent); hidden, submit (label not
applicable)

* remove unneeded ids which were there only to associate the form
element with the label (doesn't include js-* ids, ids used to provide
a description via aria-describedby, etc)
Fixes #1053.


Commit: 33efea65d3d855b96e3a6fcab91c1d5ef2fca380
https://github.com/dreamwidth/dw-free/commit/33efea65d3d855b96e3a6fcab91c1d5ef2fca380
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-11-18 (Tue, 18 Nov 2014)

Changed paths:
M cgi-bin/DW/Template/Plugin/FormHTML.pm
M views/admin/console/index.tt
M views/admin/propedit.tt
M views/admin/supportcat/category.tt
M views/communities/members/edit.tt
M views/communities/new.tt
M views/communities/queue/entries/edit.tt
M views/entry/form.tt
M views/entry/login.tt
M views/settings/accountstatus.tt

Log Message:
-----------
Merge pull request #1075 from afuna/default-gen-id-bug-1053

[#1053] Ensure we always have an id so we can link form element to label


Compare: https://github.com/dreamwidth/dw-free/compare/31044848dced...33efea65d3d8