[dreamwidth/dw-free] c9c43d: (bug 5191) can make entries with slug URLs sticky

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: c9c43d227fb9761aaab7ca8ca51239b10d34c033
https://github.com/dreamwidth/dw-free/commit/c9c43d227fb9761aaab7ca8ca51239b10d34c033
Author: Frances Hocutt <frances.hocutt@gmail.com>
Date: 2014-03-25 (Tue, 25 Mar 2014)

Changed paths:
M cgi-bin/LJ/User.pm

Log Message:
-----------
(bug 5191) can make entries with slug URLs sticky

Previously, you could only use a ditemid or a URL with ditemid to set
a sticky entry; putting in a URL with a slug would lead to an error
message.

I modified sub sticky_entry in cgi-bin/LJ/User.pm so that it would accept
ditemids, URLs with ditemids, and URLs with slugs. sticky_entry still
validates the entry and uses its ditemid to set the sticky property.

Testing:
Used the free individual account test_free on my 'hack

Strings that set the corresponding entry as sticky:
* "http://test-free.quartzpebble.hack.dreamwidth.net/1202.html"
* "http://test-free.quartzpebble.hack.dreamwidth.net/2014/03/25/slugbug.html" (public entry)
* "http://test-free.quartzpebble.hack.dreamwidth.net/2014/03/24/friendly-slug.html" (access-locked entry)
* "http://test-free.quartzpebble.hack.dreamwidth.net/2014/03/25/private-slug.html" (private entry)
* "test-free.quartzpebble.hack.dreamwidth.net/2014/03/25/private-slug.html"
* "test-free.quartzpebble.hack.dreamwidth.net/2014/03/21/private-slug.html" <-- note date doesn't matter
* setting "" or " " still removes the current sticky entry

Strings that resulted in an error message ("Invalid Dreamwidth entry ID or URL entered."):
* "slugbug"
* "private-slug"
* ";ouasenouth"
* '!@$%(*#&%#"@'
* "http://test-free.quartzpebble.hack.dreamwidth.net/2014/03/25/private slug.html"
* "http://test-free.quartzpebble.hack.dreamwidth.net/2014/03/25/private-slug"


Commit: ebac26b9ff8f0979ee94855ec2decc39d72c8a93
https://github.com/dreamwidth/dw-free/commit/ebac26b9ff8f0979ee94855ec2decc39d72c8a93
Author: Frances Hocutt <frances.hocutt@gmail.com>
Date: 2014-04-03 (Thu, 03 Apr 2014)

Changed paths:
M cgi-bin/LJ/User.pm

Log Message:
-----------
using non-capturing groups for slug-finding regex


Commit: 783d77fd35e1103d17c5bb3b28c6543d9570f07a
https://github.com/dreamwidth/dw-free/commit/783d77fd35e1103d17c5bb3b28c6543d9570f07a
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-04-04 (Fri, 04 Apr 2014)

Changed paths:
M cgi-bin/LJ/User.pm

Log Message:
-----------
Merge pull request #657 from fhocutt/bug5191-slug-stickyentry

(bug 5191) can make entries with slug URLs sticky


Compare: https://github.com/dreamwidth/dw-free/compare/c786416f70fc...783d77fd35e1