[dreamwidth/dw-free] 52805a: (bug 4772) show users using standard userhead

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 52805aa3365b8b84182417787d605d860ba89dff
https://github.com/dreamwidth/dw-free/commit/52805aa3365b8b84182417787d605d860ba89dff
Author: Rick Scott <shadowspar@dreamwidth.org>
Date: 2013-05-20 (Mon, 20 May 2013)

Changed paths:
M htdocs/stats.bml

Log Message:
-----------
(bug 4772) show users using standard userhead

Also, use load_userids to pull users from the database as a group,
instead of loading them one by one with calls to LJ::load_user.

Previous branch: bug4772-stats-old-urls; previous pull req:
https://github.com/dreamwidth/dw-free/pull/337


Commit: c97f9c0486d995958f8eedacd7e397b5005ef45f
https://github.com/dreamwidth/dw-free/commit/c97f9c0486d995958f8eedacd7e397b5005ef45f
Author: Rick Scott <shadowspar@dreamwidth.org>
Date: 2013-05-20 (Mon, 20 May 2013)

Changed paths:
M htdocs/stats.bml

Log Message:
-----------
(bug 4772) Style cleanup: remove trailing parens()


Commit: 4373ccd45471ea9184e8fbf2fd65749ddcf3063e
https://github.com/dreamwidth/dw-free/commit/4373ccd45471ea9184e8fbf2fd65749ddcf3063e
Author: Rick Scott <shadowspar@dreamwidth.org>
Date: 2013-05-20 (Mon, 20 May 2013)

Changed paths:
M htdocs/stats.bml

Log Message:
-----------
(bug 4772) use more idiomatic "if ( @$accounts )"

Address Fu's comment here:
https://github.com/dreamwidth/dw-free/pull/337#discussion_r3792867

Alter this from "if (scalar @$accounts == 0)" (if there are
no accounts in the results, do this, else process them)
to the (hopefully) more readable "if ( @$accounts )"
(if there are accounts, process them, else display an error message).


Commit: c393ab65aba75483b5940d2f83da25208406ffc1
https://github.com/dreamwidth/dw-free/commit/c393ab65aba75483b5940d2f83da25208406ffc1
Author: Rick Scott <shadowspar@dreamwidth.org>
Date: 2013-05-20 (Mon, 20 May 2013)

Changed paths:
M htdocs/stats.bml

Log Message:
-----------
(bug 4772) rework code that creates

s

Each element of @$accounts is a hashref like so:
{ userid => 1234 , timeupdate => '2013-03-30 01:58:32' }

Then LJ::load_userids gives us a hash that lets us map userid numbers
to user objects. Unfortunately, we need to keep the @$accounts array
around to preserve the ordering -- they're sorted by last update time.

Hopefully subbing in the conventional $u will make what is going
on here clearer. If not, we'll have to rework this in a more
readable but less efficient way. ^_^;

Addresses afuna's comment:
https://github.com/dreamwidth/dw-free/pull/337#discussion_r3792930


Commit: 4bcc4e0ed7c0befe5895982e54e733d741251ada
https://github.com/dreamwidth/dw-free/commit/4bcc4e0ed7c0befe5895982e54e733d741251ada
Author: Afuna <afunamatata+github@gmail.com>
Date: 2013-06-05 (Wed, 05 Jun 2013)

Changed paths:
M htdocs/stats.bml

Log Message:
-----------
Merge pull request #365 from rickscott/bug4772-stats-old-urls-dw-style

Bug 4772 - stats page uses oldstyle urls (second PR)


Compare: https://github.com/dreamwidth/dw-free/compare/5bebbda3980d...4bcc4e0ed7c0