[dreamwidth/dw-free] c226b1: (Bug 4858) Fix detection of fully expanded comment...

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: c226b145876c1b6fe2f740c9bf39fa69e561b84d
https://github.com/dreamwidth/dw-free/commit/c226b145876c1b6fe2f740c9bf39fa69e561b84d
Author: Afuna <fu@dreamwidth.org>
Date: 2013-01-29 (Tue, 29 Jan 2013)

Changed paths:
M htdocs/js/jquery.threadexpander.js

Log Message:
-----------
(Bug 4858) Fix detection of fully expanded comments

We changed the HTML structure, but not the way the JS was looking for
whether the element was expanded when it was copied over to the page.
This broke our ability to check that said comment had already been
copied over (and thus did not need to be recopied). Fixing should make
that more efficient.

This also broke the quick reply(!) in the case where you expand a
comment deep in the thread, hit reply to that, change your mind and
decide to read more of the thread (expanding the comment). The
unnecessary replacement removes #qrdiv and breaks it for the entire
page. This'll fix it.


Commit: 3b6a78ca6109c357106ed2cf73e88292ded53881
https://github.com/dreamwidth/dw-free/commit/3b6a78ca6109c357106ed2cf73e88292ded53881
Author: Afuna <afunamatata+github@gmail.com>
Date: 2013-01-31 (Thu, 31 Jan 2013)

Changed paths:
M htdocs/js/jquery.threadexpander.js

Log Message:
-----------
Merge pull request #240 from afuna/expander-replaces-too-much-bug4858

(Bug 4858) Fix detection of fully expanded comments


Compare: https://github.com/dreamwidth/dw-free/compare/7a4a0fdc9e6d...3b6a78ca6109