github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
github ([personal profile] github) wrote in [site community profile] changelog2012-12-06 05:00 am

[dreamwidth/dw-free] 4b1476: (Bug 4265) Use LJ::CMAX_SUBJECT instead of a magic...

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 4b1476d39ed086e8d099277619fef6386001dd48
https://github.com/dreamwidth/dw-free/commit/4b1476d39ed086e8d099277619fef6386001dd48
Author: Afuna <fu@dreamwidth.org>
Date: 2012-12-05 (Wed, 05 Dec 2012)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M views/entry/form.tt

Log Message:
-----------
(Bug 4265) Use LJ::CMAX_SUBJECT instead of a magic number

Number for frontend maxlength was previously hardcoded -- and wrong!


Commit: 2582ebfe2932109f55889c4566c032e8ab4652fe
https://github.com/dreamwidth/dw-free/commit/2582ebfe2932109f55889c4566c032e8ab4652fe
Author: Afuna <fu@dreamwidth.org>
Date: 2012-12-05 (Wed, 05 Dec 2012)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
(Bug 4265) Fail when the subject is too long

Instead of silently truncating, and leaving the user wondering what
happened to their carefully crafted subject line when they next view
their post (or losing that data altogether), fail if the subject line is
too long so that they have a chance to fix it.

This is particularly important for languages with multi-byte character
encodings


Commit: d432525a7159db48d72c7e6ac474779f6ee12eea
https://github.com/dreamwidth/dw-free/commit/d432525a7159db48d72c7e6ac474779f6ee12eea
Author: Afuna <afunamatata+github@gmail.com>
Date: 2012-12-06 (Thu, 06 Dec 2012)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm
M cgi-bin/LJ/Protocol.pm
M views/entry/form.tt

Log Message:
-----------
Merge pull request #174 from afuna/update-page-subject-maxlength-bug4265

Give error messages when subject lines are too long


Compare: https://github.com/dreamwidth/dw-free/compare/ca95738b1435...d432525a7159