[dreamwidth/dw-free] 756019: (Bug 4329) Expose the screened count to S2

[github]

Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 75601944b8008978f520aac05d721de4bc89ce0e
https://github.com/dreamwidth/dw-free/commit/75601944b8008978f520aac05d721de4bc89ce0e
Author: Afuna <fu@dreamwidth.org>
Date: 2012-09-06 (Thu, 06 Sep 2012)

Changed paths:
M bin/upgrading/s2layers/core2.s2
M cgi-bin/LJ/Entry.pm

Log Message:
-----------
(Bug 4329) Expose the screened count to S2

The screened count is now available via instances of the CommentInfo
class (same place you can get your reply count and the screened status),
but only if the screened status of comments on the entry was previously
visible to you.


Commit: 56febb98b3b9d46536887e0c033a0c54ff0eb2ba
https://github.com/dreamwidth/dw-free/commit/56febb98b3b9d46536887e0c033a0c54ff0eb2ba
Author: Momiji <momijizukamori+bugzilla@gmail.com>
Date: 2012-09-06 (Thu, 06 Sep 2012)

Changed paths:
M bin/upgrading/s2layers/core2.s2

Log Message:
-----------
New section in print_readlink to handle displaying screened comment if viewer is allowed to see screened comments


Commit: bbf06c08d00a521cf6add6001d5a30552c108334
https://github.com/dreamwidth/dw-free/commit/bbf06c08d00a521cf6add6001d5a30552c108334
Author: Afuna <afunamatata+github@gmail.com>
Date: 2012-09-10 (Mon, 10 Sep 2012)

Changed paths:
M bin/upgrading/s2layers/core2.s2
M cgi-bin/LJ/Entry.pm

Log Message:
-----------
Merge pull request #57 from momijizukamori/Bug4329/S2ScreenedComments

(Bug 4329) s2 screened comments


Compare: https://github.com/dreamwidth/dw-free/compare/db5c11127744...bbf06c08d00a

Comments

[ninetydegrees]

I'm adding this to Database and I have a question: is it understandable for everybody that '2 visible | 2 screened comments' is meant as '(2 visible | 2 screened) comments?

[fu]

I think that works in context, yes.

[ninetydegrees]

Ok! How about this then: can I edit the function in Core2 so that it uses get_plural_phrase then expose the two props in the Wizard since we already have read_comments there? That way people can easily customize them to say what they want. That'd make the default value "1 visible // # visible'. Would that be confusing?

[fu]

Hmm, yes do that please!