fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2012-07-12 10:06 am

[dw-free] The tooltip for the gender field containts a spurious <br />

[commit: http://hg.dwscoalition.org/dw-free/rev/dcb6709dce5a]

http://bugs.dwscoalition.org/show_bug.cgi?id=4449

Minor change to profile tooltip, use LJ::strip_html to remove spurious HTML
in title text.

Patch by [personal profile] kaberett.

Files modified:
  • htdocs/manage/profile/index.bml
  • htdocs/manage/profile/index.bml.text
--------------------------------------------------------------------------------
diff -r a1e932a98437 -r dcb6709dce5a htdocs/manage/profile/index.bml
--- a/htdocs/manage/profile/index.bml	Thu Jul 12 18:00:03 2012 +0800
+++ b/htdocs/manage/profile/index.bml	Thu Jul 12 18:10:19 2012 +0800
@@ -175,9 +175,10 @@
 
         if ( $u->is_individual ) {
             # gender
-            $ret .= "<tr class='field_block" . $zebra_row->() . "'><td class='field_name'>$ML{'.fn.gender'}</td>\n";
+            $ret .= "<tr class='field_block" . $zebra_row->() . "'><td class='field_name'>$ML{'.fn.gender1'}</td>\n";
             $ret .= "<td>";
-            $ret .= LJ::html_select( { name => 'gender', title => $ML{'.fn.gender'},
+            # strip HTML out of title
+            $ret .= LJ::html_select( { name => 'gender', title => LJ::strip_html( $ML{'.fn.gender1'} ),
                                        selected => $u->prop( 'gender' ) || 'U' },
                                      F => $ML{'.gender.female'},
                                      M => $ML{'.gender.male'},
diff -r a1e932a98437 -r dcb6709dce5a htdocs/manage/profile/index.bml.text
--- a/htdocs/manage/profile/index.bml.text	Thu Jul 12 18:00:03 2012 +0800
+++ b/htdocs/manage/profile/index.bml.text	Thu Jul 12 18:10:19 2012 +0800
@@ -97,7 +97,7 @@
 
 .fn.friendof3=Circled By
 
-.fn.gender=For statistical purposes, please provide your gender.<br /> (It will not be publicly displayed.)
+.fn.gender1=Gender<br /> (for statistics)
 
 .fn.interests=List all your interests, separated by commas, to allow other users to find you using the Interest Search.
 
--------------------------------------------------------------------------------