changelog | [dw-free] Latest Page tag cloud not updating

[commit: http://hg.dwscoalition.org/dw-free/rev/9b8ff189d7aa]

http://bugs.dwscoalition.org/show_bug.cgi?id=3520

Fix a problem with the latest things feed not expiring tags that haven't
been used in a while. Now we get them a 24 hour window -- if a tag shows up
in the list, if it hasn't been used in 24 hours, we drop it.

Patch by

mark.

Files modified:

cgi-bin/DW/LatestFeed.pm

--------------------------------------------------------------------------------
diff -r 8434b75cccba -r 9b8ff189d7aa cgi-bin/DW/LatestFeed.pm
--- a/cgi-bin/DW/LatestFeed.pm	Thu Jun 14 04:24:39 2012 +0000
+++ b/cgi-bin/DW/LatestFeed.pm	Thu Jun 14 05:05:41 2012 +0000
@@ -275,7 +275,7 @@
     }
 
     # step 6.5) we're going to need the latest things global tag frequency map (...hah)
-    #   [ [ tagname, kwid, ct ], [ tagname, kwid, ct ], ... ]
+    #   [ [ tagname, kwid, ct, time ], [ tagname, kwid, ct, time ], ... ]
     my $tfmap = LJ::MemCache::get( 'latest_items_tag_frequency_map' ) || [];
 
     #   ( kwid => tagname, kwid => tagname, ... )
@@ -320,8 +320,10 @@
                 foreach my $row ( @$tfmap ) {
                     next unless $row->[1] == $kwid;
 
-                    # found the row, so increment the count and bail
+                    # found the row, so increment the count and bail. also, we update the last used
+                    # time so that we know when we can purge the items if they go stale.
                     $row->[2]++;
+                    $row->[3] = time();
                     last;
                 }
 
@@ -329,14 +331,14 @@
                 LJ::MemCache::add( "latest_items_tag_ct:$kwid", 0 );
                 LJ::MemCache::incr( "latest_items_tag_ct:$kwid" );
 
-                # if the tag is noo already in the list, see if we should add it
+                # if the tag is not already in the list, see if we should add it
                 if ( ! exists $tfsr{$kwid} ) {
                     my $ct = LJ::MemCache::get( "latest_items_tag_ct:$kwid" ) || 0;
                     next unless scalar @$tfmap < NUM_TOP_TAGS  # or we don't have enough tags in the list
                                 || $ct > $tfmap->[-1]->[2];    # exceeds minimum value in list already
 
                     # okay, we're going to put this one in the list, prepare a space
-                    push @$tfmap, [ $tag, $kwid, $ct ];
+                    push @$tfmap, [ $tag, $kwid, $ct, time() ];
                     @$tfmap = sort { $b->[2] <=> $a->[2] } @$tfmap;
                     @$tfmap = splice @$tfmap, 0, NUM_TOP_TAGS;
                 }
@@ -363,7 +365,9 @@
     }
 
     # re-sort and update our tag frequency map, then store it
-    @$tfmap = sort { $b->[2] <=> $a->[2] } @$tfmap;
+    my $cutoff = time() - 86400; # ignore tags staler than this
+    @$tfmap = sort { $b->[2] <=> $a->[2] }
+              grep { $_->[3] > $cutoff } @$tfmap;
     @$tfmap = splice @$tfmap, 0, NUM_TOP_TAGS;
     LJ::MemCache::set( latest_items_tag_frequency_map => $tfmap );
 
--------------------------------------------------------------------------------

[dw-free] Latest Page tag cloud not updating

no subject