fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2012-03-05 10:47 am

[dw-free] In some situations, "Irreparable invalid markup" link uses invalid markup

[commit: http://hg.dwscoalition.org/dw-free/rev/feb1c053a277]

http://bugs.dwscoalition.org/show_bug.cgi?id=4069

Add missing href=... attribute.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/LJ/CleanHTML.pm
--------------------------------------------------------------------------------
diff -r e600641b152c -r feb1c053a277 cgi-bin/LJ/CleanHTML.pm
--- a/cgi-bin/LJ/CleanHTML.pm	Mon Mar 05 18:07:20 2012 +0800
+++ b/cgi-bin/LJ/CleanHTML.pm	Mon Mar 05 18:48:26 2012 +0800
@@ -223,7 +223,7 @@
 
         if ( $cuturl ) {
             my $cutlink = LJ::ehtml( $cuturl );
-            $extra_text = "<strong>" . LJ::Lang::ml( 'cleanhtml.error.markup', { aopts => $cutlink } ) . "</strong>";
+            $extra_text = "<strong>" . LJ::Lang::ml( 'cleanhtml.error.markup', { aopts => "href='$cutlink'" } ) . "</strong>";
         }
         else {
             $extra_text = LJ::Lang::ml( 'cleanhtml.error.markup.extra', { aopts => $tag } ) . "<br /><br />" .
--------------------------------------------------------------------------------