fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-12-23 11:18 am

[dw-nonfree] quick sanitychecks for suggestions generator

[commit: http://hg.dwscoalition.org/dw-nonfree/rev/63d2710b0013]

http://bugs.dwscoalition.org/show_bug.cgi?id=4135

Cut off the suggestion process early if the suggester isn't validated, or if
they're suspended.

Patch by [staff profile] denise.

Files modified:
  • htdocs/site/suggest.bml
--------------------------------------------------------------------------------
diff -r c95af4e9c9f7 -r 63d2710b0013 htdocs/site/suggest.bml
--- a/htdocs/site/suggest.bml	Thu Dec 22 01:57:36 2011 +0800
+++ b/htdocs/site/suggest.bml	Fri Dec 23 19:17:50 2011 +0800
@@ -33,6 +33,10 @@
     # for pages that require authentication
     my $remote = LJ::get_remote();
     return "<?needlogin?>" unless $remote;
+    return "Sorry, you must have confirmed your email to make a suggestion"
+        unless $remote->is_validated;
+    return "Sorry, suspended accounts can't make suggestions"
+        if $remote->is_suspended;
 
     my ( $ret, $suggestion, $response, $response2 );
     my $emailselected = 1;
--------------------------------------------------------------------------------