fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-12-21 05:53 pm

[dw-free] 'Anonymous' color hardcoded in the source in Reply form

[commit: http://hg.dwscoalition.org/dw-free/rev/33c66557f71d]

http://bugs.dwscoalition.org/show_bug.cgi?id=4098

Remove hardcoded gray when commenting option is disabled

Patch by [personal profile] ninetydegrees.

Files modified:
  • cgi-bin/LJ/Talk.pm
  • htdocs/stc/celerity/celerity.css
  • htdocs/stc/gradation/gradation.css
  • htdocs/stc/lynx/lynx.css
--------------------------------------------------------------------------------
diff -r 0a564f29e60a -r 33c66557f71d cgi-bin/LJ/Talk.pm
--- a/cgi-bin/LJ/Talk.pm	Mon Dec 19 17:19:10 2011 +0000
+++ b/cgi-bin/LJ/Talk.pm	Thu Dec 22 01:51:34 2011 +0800
@@ -1586,7 +1586,7 @@
             $ret .= "<td align='center' width='20'>";
             $ret .= LJ::img( 'id_anonymous', '' ) . "</td>";
             $ret .= "<td align='center'>(  )</td>";
-            $ret .= "<td align='left'><font color='#c0c0c0'><b>$BML::ML{'.opt.anonymous'}</b></font> $BML::ML{'.opt.noanonpost.nonpublic'}</td>";
+            $ret .= "<td align='left'><span class='disabled'><strong>$BML::ML{'.opt.anonymous'}</strong></span> $BML::ML{'.opt.noanonpost.nonpublic'}</td>";
             $ret .= "</tr>\n";
         } else {
             $ret .= "<tr valign='center'><td align='center'>";
@@ -1654,7 +1654,7 @@
         $ret .= "<tr valign='middle'><td align='center' width='20'>";
         $ret .= LJ::img( 'id_anonymous', '' ) . "</td>";
         $ret .= "<td align='center'>(  )</td>";
-        $ret .= "<td align='left'><font color='#c0c0c0'><b>$BML::ML{'.opt.anonymous'}</b></font> $BML::ML{'.opt.noanonpost'}</td>";
+        $ret .= "<td align='left'><span class='disabled'><strong>$BML::ML{'.opt.anonymous'}</strong></span> $BML::ML{'.opt.noanonpost'}</td>";
         $ret .= "</tr>\n";
 
         if (LJ::OpenID->consumer_enabled) {
@@ -1683,7 +1683,7 @@
                 $ret .= "<tr valign='middle'><td align='center'>";
                 $ret .= LJ::img( 'id_openid', '', { onclick => 'handleRadios(3);' } ) . "</td>";
                 $ret .= "<td align='center'>(  )</td>";
-                $ret .= "<td align='left'><font color='#c0c0c0'><b>OpenID</b></font>" . " " . BML::ml('.opt.openidsignin2', { 'aopts' => "href='$LJ::SITEROOT/openid'" });
+                $ret .= "<td align='left'><span class='disabled'><strong>OpenID</strong></span>" . " " . BML::ml('.opt.openidsignin2', { 'aopts' => "href='$LJ::SITEROOT/openid'" });
                 $ret .= BML::ml('.opt.noopenidpost', { aopts1 => "href='$LJ::SITEROOT/changeemail'", aopts2 => "href='$LJ::SITEROOT/register'" })
                     if defined $oid_identity;
 
@@ -1700,7 +1700,7 @@
         $ret .= "<tr valign='middle'><td align='center' width='20'>";
         $ret .= LJ::img( 'id_anonymous', '' ) . "</td>";
         $ret .= "<td align='center'>(  )</td>";
-        $ret .= "<td align='left' colspan='2'><font color='#c0c0c0'><b>$BML::ML{'.opt.anonymous'}</b></font>";
+        $ret .= "<td align='left' colspan='2'><span class='disabled'><strong>$BML::ML{'.opt.anonymous'}</strong></span>";
         my $stringname = $journalu->is_person ? ".opt.friendsonly" : ".opt.membersonly";
         $ret .= " " . BML::ml($stringname, {'username'=>"<b>$journalu->{'user'}</b>"});
         $ret .= "</tr>\n";
@@ -1718,7 +1718,7 @@
                     $ret .= $whocheck->('openid_cookie') . "/>";
                     $ret .= "</td><td align='left'><b><label for='talkpostfromoid' onclick='handleRadios(4);return false;'>OpenID identity:</label></b> ";
                 } else {
-                    $ret .= "<td align='center'>( )</td><td align='left'><b><font color='#c0c0c0'>OpenID identity:</font></b>&nbsp;";
+                    $ret .= "<td align='center'>( )</td><td align='left'><span class='disabled'><strong>OpenID identity:</strong></span>&nbsp;";
                 }
 
                 $ret .= "<strong>$logged_in</strong>";
@@ -1789,9 +1789,9 @@
 
                 $ret .= $other_user;
             } else {
-                $ret .= "<font color='#c0c0c0'>";
-                $ret .= BML::ml( ".opt.loggedin", { username => "</font><strong>$logged_in</strong><font color='#c0c0c0'>" } );
-                $ret .= "</font>\n";
+                $ret .= "<span class='disabled'>";
+                $ret .= BML::ml( ".opt.loggedin", { username => "</span><strong>$logged_in</strong>" } );
+                $ret .= "\n";
 
                 my $msg = $journalu->is_comm ? "notamember" : "notafriend";
                 $ret .= "&nbsp;- " . BML::ml( "$SC.error.$msg",
diff -r 0a564f29e60a -r 33c66557f71d htdocs/stc/celerity/celerity.css
--- a/htdocs/stc/celerity/celerity.css	Mon Dec 19 17:19:10 2011 +0000
+++ b/htdocs/stc/celerity/celerity.css	Thu Dec 22 01:51:34 2011 +0800
@@ -567,6 +567,11 @@
  * Temporary page-specific styling
  * /
 /* talkpage */
+
+.talkform .disabled {
+    background: transparent !important;
+}
+
 .cmtbar { border-bottom: none; border-right: none; }
 td.odd  { background-color: #EEEECC; }
 td.even { background-color: #DDDBBB; }
diff -r 0a564f29e60a -r 33c66557f71d htdocs/stc/gradation/gradation.css
--- a/htdocs/stc/gradation/gradation.css	Mon Dec 19 17:19:10 2011 +0000
+++ b/htdocs/stc/gradation/gradation.css	Thu Dec 22 01:51:34 2011 +0800
@@ -644,6 +644,11 @@
  * Temporary page-specific styling
  * /
 /* talkpage */
+
+.talkform .disabled {
+    background: transparent !important;
+}
+
 .cmtbar {
     border-bottom: none;
     border-right: none;
diff -r 0a564f29e60a -r 33c66557f71d htdocs/stc/lynx/lynx.css
--- a/htdocs/stc/lynx/lynx.css	Mon Dec 19 17:19:10 2011 +0000
+++ b/htdocs/stc/lynx/lynx.css	Thu Dec 22 01:51:34 2011 +0800
@@ -122,6 +122,11 @@
 .section_head { background: #ccc; }
 
 /* talkpage */
+
+.talkform .disabled {
+    background: transparent !important;
+}
+
 td.odd { background-color: #c0c0c0; }
 td.even { background-color: #e2e2e2; }
 td.screened { background-color: #707070; }
--------------------------------------------------------------------------------