fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-11-16 01:51 pm

[dw-free] JS broken in new update page on Opera

[commit: http://hg.dwscoalition.org/dw-free/rev/eb14cfedf800]

http://bugs.dwscoalition.org/show_bug.cgi?id=4056

"for" is a keyword and causes some browsers (like Opera) to choke.

Patch by [personal profile] fu.

Files modified:
  • htdocs/js/jquery.tagselector.js
--------------------------------------------------------------------------------
diff -r 92646f1457a7 -r eb14cfedf800 htdocs/js/jquery.tagselector.js
--- a/htdocs/js/jquery.tagselector.js	Wed Nov 16 21:52:09 2011 +0800
+++ b/htdocs/js/jquery.tagselector.js	Wed Nov 16 21:52:59 2011 +0800
@@ -136,8 +136,8 @@
 
         $.each(data, function(index, value) {
             $("<li>").append(
-                $( "<input>", { type: "checkbox", id: "tagselector_tag_" + value, value: value, checked: selected[value] } ),
-                $("<label>", { for: "tagselector_tag_" + value } ).text(value) )
+                $( "<input>", { "type": "checkbox", id: "tagselector_tag_" + value, "value": value, "checked": selected[value] } ),
+                $("<label>", { "for": "tagselector_tag_" + value } ).text(value) )
             .appendTo($tagslist)
         });
 
--------------------------------------------------------------------------------