fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-11-11 08:11 am

[dw-free] Check for Test::More version unnecessary on production servers

[commit: http://hg.dwscoalition.org/dw-free/rev/7dbde4ef1b31]

http://bugs.dwscoalition.org/show_bug.cgi?id=4019

Don't die on outdated optional modules.

Patch by [personal profile] fu.

Files modified:
  • bin/checkconfig.pl
--------------------------------------------------------------------------------
diff -r 01cd1739b013 -r 7dbde4ef1b31 bin/checkconfig.pl
--- a/bin/checkconfig.pl	Fri Nov 11 16:04:02 2011 +0800
+++ b/bin/checkconfig.pl	Fri Nov 11 16:12:26 2011 +0800
@@ -288,7 +288,13 @@
                     last;
                 }
             }
-            push @errors, "Out of date module: $mod (need $ver_want, $ver_got installed)" if $invalid;
+            if ( $invalid ) {
+                if ( $modules{$mod}->{opt} ) {
+                    print STDERR "Out of date optional module: $mod (need $ver_want, $ver_got installed)\n";
+                } else {
+                    push @errors, "Out of date module: $mod (need $ver_want, $ver_got installed)";
+                }
+            }
         }
     }
     if (@debs && -e '/etc/debian_version') {
--------------------------------------------------------------------------------