fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-11-04 11:20 am

[dw-free] Revamp /update

[commit: http://hg.dwscoalition.org/dw-free/rev/9e9c728529ff]

http://bugs.dwscoalition.org/show_bug.cgi?id=2524

Don't blow away user's visibility preferences when there's a missing module
from the ordering.

Patch by [personal profile] fu.

Files modified:
  • cgi-bin/LJ/User.pm
--------------------------------------------------------------------------------
diff -r b04f39db8113 -r 9e9c728529ff cgi-bin/LJ/User.pm
--- a/cgi-bin/LJ/User.pm	Fri Nov 04 19:20:15 2011 +0800
+++ b/cgi-bin/LJ/User.pm	Fri Nov 04 19:22:03 2011 +0800
@@ -4838,9 +4838,9 @@
 
         my @col = @{$ret->{order}->[2]};
         foreach ( keys %need_panels ) {
-            # add back into last column, but don't show
+            # add back into last column, but respect user's option to show/not-show
             push @col, $_;
-            $ret->{show}->{$_} = 0;
+            $ret->{show}->{$_} = 0 unless defined $ret->{show}->{$_};
         }
         $ret->{order}->[2] = \@col;
     } else {
--------------------------------------------------------------------------------