fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-09-15 07:38 am

[dw-free] Site-styled entry pages: turn subject into clean link

[commit: http://hg.dwscoalition.org/dw-free/rev/4fb63cd71cbc]

http://bugs.dwscoalition.org/show_bug.cgi?id=3856

Turn entry subject in site-skinned comment/entry pages into a link (sans any
style=mine, etc in the URL)

Patch by [personal profile] fu.

Files modified:
  • htdocs/talkread.bml
--------------------------------------------------------------------------------
diff -r 9de09f391398 -r 4fb63cd71cbc htdocs/talkread.bml
--- a/htdocs/talkread.bml	Mon Sep 12 18:16:06 2011 +0800
+++ b/htdocs/talkread.bml	Thu Sep 15 14:58:34 2011 +0800
@@ -332,7 +332,7 @@
         my $subject = LJ::CleanHTML::quote_html( $item->{subject}, $GET{nohtml} );
         LJ::CleanHTML::clean_subject(\$subject);
         BML::ebml(\$subject);
-        $ret .= "<div id='entrysubj'>$subject</div><br />\n";
+        $ret .= qq{<div id='entrysubj'><a href="$talkurl">$subject</a></div><br />\n};
     }
 
 
--------------------------------------------------------------------------------
ninetydegrees: Art & Text: heart with aroace colors, "you are loved" (Default)

[personal profile] ninetydegrees 2011-09-15 12:17 pm (UTC)(link)
YAY! Thank you!
ninetydegrees: Art & Text: heart with aroace colors, "you are loved" (Default)

[personal profile] ninetydegrees 2011-09-17 02:33 pm (UTC)(link)
Oh I've just realized there's no link when there's no subject. Could we have (no subject) printed or something? Or is that another suggestion?
turlough: Mikey & Gerard Way & Ray Toro & Frank Iero in van, c. 2003 ((mcr) we were so young)

[personal profile] turlough 2011-09-15 04:13 pm (UTC)(link)
Wonderful!