fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-09-12 09:59 am

[dw-free] move cgi-bin/lj*.pl files into proper modules (in cgi-bin/LJ)

[commit: http://hg.dwscoalition.org/dw-free/rev/ae729438d311]

http://bugs.dwscoalition.org/show_bug.cgi?id=1726

use once, not every time we enter the loop.

Patch by [personal profile] fu.

Files modified:
  • bin/moveucluster.pl
--------------------------------------------------------------------------------
diff -r 1ff2ad57b2cc -r ae729438d311 bin/moveucluster.pl
--- a/bin/moveucluster.pl	Mon Sep 12 16:32:07 2011 +0800
+++ b/bin/moveucluster.pl	Mon Sep 12 17:58:12 2011 +0800
@@ -86,6 +86,7 @@
 use IO::Socket::INET;
 
 use lib "$ENV{LJHOME}/cgi-bin";
+use LJ::Cmdbuffer;
 
 # NOTE: these options are used both by Getopt::Long for command-line parsing
 # in single user move move, and also set by hand when in --jobserver mode,
@@ -650,7 +651,6 @@
     while (my $cmd = $dboa->selectrow_array("SELECT cmd FROM cmdbuffer WHERE journalid=$userid")) {
         die "Already flushed cmdbuffer job '$cmd' -- it didn't take?\n" if $cmd_done{$cmd}++;
         print "Flushing cmdbuffer for cmd: $cmd\n" if $optv > 1;
-        use LJ::Cmdbuffer;
         LJ::Cmdbuffer::flush($dbh, $dboa, $cmd, $userid);
     }
 
--------------------------------------------------------------------------------