fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-02-23 09:02 am

[dw-free] Make Stylesheet Text Box Larger

[commit: http://hg.dwscoalition.org/dw-free/rev/741f3b446e9f]

http://bugs.dwscoalition.org/show_bug.cgi?id=3491

Make the textbox larger, and move the label to the top so that it's obvious
what it applies to.

Patch by [staff profile] denise.

Files modified:
  • bin/upgrading/s2layers/core2.s2
  • cgi-bin/LJ/Widget/S2PropGroup.pm
  • htdocs/stc/widgets/s2propgroup.css
--------------------------------------------------------------------------------
diff -r b2d69ea7cd23 -r 741f3b446e9f bin/upgrading/s2layers/core2.s2
--- a/bin/upgrading/s2layers/core2.s2	Wed Feb 23 16:22:24 2011 +0800
+++ b/bin/upgrading/s2layers/core2.s2	Wed Feb 23 17:01:48 2011 +0800
@@ -1965,8 +1965,8 @@ property string custom_css {
 property string custom_css {
     des = "Use embedded CSS";
     note = "If you'd like to add custom CSS to this style, enter it here.";
-    cols = 50;
-    rows = 20;
+    cols = 60;
+    rows = 40;
     string_mode = "css";
 }
 
diff -r b2d69ea7cd23 -r 741f3b446e9f cgi-bin/LJ/Widget/S2PropGroup.pm
--- a/cgi-bin/LJ/Widget/S2PropGroup.pm	Wed Feb 23 16:22:24 2011 +0800
+++ b/cgi-bin/LJ/Widget/S2PropGroup.pm	Wed Feb 23 17:01:48 2011 +0800
@@ -337,7 +337,7 @@ sub output_prop {
     }
     
     my $ret;
-    $ret .= "<tr class='prop-row$row_class' width='100%'>";
+    $ret .= "<tr class='prop-row$row_class' width='100%' valign='top'>";
 
     if ($linklist_tab) {
         $ret .= "<td colspan='100%'>" . $class->ml( 'widget.s2propgroup.linkslisttab', {'name' => $linklist_tab} ) . "</td>";
@@ -345,7 +345,7 @@ sub output_prop {
         return $ret;
     }
 
-    $ret .= "<td class='prop-header'>" . LJ::eall( $prop->{des} ) . " " . LJ::help_icon( "s2opt_$prop->{name}" ) . "</td>"
+    $ret .= "<td class='prop-header' valign='top'>" . LJ::eall( $prop->{des} ) . " " . LJ::help_icon( "s2opt_$prop->{name}" ) . "</td>"
         unless $prop->{type} eq "Color" || $prop->{type} eq "string[]";
 
    $ret .= $class->output_prop_element( $prop, $prop_name, $u, $style, $theme, $props, 0, $grouped_prop_override );
diff -r b2d69ea7cd23 -r 741f3b446e9f htdocs/stc/widgets/s2propgroup.css
--- a/htdocs/stc/widgets/s2propgroup.css	Wed Feb 23 16:22:24 2011 +0800
+++ b/htdocs/stc/widgets/s2propgroup.css	Wed Feb 23 17:01:48 2011 +0800
@@ -29,6 +29,14 @@
     font-size: smaller;
 }
 
+.prop-header {
+    vertical-align: top;
+}
+
+.prop-input {
+    clear: left;
+}
+
 .s2propgroup-outer-expandcollapse {
     display: none;
 }
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org