fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-01-04 06:54 am

[dw-free] Need consistent styling across the site

[commit: http://hg.dwscoalition.org/dw-free/rev/f4b1db6cabc1]

http://bugs.dwscoalition.org/show_bug.cgi?id=3243

Zero out the default padding on table cells, for comment pages.

Patch by [personal profile] fu.

Files modified:
  • htdocs/stc/talkpage.css
  • htdocs/talkread.bml
--------------------------------------------------------------------------------
diff -r 778b99a9169a -r f4b1db6cabc1 htdocs/stc/talkpage.css
--- a/htdocs/stc/talkpage.css	Tue Jan 04 13:10:23 2011 +0800
+++ b/htdocs/stc/talkpage.css	Tue Jan 04 14:53:53 2011 +0800
@@ -53,6 +53,9 @@
     padding-right: 10px;
 }
 
+.spacer {
+    padding: 0;
+}
 .cmtbar {
     min-width: 50em;
     padding: 0;
@@ -73,8 +76,9 @@
 .cmtbar a img { /*comment action buttons*/
     padding: 0 5px;
 }
-td .commentbody {
+.commentbody {
     margin-bottom: 15px;
+    padding: 0;
 }
 
 a .userpic-img {
diff -r 778b99a9169a -r f4b1db6cabc1 htdocs/talkread.bml
--- a/htdocs/talkread.bml	Tue Jan 04 13:10:23 2011 +0800
+++ b/htdocs/talkread.bml	Tue Jan 04 14:53:53 2011 +0800
@@ -389,16 +389,16 @@ body<=
 
         if ($post->{'state'} eq "D") {
             $ret .= "<p><a name='$htmlid'></a><table summary='' class='delcomment'><tr>";
-            $ret .= "<td><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
+            $ret .= "<td class='spacer'><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
             $ret .= "<td>$ML{'.deletedpost'}</td></tr></table>\n";
         } elsif ($post->{'state'} eq "S" && !$post->{'_loaded'} && !$post->{'_show'}) {
             $ret .= "<p><a name='$htmlid'></a><table summary='' class='screenedcomment'><tr>";
-            $ret .= "<td><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
+            $ret .= "<td class='spacer'><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
             my $screenedtext = $ML{'.screenedpost'};
             $ret .= "<td>$screenedtext</td></tr></table>\n";
         } elsif ($pu && $pu->is_suspended && !$viewsome) {
             $ret .= "<p><a name='$htmlid'></a><table summary='' class='suspendedcomment'><tr>";
-            $ret .= "<td><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
+            $ret .= "<td class='spacer'><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
             $ret .= "<td>$ML{'.replysuspended'}";
             if (LJ::Talk::can_delete($remote, $u, $up, $userpost)) {
                 $ret .= " <a href='$LJ::SITEROOT/delcomment?${jargent}id=$dtid'>" . LJ::img("btn_del", "", { align => 'absmiddle', hspace => 2 }) . "</a>";
@@ -427,7 +427,7 @@ body<=
                 }
 
                 $ret .= "<div id='$htmlid'><table summary='' width='100%' class='talk-comment'><tbody><tr>";
-                $ret .= "<td rowspan='2'><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
+                $ret .= "<td rowspan='2' class='spacer'><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
                 $ret .= "<td id='cmtbar$dtid' class='cmtbar $level $additional_classes' width='100%'>";
 
                 # Build the image tag for the comment's userpic, if there is one
@@ -608,7 +608,7 @@ body<=
 
                 my $url = LJ::Talk::talkargs( $talkurl, "thread=$dtid", $style_args ) . LJ::Talk::comment_anchor( $dtid );
                 $ret .= "<div id='$htmlid'><table summary=''><tbody><tr>";
-                $ret .= "<td><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
+                $ret .= "<td class='spacer'><img src='$LJ::IMGPREFIX/dot.gif' alt='' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
                 $ret .= "<td>";
                 if ($post->{'state'} eq 'F') {
                     $ret .= "($T{'frozen'}) ";
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org