fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2011-01-03 04:48 pm

[dw-free] Need consistent styling across the site

[commit: http://hg.dwscoalition.org/dw-free/rev/a74ce46cfdcb]

http://bugs.dwscoalition.org/show_bug.cgi?id=3243

Fix spacing in the comment icon / subject area.

Patch by [personal profile] fu.

Files modified:
  • htdocs/stc/talkpage.css
  • htdocs/talkread.bml
--------------------------------------------------------------------------------
diff -r b80a582e4b06 -r a74ce46cfdcb htdocs/stc/talkpage.css
--- a/htdocs/stc/talkpage.css	Sat Jan 01 21:51:23 2011 +0800
+++ b/htdocs/stc/talkpage.css	Tue Jan 04 00:47:50 2011 +0800
@@ -55,10 +55,19 @@
 
 .cmtbar {
     min-width: 50em;
+    padding: 0;
 }
 
-.cmtbar-odd img, .cmtbar-even img {
+.cmtbar .icon {
+    float: left;
+}
+
+.cmtbar .icon img {
+    display: block;
     padding-right: 10px;
+}
+.cmtbar.noicon {
+    padding-left: 10px;
 }
 
 td .commentbody {
diff -r b80a582e4b06 -r a74ce46cfdcb htdocs/talkread.bml
--- a/htdocs/talkread.bml	Sat Jan 01 21:51:23 2011 +0800
+++ b/htdocs/talkread.bml	Tue Jan 04 00:47:50 2011 +0800
@@ -366,8 +366,9 @@ body<=
         my $level = ($opts->{'depth'} % 2) ? "even" : "odd";
 
         my $additional_classes = "";
-        $additional_classes .= "screened" if $post->{state} eq "S";
-        $additional_classes .= "highlight" if $last_talkid == $dtid && $last_jid == $u->userid;
+        $additional_classes .= "screened " if $post->{state} eq "S";
+        $additional_classes .= "highlight " if $last_talkid == $dtid && $last_jid == $u->userid;
+        $additional_classes .= "noicon " unless $post->{picid};
 
         # Gather information about the comment poster
         my $pu = $post->{'posterid'} ? $user{$post->{'posterid'}} : undef;
@@ -443,7 +444,7 @@ body<=
                    );
 
                    # build the imgtag for the userpic associated with the keyword
-                   $ret .= "<div style=\"float:left\"><a href='" . $upost->allpics_base . "'>" . $postpic->imgtag( %kwopts ) . "</a></div>";
+                   $ret .= "<div class='icon'><a href='" . $upost->allpics_base . "'>" . $postpic->imgtag( %kwopts ) . "</a></div>";
 
                 }
 
--------------------------------------------------------------------------------