janinedog: (Default)
Janine ([personal profile] janinedog) wrote in [site community profile] changelog2009-04-05 02:03 am

[dw-free] Strip ad-related code from the codebase

[commit: http://hg.dwscoalition.org/dw-free/rev/e7e3d648ab7d]

http://bugs.dwscoalition.org/show_bug.cgi?id=137

Remove ad-related code from this page.

Patch by [personal profile] ysobel.

Files modified:
  • htdocs/manage/circle/add.bml
--------------------------------------------------------------------------------
diff -r 2276c707d94f -r e7e3d648ab7d htdocs/manage/circle/add.bml
--- a/htdocs/manage/circle/add.bml	Sun Apr 05 01:59:49 2009 +0000
+++ b/htdocs/manage/circle/add.bml	Sun Apr 05 02:02:56 2009 +0000
@@ -3,13 +3,6 @@
     use strict;
 
     use vars qw($body $title $windowtitle %GET %POST);
-
-    my $print_with_ad = sub {
-       my $str = shift;
-
-       my $ad_box = LJ::get_ads({ location => 'bml.friends.add/error', ljadwrapper => 1 });
-       return $ad_box . $str;
-    };
 
     my $head     = \$_[1]->{'head'};
 
@@ -29,14 +22,14 @@
     unless ($remote)
     {
         $title = $ML{'.error1.title'};
-        $body = $print_with_ad->("<?needlogin?>");
+        $body = "<?needlogin?>";
         return;
     }
 
     unless ($user && $userid)
     {
         $title = $ML{'Error'};
-        $body = $print_with_ad->(BML::ml('.error2.text2', {'aopts' => "href='$LJ::SITEROOT/manage/circle/edit.bml'"}));
+        $body = BML::ml('.error2.text2', {'aopts' => "href='$LJ::SITEROOT/manage/circle/edit.bml'"});
         return;
     }
 
@@ -44,19 +37,19 @@
     {
         unless (LJ::did_post()) {
             $title = $ML{'Error'};
-            $body = $print_with_ad->("<?h1 $ML{'Error'} h1?><?p <?requirepost?> p?>");
+            $body = "<?h1 $ML{'Error'} h1?><?p <?requirepost?> p?>";
             return;
         }
 
         unless (LJ::check_form_auth()) {
             $title = $ML{'Error'};
-            $body = $print_with_ad->("<?h1 $ML{'Error'} h1?><?p $ML{'error.invalidform'} p?>");
+            $body = "<?h1 $ML{'Error'} h1?><?p $ML{'error.invalidform'} p?>";
             return;
         }
 
         unless ($remote->{'userid'} == $POST{'remid'}) {
             $title = $ML{'Error'};
-            $body = $print_with_ad->("<?h1 $ML{'Error'} h1?><?p $ML{'.error.sessionchanged'} p?>");
+            $body = "<?h1 $ML{'Error'} h1?><?p $ML{'.error.sessionchanged'} p?>";
             return;
         }
 
@@ -94,11 +87,7 @@
             } );
         }
 
-        $body = LJ::get_ads({
-            location    => 'bml.friends.add/main',
-            ljadwrapper => 1,
-            below_ad    => LJ::CProd->full_box_for($remote, width => 300)
-        });
+        $body = "";
 
         $title = $ML{'.add.title'};
         $body .= "<?h1 $ML{'.add.header'} h1?>";
@@ -455,7 +444,6 @@
 
 
     $body .= "</form>";
-    $body = $print_with_ad->($body);
 
     return;
 }
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org