fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-12-16 02:53 pm

[dw-free] fix warning from LJ/S2.pm - don't needlessly de-re-reference hashrefs

[commit: http://hg.dwscoalition.org/dw-free/rev/7563fc11f80c]

http://bugs.dwscoalition.org/show_bug.cgi?id=3327

Don't needlessly convert back and forth, to avoid potential issues with
undef values. The returned value is what we're looking for anyway,

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/LJ/S2.pm
--------------------------------------------------------------------------------
diff -r 59a347441ae9 -r 7563fc11f80c cgi-bin/LJ/S2.pm
--- a/cgi-bin/LJ/S2.pm	Fri Dec 10 19:40:16 2010 +0800
+++ b/cgi-bin/LJ/S2.pm	Thu Dec 16 22:53:38 2010 +0800
@@ -2124,7 +2124,7 @@ sub Page
         'head_content' => '',
         'data_link' => {},
         'data_links_order' => [],
-        '_styleopts' => \%{ LJ::viewing_style_opts( %$get ) },
+        _styleopts => LJ::viewing_style_opts( %$get ),
         timeformat24 => $remote && $remote->use_24hour_time
     };
 
--------------------------------------------------------------------------------