fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-11-08 12:35 pm

[dw-free] cannot expand comments in IE7 using sitescheme or light format

[commit: http://hg.dwscoalition.org/dw-free/rev/447ebe49b766]

http://bugs.dwscoalition.org/show_bug.cgi?id=3181

Fix HTML so that IE can properly detect an element with the id cmt###.

Patch by [personal profile] fu.

Files modified:
  • htdocs/talkread.bml
--------------------------------------------------------------------------------
diff -r c0c9301e1e51 -r 447ebe49b766 htdocs/talkread.bml
--- a/htdocs/talkread.bml	Mon Nov 08 16:24:17 2010 +0800
+++ b/htdocs/talkread.bml	Mon Nov 08 20:35:32 2010 +0800
@@ -485,7 +485,7 @@ body<=
                     $editreason = "($editreason)" if $editreason;
                 }
 
-                $ret .= "<a name='$htmlid'></a><span id='$htmlid'><table width='100%' class='talk-comment'><tbody><tr>";
+                $ret .= "<div id='$htmlid'><table width='100%' class='talk-comment'><tbody><tr>";
                 $ret .= "<td rowspan='2'><img src='$LJ::IMGPREFIX/dot.gif' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
                 $ret .= "<td id='cmtbar$dtid' class='cmtbar-$level' style='background-color: $bgcolor' width='100%'>";
 
@@ -661,12 +661,12 @@ body<=
 
                 $ret .= LJ::make_qr_target($dtid) if $remote;
 
-                $ret .= "</td></tr></tbody></table></span>\n";  # close colored table
+                $ret .= "</td></tr></tbody></table></div>\n";  # close colored table
             } else {
                 # link to message
 
                 my $url = LJ::Talk::talkargs( $talkurl, "thread=$dtid", $style_args ) . LJ::Talk::comment_anchor( $dtid );
-                $ret .= "<a name='$htmlid'></a><span id='$htmlid'><table ><tbody><tr>";
+                $ret .= "<div id='$htmlid'><table ><tbody><tr>";
                 $ret .= "<td><img src='$LJ::IMGPREFIX/dot.gif' height='1' width='" . ($opts->{'depth'} * 25) . "'></td>";
                 $ret .= "<td>";
                 if ($post->{'state'} eq 'F') {
@@ -678,7 +678,7 @@ body<=
                 # Comment Posted Notice
                 $ret .= " - <b>$ML{'.posted'}</b>"
                     if $last_talkid == $dtid && $last_jid == $u->userid;
-                $ret .= "</td></tr></tbody></table></span>\n";
+                $ret .= "</td></tr></tbody></table></div>\n";
             }
         }
 
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org