fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-11-03 05:59 am

[dw-free] DW/Controller/Admin.pm fails 00-compile.t

[commit: http://hg.dwscoalition.org/dw-free/rev/cf6107425509]

http://bugs.dwscoalition.org/show_bug.cgi?id=3182

Require, instead of autouse.

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/DW/Controller/SiteStats.pm
  • cgi-bin/DW/External/XPostProtocol.pm
  • cgi-bin/DW/StatData.pm
  • cgi-bin/LJ/EventLogRecord.pm
  • cgi-bin/LJ/S2Theme.pm
  • cgi-bin/LJ/Setting.pm
  • cgi-bin/LJ/Widget.pm
  • cgi-bin/LJ/Widget/IPPU.pm
  • cgi-bin/LJ/Widget/SubmitRequest.pm
--------------------------------------------------------------------------------
diff -r b54dd928e62c -r cf6107425509 cgi-bin/DW/Controller/SiteStats.pm
--- a/cgi-bin/DW/Controller/SiteStats.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/DW/Controller/SiteStats.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -36,7 +36,7 @@ use DW::StatData;
 use DW::StatData;
 use DW::Controller::Admin;
 
-LJ::ModuleLoader::autouse_subclasses( 'DW::StatData' );
+LJ::ModuleLoader::require_subclasses( 'DW::StatData' );
 
 DW::Routing->register_string( '/stats/site', \&stats_page, app => 1,
                               args => [ 'stats/site.tt', \&public_data, 1 ] );
diff -r b54dd928e62c -r cf6107425509 cgi-bin/DW/External/XPostProtocol.pm
--- a/cgi-bin/DW/External/XPostProtocol.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/DW/External/XPostProtocol.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -17,7 +17,7 @@ use strict;
 use strict;
 use warnings;
 use LJ::ModuleLoader;
-LJ::ModuleLoader->autouse_subclasses("DW::External::XPostProtocol");
+LJ::ModuleLoader->require_subclasses( "DW::External::XPostProtocol" );
 
 my %protocols;
 eval { $protocols{"lj"} = DW::External::XPostProtocol::LJXMLRPC->new; };
diff -r b54dd928e62c -r cf6107425509 cgi-bin/DW/StatData.pm
--- a/cgi-bin/DW/StatData.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/DW/StatData.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -22,7 +22,7 @@ DW::StatData - Abstract superclass for s
     use DW::StatStore;  # to retrieve stored statistics from the database
     use DW::StatData;   # to serve as an API for gathering the data
     # load all the available DW::StatData::* submodules
-    LJ::ModuleLoader::autouse_subclasses( 'DW::StatData' );
+    LJ::ModuleLoader::require_subclasses( 'DW::StatData' );
 
     # get the latest set of pony statistics
     my $ponies = DW::StatData::Ponies->load_latest( DW::StatStore->get( "ponies" ) );
diff -r b54dd928e62c -r cf6107425509 cgi-bin/LJ/EventLogRecord.pm
--- a/cgi-bin/LJ/EventLogRecord.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/LJ/EventLogRecord.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -19,7 +19,7 @@ use TheSchwartz;
 use TheSchwartz;
 
 use LJ::ModuleLoader;
-LJ::ModuleLoader->autouse_subclasses('LJ::EventLogRecord');
+LJ::ModuleLoader->require_subclasses( 'LJ::EventLogRecord' );
 
 sub schwartz_capabilities {
     return (
diff -r b54dd928e62c -r cf6107425509 cgi-bin/LJ/S2Theme.pm
--- a/cgi-bin/LJ/S2Theme.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/LJ/S2Theme.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -17,7 +17,7 @@ use LJ::Customize;
 use LJ::Customize;
 use LJ::ModuleLoader;
 
-LJ::ModuleLoader->autouse_subclasses("LJ::S2Theme");
+LJ::ModuleLoader->require_subclasses( "LJ::S2Theme" );
 
 sub init {
     1;
diff -r b54dd928e62c -r cf6107425509 cgi-bin/LJ/Setting.pm
--- a/cgi-bin/LJ/Setting.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/LJ/Setting.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -17,9 +17,9 @@ use Carp qw(croak);
 use Carp qw(croak);
 use LJ::ModuleLoader;
 
-# Autouse all settings
-LJ::ModuleLoader->autouse_subclasses( "LJ::Setting" );
-LJ::ModuleLoader->autouse_subclasses( "DW::Setting" );
+# require all settings
+LJ::ModuleLoader->require_subclasses( "LJ::Setting" );
+LJ::ModuleLoader->require_subclasses( "DW::Setting" );
 
 # ----------------------------------------------------------------------------
 
diff -r b54dd928e62c -r cf6107425509 cgi-bin/LJ/Widget.pm
--- a/cgi-bin/LJ/Widget.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/LJ/Widget.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -19,8 +19,8 @@ use LJ::Auth;
 use LJ::Auth;
 
 # FIXME: don't really need all widgets now
-LJ::ModuleLoader->autouse_subclasses("LJ::Widget");
-LJ::ModuleLoader->autouse_subclasses("DW::Widget");
+LJ::ModuleLoader->require_subclasses( "LJ::Widget" );
+LJ::ModuleLoader->require_subclasses( "DW::Widget" );
 
 our $currentId = 1;
 
diff -r b54dd928e62c -r cf6107425509 cgi-bin/LJ/Widget/IPPU.pm
--- a/cgi-bin/LJ/Widget/IPPU.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/LJ/Widget/IPPU.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -17,7 +17,7 @@ use strict;
 use strict;
 
 # load all subclasses
-LJ::ModuleLoader->autouse_subclasses("LJ::Widget::IPPU");
+LJ::ModuleLoader->require_subclasses( "LJ::Widget::IPPU" );
 
 sub ajax { 1 }
 
diff -r b54dd928e62c -r cf6107425509 cgi-bin/LJ/Widget/SubmitRequest.pm
--- a/cgi-bin/LJ/Widget/SubmitRequest.pm	Wed Nov 03 13:48:13 2010 +0800
+++ b/cgi-bin/LJ/Widget/SubmitRequest.pm	Wed Nov 03 13:57:33 2010 +0800
@@ -19,7 +19,7 @@ use DW::Captcha;
 use DW::Captcha;
 
 use LJ::ModuleLoader;
-LJ::ModuleLoader->autouse_subclasses('LJ::Widget::SubmitRequest');
+LJ::ModuleLoader->require_subclasses( 'LJ::Widget::SubmitRequest' );
 
 sub need_res { }
 
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
No Subject Icon Selected
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org