afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)
afuna ([personal profile] afuna) wrote in [site community profile] changelog2009-04-03 03:47 pm

[dw-free] This user has no journal; they have an OpenID.

[commit: http://hg.dwscoalition.org/dw-free/rev/dc398e92c39a]

http://bugs.dwscoalition.org/show_bug.cgi?id=648

Friendlier error message when viewing the journal of an OpenID user.

Patch by [staff profile] denise.

Files modified:
  • cgi-bin/LJ/User.pm
--------------------------------------------------------------------------------
diff -r 31f5419a2a0e -r dc398e92c39a cgi-bin/LJ/User.pm
--- a/cgi-bin/LJ/User.pm	Fri Apr 03 15:42:45 2009 +0000
+++ b/cgi-bin/LJ/User.pm	Fri Apr 03 15:47:20 2009 +0000
@@ -8589,7 +8589,9 @@ sub make_journal
     }
     return $error->("This journal has been deleted and purged.", "410 Gone") if ($u->is_expunged);
 
-    return $error->("This user has no journal here.", "404 Not here") if $u->{'journaltype'} eq "I" && $view ne "read";
+    # FIXME: pretty this up at some point, to maybe auto-redirect to 
+    # the external URL or something, but let's just do this for now
+    return $error->("This user is an OpenID account and does not maintain a journal here. You might be able to see their content at <a href='" . $u->openid_identity . "'>" . $u->openid_identity . "</a>.", "404 Not here") if $u->{'journaltype'} eq "I" && $view ne "read";
 
     $opts->{'view'} = $view;
 
--------------------------------------------------------------------------------