kareila: (Default)
kareila ([personal profile] kareila) wrote in [site community profile] changelog2010-10-24 07:24 pm

[dw-free] Template with no output cause a redirect to /

[commit: http://hg.dwscoalition.org/dw-free/rev/8dfecffc3145]

http://bugs.dwscoalition.org/show_bug.cgi?id=3166

Avoid undesired redirects by testing for definedness instead of truthiness.

Patch by [personal profile] exor674.

Files modified:
  • htdocs/misc/render_sitescheme.bml
--------------------------------------------------------------------------------
diff -r 02a1e40fab97 -r 8dfecffc3145 htdocs/misc/render_sitescheme.bml
--- a/htdocs/misc/render_sitescheme.bml	Sun Oct 24 12:18:08 2010 -0500
+++ b/htdocs/misc/render_sitescheme.bml	Sun Oct 24 14:23:56 2010 -0500
@@ -26,7 +26,7 @@ body<=
     my $r = DW::Request->get;
     my $code = $r->pnote( 'render_sitescheme_code' );
     my $extras = $r->pnote( 'render_sitescheme_extra' );
-    return BML::redirect($LJ::SITEROOT) unless $code;
+    return BML::redirect( $LJ::SITEROOT ) unless defined $code;
 
     $head = $extras->{head} || "";
     $title = $extras->{title} || "";
--------------------------------------------------------------------------------