[dw-free] Theme categories (tags?) are hardcoded in the code backend

[fu]

[commit: http://hg.dwscoalition.org/dw-free/rev/6536e68916d3]

http://bugs.dwscoalition.org/show_bug.cgi?id=1744

Cleanup names. For less redundancy, we can remove the "sub designer" and
instead use layerinfo author_name as a display name when selecting a theme.
So a little cleanup in that area.

Patch by fu.

Files modified:

• bin/upgrading/s2layers/skittlishdreams/themes.s2
• cgi-bin/LJ/S2Theme/basicboxes.pm

--------------------------------------------------------------------------------
diff -r 144ba4524d6e -r 6536e68916d3 bin/upgrading/s2layers/skittlishdreams/themes.s2
--- a/bin/upgrading/s2layers/skittlishdreams/themes.s2	Sat Oct 23 12:27:29 2010 +0800
+++ b/bin/upgrading/s2layers/skittlishdreams/themes.s2	Sat Oct 23 22:16:44 2010 +0800
@@ -2,7 +2,7 @@ layerinfo type = "theme";
 layerinfo type = "theme";
 layerinfo name = "Academy";
 layerinfo redist_uniq = "skittlishdreams/academy";
-layerinfo author_name = "Sarken";
+layerinfo author_name = "sarken";
 
 set theme_authors = [ { "name" => "sarken", "type" => "user" } ];
 
@@ -187,7 +187,7 @@ layerinfo type = "theme";
 layerinfo type = "theme";
 layerinfo name = "Desert Cream";
 layerinfo redist_uniq = "skittlishdreams/desertcream";
-layerinfo author_name = "Sarken";
+layerinfo author_name = "sarken";
 
 set theme_authors = [ { "name" => "sarken", "type" => "user" } ];
 
@@ -310,7 +310,7 @@ layerinfo type = "theme";
 layerinfo type = "theme";
 layerinfo name = "In the Bag";
 layerinfo redist_uniq = "skittlishdreams/inthebag";
-layerinfo author_name = "Sarken";
+layerinfo author_name = "sarken";
 
 set theme_authors = [ { "name" => "sarken", "type" => "user" } ];
 
@@ -381,7 +381,7 @@ layerinfo type = "theme";
 layerinfo type = "theme";
 layerinfo name = "Like Sunshine";
 layerinfo redist_uniq = "skittlishdreams/likesunshine";
-layerinfo author_name = "Sarken";
+layerinfo author_name = "sarken";
 
 set theme_authors = [ { "name" => "sarken", "type" => "user" } ];
 
@@ -618,7 +618,7 @@ layerinfo type = "theme";
 layerinfo type = "theme";
 layerinfo name = "Snow Cherries";
 layerinfo redist_uniq = "skittlishdreams/snowcherries";
-layerinfo author_name = "Sarken";
+layerinfo author_name = "sarken";
 
 set theme_authors = [ { "name" => "sarken", "type" => "user" } ];
 
diff -r 144ba4524d6e -r 6536e68916d3 cgi-bin/LJ/S2Theme/basicboxes.pm
--- a/cgi-bin/LJ/S2Theme/basicboxes.pm	Sat Oct 23 12:27:29 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/basicboxes.pm	Sat Oct 23 22:16:44 2010 +0800
@@ -29,14 +29,14 @@ sub cats { qw() }
 sub cats { qw() }
 sub designer { "kareila" }
 
-package LJ::S2Theme::basicboxes::green;
-use base qw( LJ::S2Theme::basicboxes );
-sub cats { qw() }
-
 package LJ::S2Theme::basicboxes::freshwater;
 use base qw( LJ::S2Theme::basicboxes );
 sub cats { qw( featured ) }
 sub designer { "timeasmymeasure" }
+
+package LJ::S2Theme::basicboxes::green;
+use base qw( LJ::S2Theme::basicboxes );
+sub cats { qw() }
 
 package LJ::S2Theme::basicboxes::leaf;
 use base qw( LJ::S2Theme::basicboxes );
--------------------------------------------------------------------------------