kareila: (Default)
kareila ([personal profile] kareila) wrote in [site community profile] changelog2010-10-23 03:51 am

[dw-free] clean up log messages that appear when global warnings are on

[commit: http://hg.dwscoalition.org/dw-free/rev/458e61bf06ef]

http://bugs.dwscoalition.org/show_bug.cgi?id=3040

Make sure we only avoid this path when the filter argument is zero.

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/LJ/S2/FriendsPage.pm
--------------------------------------------------------------------------------
diff -r b61bdc1afbd2 -r 458e61bf06ef cgi-bin/LJ/S2/FriendsPage.pm
--- a/cgi-bin/LJ/S2/FriendsPage.pm	Sat Oct 23 11:39:13 2010 +0800
+++ b/cgi-bin/LJ/S2/FriendsPage.pm	Fri Oct 22 22:51:27 2010 -0500
@@ -132,8 +132,8 @@ sub FriendsPage
             $p->{filter_name} = $opts->{securityfilter};
     } else {
     # but we can't just use a filter, we have to make sure the person is allowed to
-        if ( ( ! $get->{filter} || $get->{filter} && $get->{filter} ne "0" )
-            && $cf && ( $u->equals( $remote ) || $cf->public ) ) {
+        if ( ( ! defined $get->{filter} || $get->{filter} ne "0" )
+                && $cf && ( $u->equals( $remote ) || $cf->public ) ) {
             $filter = $cf;
 
         # if we couldn't use the group, then we can throw an error, but ONLY IF they specified
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org