fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-10-22 03:12 pm

[dw-free] Brittle: use appropriate props for sidebar module colors and entry link colors

[commit: http://hg.dwscoalition.org/dw-free/rev/af8a089f4abd]

http://bugs.dwscoalition.org/show_bug.cgi?id=2976

Make sure that background and foreground colors have matching variables: use
entry colors for elements printed over the page background. Use page colors
for sidebar modules other than navigation.

Patch by [personal profile] ninetydegrees.

Files modified:
  • bin/upgrading/s2layers/brittle/layout.s2
--------------------------------------------------------------------------------
diff -r 8b6c7a57e647 -r af8a089f4abd bin/upgrading/s2layers/brittle/layout.s2
--- a/bin/upgrading/s2layers/brittle/layout.s2	Fri Oct 22 22:57:33 2010 +0800
+++ b/bin/upgrading/s2layers/brittle/layout.s2	Fri Oct 22 23:12:04 2010 +0800
@@ -379,15 +379,15 @@ q { font-style: italic; }
     margin: 1px 0 0 0;
     padding: 0 1em;
     font-size: 1em;
-    color: $*color_navigation_module_background;
 }
 
 #tertiary {
+    background-color: $*color_entry_background;
     clear: both;
+    color: $*color_entry_text;
+    line-height: 125%;
     margin-$sidebar_position: auto;
     width: 45%;
-    background-color: $*color_entry_background;
-    line-height: 125%;
     }
 
 #tertiary > .inner:first-child { }
@@ -441,6 +441,18 @@ div.navigation ul {
     padding: 10px;
     margin: 0 0 10px 0;
     $entry_font
+    }
+
+.entry a, #tertiary a {
+    color: $*color_entry_link;
+    }
+
+.entry a:visited, #tertiary a:visited {
+    color: $*color_entry_link_visited;
+    }
+
+.entry a:hover, #tertiary a:hover {
+    color: $*color_entry_link_hover;
     }
 
 .entry-content { margin: 10px 0 0 0; }
@@ -786,10 +798,7 @@ table.talkform {
     text-align: center;
     }
 
-#secondary .module-customtext { color: $*color_navigation_module_background; }
-
 .module-header {
-    color: $*color_entry_title;
     $module_title_font
     font-weight: normal;
     letter-spacing: 1px;
@@ -801,12 +810,6 @@ table.talkform {
     }
 
 .module-customtext .module-header { text-align: center; }
-
-#secondary .module-header a,
-#secondary .module-header a:link,
-#secondary .module-header a:visited,
-#secondary .module-header a:hover
-    { color: $*color_navigation_module_background; }
 
 #tertiary .module-header a,
 #tertiary .module-header a:link,
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org