fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-10-16 02:29 pm
  • Add Memory
  • Share This Entry

[dw-free] Eliminate Class::Autouse from the code

[commit: http://hg.dwscoalition.org/dw-free/rev/b5317034bbfe]

http://bugs.dwscoalition.org/show_bug.cgi?id=1761

Last bit (Class::Autouse doesn't offer any advantages in persistent
environments such as the mod_perl environment, so remove it)

Patch by [personal profile] kareila.

Files modified:
  • htdocs/admin/sitemessages/add.bml
  • htdocs/admin/sitemessages/manage.bml
  • htdocs/community/moderate.bml
  • htdocs/customize/preview_redirect.bml
  • htdocs/editprivacy.bml
  • htdocs/inbox/compose.bml
  • htdocs/inbox/index.bml
  • htdocs/manage/subscriptions/comments.bml
  • htdocs/manage/subscriptions/entry.bml
  • htdocs/manage/subscriptions/user.bml
  • htdocs/tools/endpoints/checkforusername.bml
  • htdocs/tools/endpoints/widget.bml
--------------------------------------------------------------------------------
diff -r eb0491af909b -r b5317034bbfe htdocs/admin/sitemessages/add.bml
--- a/htdocs/admin/sitemessages/add.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/admin/sitemessages/add.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -18,7 +18,7 @@ body<=
 {
     use strict;
     use vars qw(%GET %POST $title $headextra @errors @warnings);
-    use Class::Autouse qw( LJ::SiteMessages );
+    use LJ::SiteMessages;
 
     my $remote = LJ::get_remote();
 
diff -r eb0491af909b -r b5317034bbfe htdocs/admin/sitemessages/manage.bml
--- a/htdocs/admin/sitemessages/manage.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/admin/sitemessages/manage.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -18,7 +18,7 @@ body<=
 {
     use strict;
     use vars qw(%GET %POST $title $headextra @errors @warnings);
-    use Class::Autouse qw( LJ::SiteMessages );
+    use LJ::SiteMessages;
 
     my $remote = LJ::get_remote();
 
diff -r eb0491af909b -r b5317034bbfe htdocs/community/moderate.bml
--- a/htdocs/community/moderate.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/community/moderate.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -19,10 +19,10 @@ body<=
 
 {
     use strict;
+    use LJ::Poll;
     use vars qw(%GET %POST);
     LJ::set_active_crumb('moderate');
     return LJ::server_down_html() if ($LJ::SERVER_DOWN);
-    use Class::Autouse qw (LJ::Poll);
 
     my $ret;
     my $remote = LJ::get_remote();
diff -r eb0491af909b -r b5317034bbfe htdocs/customize/preview_redirect.bml
--- a/htdocs/customize/preview_redirect.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/customize/preview_redirect.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -18,7 +18,7 @@ body<=
 {
     use strict;
     use vars qw(%GET %POST $title $headextra @errors @warnings);
-    use Class::Autouse qw( LJ::S2Theme );
+    use LJ::S2Theme;
 
     my $u = LJ::get_effective_remote();
     return $ML{'.error.user'} unless LJ::isu($u);
diff -r eb0491af909b -r b5317034bbfe htdocs/editprivacy.bml
--- a/htdocs/editprivacy.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/editprivacy.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -19,7 +19,7 @@ body<=
 {
     use strict;
     use vars qw(%POST %GET);
-    use Class::Autouse qw(LJ::MassPrivacy);
+    use LJ::MassPrivacy;
     BML::decl_params(_default => qr/./);
 
     my $remote = LJ::get_remote();
diff -r eb0491af909b -r b5317034bbfe htdocs/inbox/compose.bml
--- a/htdocs/inbox/compose.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/inbox/compose.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -20,10 +20,8 @@ body<=
     use vars qw(%GET %POST);
 
     use warnings;
-    use Class::Autouse qw(
-                          LJ::Message
-                          LJ::JSUtil
-                          );
+    use LJ::Message;
+    use LJ::JSUtil;
 
     return $ML{'.messaging.disabled'} unless LJ::is_enabled( 'user_messaging' );
 
diff -r eb0491af909b -r b5317034bbfe htdocs/inbox/index.bml
--- a/htdocs/inbox/index.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/inbox/index.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -18,10 +18,8 @@ body<=
 {
     use strict;
     use vars qw($title $body $head %GET %POST);
-    use Class::Autouse qw (
-                           LJ::NotificationInbox
-                           LJ::Event
-                           );
+    use LJ::NotificationInbox;
+    use LJ::Event;
 
     $title = $ML{'.title'};
     $body = "";
diff -r eb0491af909b -r b5317034bbfe htdocs/manage/subscriptions/comments.bml
--- a/htdocs/manage/subscriptions/comments.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/manage/subscriptions/comments.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -20,16 +20,13 @@ body<=
     use vars qw (%POST %GET $body $title $headextra @errors);
     use Carp qw(croak);
     use LJ::Subscription;
+    use LJ::NotificationMethod;
+    use LJ::Event;
+    use LJ::Comment;
 
     $title = 'Manage Message Settings';
 
     return "Not ready" unless LJ::is_enabled('esn');
-
-    use Class::Autouse qw(
-                          LJ::NotificationMethod
-                          LJ::Event
-                          LJ::Comment
-                          );
 
     BML::decl_params(
                      lj_form_auth => qr/./,
diff -r eb0491af909b -r b5317034bbfe htdocs/manage/subscriptions/entry.bml
--- a/htdocs/manage/subscriptions/entry.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/manage/subscriptions/entry.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -19,12 +19,12 @@ body<=
     use strict;
     use vars qw (%POST %GET $body $title $headextra);
     use Carp qw(croak);
+    use LJ::NotificationMethod;
+    use LJ::Event;
 
     $title = 'Manage Message Settings';
 
     return "Not ready" unless LJ::is_enabled('esn');
-
-    use Class::Autouse qw(LJ::NotificationMethod LJ::Event);
 
     BML::decl_params(
                      lj_form_auth => qr/./,
diff -r eb0491af909b -r b5317034bbfe htdocs/manage/subscriptions/user.bml
--- a/htdocs/manage/subscriptions/user.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/manage/subscriptions/user.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -19,12 +19,12 @@ body<=
     use strict;
     use vars qw (%POST %GET $body $title $headextra);
     use Carp qw(croak);
+    use LJ::NotificationMethod;
+    use LJ::Event;
 
     $title = 'Manage Message Settings';
 
     return "Not ready" unless LJ::is_enabled('esn');
-
-    use Class::Autouse qw(LJ::NotificationMethod LJ::Event);
 
     BML::decl_params(
                      lj_form_auth => qr/./,
diff -r eb0491af909b -r b5317034bbfe htdocs/tools/endpoints/checkforusername.bml
--- a/htdocs/tools/endpoints/checkforusername.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/tools/endpoints/checkforusername.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -17,7 +17,7 @@ _c?>
     use strict;
     use vars qw(%GET);
     use JSON;
-    use Class::Autouse qw( LJ::CreatePage );
+    use LJ::CreatePage;
 
     my $error = LJ::CreatePage->verify_username($GET{user});
 
diff -r eb0491af909b -r b5317034bbfe htdocs/tools/endpoints/widget.bml
--- a/htdocs/tools/endpoints/widget.bml	Sat Oct 16 22:14:28 2010 +0800
+++ b/htdocs/tools/endpoints/widget.bml	Sat Oct 16 22:25:11 2010 +0800
@@ -17,11 +17,9 @@ _c?>
     use strict;
     use vars qw(%GET %POST @errors);
 
-    use Class::Autouse(qw(
-                          LJ::Auth
-                          JSON
-                          LJ::Widget::IPPU
-                          ));
+    use LJ::Auth;
+    use JSON;
+    use LJ::Widget::IPPU;
 
     my $err = sub {
         my $msg = shift;
--------------------------------------------------------------------------------
  • Add Memory
  • Share This Entry
(0 comments)

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org

 
Notice: This account is set to log the IP addresses of everyone who comments.
Links will be displayed as unclickable URLs to help prevent spam.