fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] changelog2010-10-14 03:29 am

[dw-free] Don't announce upcoming birthdays for deleted journals

[commit: http://hg.dwscoalition.org/dw-free/rev/e9890bfa3316]

http://bugs.dwscoalition.org/show_bug.cgi?id=2588

Don't notify about deleted journals, nor show on the birthday lists.

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/LJ/User.pm
--------------------------------------------------------------------------------
diff -r 891879298ff0 -r e9890bfa3316 cgi-bin/LJ/User.pm
--- a/cgi-bin/LJ/User.pm	Wed Oct 13 13:27:24 2010 +0800
+++ b/cgi-bin/LJ/User.pm	Thu Oct 14 11:29:27 2010 +0800
@@ -3523,12 +3523,13 @@ sub can_join_adult_comm {
 
 # Birthday logic -- should a notification be sent?
 # Currently the same logic as can_show_bday with an exception for
-# journals that have memorial status.
+# journals that have memorial or deleted status.
 sub can_notify_bday {
     my ( $u, %opts ) = @_;
     croak "invalid user object passed" unless LJ::isu( $u );
 
     return 0 if $u->is_memorial;
+    return 0 if $u->is_deleted;
 
     return $u->can_show_bday( %opts );
 }
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org