[dw-free] openids cannot select icons in ?mode=reply

[fu]

[commit: http://hg.dwscoalition.org/dw-free/rev/df0306930552]

http://bugs.dwscoalition.org/show_bug.cgi?id=2959

Don't disable icon dropdown for logged in openid users.

Patch by fu.

Files modified:

• htdocs/js/talkpost.js

--------------------------------------------------------------------------------
diff -r b89e286f4d4c -r df0306930552 htdocs/js/talkpost.js
--- a/htdocs/js/talkpost.js	Tue Aug 17 17:42:33 2010 +0800
+++ b/htdocs/js/talkpost.js	Tue Aug 17 18:00:54 2010 +0800
@@ -122,7 +122,7 @@ function handleRadios(sel) {
         }
     }
 
-    if (sel_pickw.disabled = (sel != 1)) sel_pickw.value='';
+    if (sel_pickw.disabled = (sel != 1 && sel != 4 )) sel_pickw.value='';
 }
 
 function submitHandler() {
--------------------------------------------------------------------------------

Comments

[kareila]

Wow, this is one of the most obscure things I've ever seen. I think it's the use of magic integers instead of some sort of named value that is throwing me.

[fu]

Ugh, I know! I hope to fix it at some point but decided not to dwell on it. For now.

[kareila]

Good call. I couldn't let it pass without comment, though. :)