[dw-free] What to do with LJ::PersistentQueue ?
[commit: http://hg.dwscoalition.org/dw-free/rev/f34920fb3665]
http://bugs.dwscoalition.org/show_bug.cgi?id=1787
Remove unused code.
Patch by
kareila.
Files modified:
http://bugs.dwscoalition.org/show_bug.cgi?id=1787
Remove unused code.
Patch by
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Files modified:
- cgi-bin/LJ/PersistentQueue.pm
- t/00-compile.t
-------------------------------------------------------------------------------- diff -r e5a8ee8c1d89 -r f34920fb3665 cgi-bin/LJ/PersistentQueue.pm --- a/cgi-bin/LJ/PersistentQueue.pm Fri Jun 25 15:00:31 2010 +0800 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,44 +0,0 @@ -# This code was forked from the LiveJournal project owned and operated -# by Live Journal, Inc. The code has been modified and expanded by -# Dreamwidth Studios, LLC. These files were originally licensed under -# the terms of the license supplied by Live Journal, Inc, which can -# currently be found at: -# -# http://code.livejournal.org/trac/livejournal/browser/trunk/LICENSE-LiveJournal.txt -# -# In accordance with the original license, this code and all its -# modifications are provided under the GNU General Public License. -# A copy of that license can be found in the LICENSE file included as -# part of this distribution. - -package LJ::PersistentQueue; - -use strict; -use warnings; -use Data::Queue::Persistent; - -sub new { - my ($class, %opts) = @_; - - my $dbh = delete $opts{dbh} || LJ::get_db_writer(); - - return Data::Queue::Persistent->new( - table => 'persistent_queue', - cache => 0, - dbh => $dbh, - %opts, - ); -} - - - -package LJ; - -sub queue { - my ($id, $size) = @_; - - return LJ::PersistentQueue->new(id => $id, max_size => $size); -} - - -1; diff -r e5a8ee8c1d89 -r f34920fb3665 t/00-compile.t --- a/t/00-compile.t Fri Jun 25 15:00:31 2010 +0800 +++ b/t/00-compile.t Fri Jun 25 15:06:36 2010 +0800 @@ -13,7 +13,6 @@ my $dir = File::Temp::tempdir( CLEANUP = # instead of waiting them to be fixed we are skipping them for now # They should be fixed or marked why they cannot run. my %SKIP = ( - 'LJ/PersistentQueue.pm' => 'bug 1787 needs Data::Queue::Persistent', 'LJ/LDAP.pm' => 'bug 1788 needs Net::LDAP', 'LJ/ConfCheck/General.pm' => 'needs to be integrated into LJ::ConfCheck', --------------------------------------------------------------------------------