kareila: (Default)
kareila ([personal profile] kareila) wrote in [site community profile] changelog2010-06-25 12:11 am

[dw-free] Username in subject breaks entry link in active entries module

[commit: http://hg.dwscoalition.org/dw-free/rev/a94a9ded49c3]

http://bugs.dwscoalition.org/show_bug.cgi?id=2618

Strip html from the subject so that the link to the entry doesn't break in
the S2 active entries module.

Patch by [personal profile] penemue.

Files modified:
  • bin/upgrading/s2layers/core2.s2
--------------------------------------------------------------------------------
diff -r c0bc4044e818 -r a94a9ded49c3 bin/upgrading/s2layers/core2.s2
--- a/bin/upgrading/s2layers/core2.s2	Thu Jun 24 18:41:59 2010 -0500
+++ b/bin/upgrading/s2layers/core2.s2	Thu Jun 24 19:10:57 2010 -0500
@@ -3834,7 +3834,7 @@ function print_module_active() {
         open_module( "active", $*text_module_active_entries, "" );
         var int i = 1;
                 foreach var Entry activeentry ( $activeentries ) {
-                    var string subject = ( $activeentry.subject != "" ? $activeentry.subject : "$*text_nosubject" );
+                    var string subject = ( $activeentry.subject != "" ? striphtml($activeentry.subject) : "$*text_nosubject" );
                     $subjects[size $subjects] = """$i: <a href="$activeentry.permalink_url">$subject</a>""";
                     $i++;
                  }
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org