mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2010-04-21 11:06 pm

[dw-free] fix t/entrycomment-create.t

[commit: http://hg.dwscoalition.org/dw-free/rev/8af8ed80ed06]

http://bugs.dwscoalition.org/show_bug.cgi?id=2492

Fix test for comment posting to not try to send email.

Patch by [personal profile] kareila.

Files modified:
  • cgi-bin/LJ/Test.pm
  • t/entrycomment-create.t
--------------------------------------------------------------------------------
diff -r a2f067a771a7 -r 8af8ed80ed06 cgi-bin/LJ/Test.pm
--- a/cgi-bin/LJ/Test.pm	Wed Apr 21 23:01:40 2010 +0000
+++ b/cgi-bin/LJ/Test.pm	Wed Apr 21 23:06:05 2010 +0000
@@ -387,7 +387,7 @@ sub t_enter_comment {
                                  $entry->journal,
                                  $commentref,
                                  {talkid => $parenttalkid, state => 'A'},
-                                 {itemid => $jitemid, state => 'A'},
+                                 {itemid => $jitemid, state => 'A', opt_noemail => 1},
                                  \$err,
                                  );
 
diff -r a2f067a771a7 -r 8af8ed80ed06 t/entrycomment-create.t
--- a/t/entrycomment-create.t	Wed Apr 21 23:01:40 2010 +0000
+++ b/t/entrycomment-create.t	Wed Apr 21 23:06:05 2010 +0000
@@ -8,8 +8,7 @@ use LJ::Test qw(memcache_stress temp_use
 use LJ::Test qw(memcache_stress temp_user);
 use FindBin qw($Bin);
 
-#plan tests => 4;
-plan skip_all => 'Fix this test!';
+plan tests => 4;
 
 my $u = temp_user();
 ok($u, "got a user");
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org