mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] changelog2009-11-03 02:00 am

[dw-free] Javascript error in Safari when inbox count updates

[commit: http://hg.dwscoalition.org/dw-free/rev/dd9f380a08de]

http://bugs.dwscoalition.org/show_bug.cgi?id=2039

Fix bug with multiple 'mark all read' buttons causing a JavaScript error.

Patch by [personal profile] afuna.

Files modified:
  • htdocs/js/esn_inbox.js
--------------------------------------------------------------------------------
diff -r 7146131df1fb -r dd9f380a08de htdocs/js/esn_inbox.js
--- a/htdocs/js/esn_inbox.js	Tue Nov 03 01:54:20 2009 +0000
+++ b/htdocs/js/esn_inbox.js	Tue Nov 03 02:00:48 2009 +0000
@@ -380,8 +380,8 @@ ESN_Inbox.finishedUpdate = function (inf
     // 2 instances of action buttons with suffix 1 and 2
     for (var i=1; i<=2; i++) {
         $(folder + "_MarkRead_" + i).disabled    = unread_count ? false : true;
+        $(folder + "_MarkAllRead_" + i).disabled = unread_count ? false : true;
     }
-    $(folder + "_MarkAllRead").disabled = unread_count ? false : true;
 };
 
 ESN_Inbox.refresh_count = function(name, count) {
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org