kareila: (Default)
kareila ([personal profile] kareila) wrote in [site community profile] changelog2009-09-21 05:47 am

[dw-free] Navigation bar hrefs break on apostrophes

[commit: http://hg.dwscoalition.org/dw-free/rev/51aa51ab5f9f]

http://bugs.dwscoalition.org/show_bug.cgi?id=1725

Escape URIs in the navigation strip.

Patch by [staff profile] denise.

Files modified:
  • cgi-bin/weblib.pl
--------------------------------------------------------------------------------
diff -r dd5edc3e66a9 -r 51aa51ab5f9f cgi-bin/weblib.pl
--- a/cgi-bin/weblib.pl	Mon Sep 21 05:39:45 2009 +0000
+++ b/cgi-bin/weblib.pl	Mon Sep 21 00:47:09 2009 -0500
@@ -2857,7 +2857,7 @@ LOGIN_BAR
     #determine whether style is "mine", and define new uri variable to manipulate
     #note: all expressions case-insensitive
     my $currentstylemine = ($uri =~ m/style=mine/i);
-    my $newuri = $uri;
+    my $newuri = LJ::ehtml( $uri );
     #manipulate destination URI for the style links
     if ($currentstylemine) {
         #if last character before style=mine is a &, it can be deleted together with style=mine, 
--------------------------------------------------------------------------------

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org